Error Involving Arrays

[Stripeb49]

I'm trying to write a program that asks the users for a set of numbers which the program then sorts and counts the frequency of. I'm struggling with understanding arrays. I know I'm only using 3 parameters when I try to print the frequencyArray function which I know is wrong but I don't know why.

ERROR C2661: 'frequencyArray' : no overloaded function takes 3 arguments

// Includes
#include<iostream>
#include<iomanip>
#include<cmath>
#include<string>
	using namespace std;

// Function Prototypes
void showIntro(int, int, int, string);
int fillArray(int array[]);
void showArray(int array[], int n);
void bubbleSort(int array[], int n);
int frequencyArray(int dataArray[], int valueArray[], int countArray[], int n);
void swap(int array[], int i, int j);
void frequencyArray(int array[], int n);

// start of main
int main(void) {

	// call a function to display splash screen
	showIntro(3, 30, 2012, "This program will will create a frequency table for a list of values.");
	cout << endl; // because month is 3, using the switch it will recognize 3 as March

	// declare variables
	int dataArray[50]; // create an array of doubles
	int arraySize = 0;
	int valueArray[50];
	int countArray[50];
	int frequencyValue = 0;

	// Fill the array
	arraySize = fillArray(dataArray);
	
	// table header
	cout << endl;
	cout << "Value" << "   Frequency" << endl;

	// print the array
	showArray(dataArray, arraySize);

	// sort the array
	bubbleSort(dataArray, arraySize);
	
	// print the array
	showArray(dataArray, arraySize);

	//print the frequency array
	frequencyValue = frequencyArray(dataArray, arraySize, valueArray, countArray);
			
	system("pause");
	return 0;
}

// function to print splash screen
void showIntro(int m, int d, int y, string descript) { // declare variables
	
	// string for month
	string month = "";

	// cout << "March 30, 2012" << endl;
	// use parameters to set date

	//switch to set the month string
	switch(m) {
	case 1:
		month = "January";
		break;
	case 2:
		month = "February";
		break;
	case 3:
		month = "March";
		break;
	case 4:
		month = "April";
		break;
	case 5:
		month = "May";
		break;
	case 6:
		month = "June";
		break;
	case 7:
		month = "July";
		break;
	case 8:
		month = "August";
		break;
	case 9:
		month = "September";
		break;
	case 10:
		month = "October";
		break;
	case 11:
		month = "November";
		break;
	case 12:
		month = "December";
		break;
	default:
		month = "unknown";
		break;
	}

	cout << month << " " << d << ", " << y << endl;

	cout << descript << endl;

	return;
}
// function to sort an array of doubles
void bubbleSort(int array[], int n) { // use void because this is a stub function, serves as a placeholder
	// nested loop to compare each element with those that follow it
	for(int i=0; i<n-1; i++) {

		for(int j=i+1; j<n; j++) {

			// comparison
			if ( array[j] < array[i]) {
				swap(array, i, j);
			}
		}// end of inner loop
	} // end of outer loop

	return;
}
// function to swap elements at indeces i and j
void swap(int array[], int i, int j) { 
	
	// switching the two values by using an intermediate temporary variable, like tower of hanoi
	int temp;
	temp = array[j];
	array[j] = array[i];
	array[i] = temp;
}
// function to fill array with doubles
int fillArray(int array[]) {
	
	int n = -99; // Number of data point
	// Prompt for the number of data points
	cout << "How many values will you enter? ";
	cin >> n;

	// Loop to enter data
	for(int i = 0; i < n; i++) {

		// Enter the data point
		cout << "Enter data point " << (i+1) << ": ";
		cin >> array[i];

	}

	return n;
}
// function to print array to the screen
void showArray(int array[], int n) {
	
	// print a linefeed
	cout << endl;

	// Loop through the array printing the values
	for(int i = 0; i < n; i++) {
		// Print element i
		cout << array[i] << "\t";
	}
	// print a linefeed
	cout << endl;

}
// function to count frequency
int frequencyArray(int dataArray[], int valueArray[], int countArray[], int n) {

	int frequency = 0;
	int valueArray[0] = dataArray[0];
	countArray[0] = 1;

		for(int i=1; i<n; i++) {

			if (array[i] == valueArray[frequency]); 
			{
				countArray[frequency]++;
			}
			else 
			{
				countArray[frequency] = 1;
				valueArray[frequency] = dataArray[i];
			}
		} // end of for loop

	return frequency;
}

[Veltas]

Firstly, I have no idea what you're talking about. 3 parameters? My compiler doesn't give that error, and I can't see where you've done that.

Immediately I see an issue with the code, however; you're calling the frequencyArray function with the wrong parameters. The second parameter passed to it is an int, but it should be an int[]. Also, the final parameter given is an int[] but should be an int.

Perhaps arraySize should be the last parameter, not the second?

Also, on line 175 you've attempted to declare another int. Really, you should omit the word 'int' as you're actually trying to set a value, not declare a new variable.

On line 180 it seems you've referred to 'array', without declaring it. Perhaps you meant to use another name?

EDIT: And you've placed an unneccessary ';' at the end of line 180, which is messing up the if statement.

[bluecoder]

int frequencyArray(int dataArray[], int valueArray[], int countArray[], int n) {

	int frequency = 0;
	int valueArray[0] = dataArray[0];
	countArray[0] = 1;

		for(int i=1; i<n; i++) {

			if (array[i] == valueArray[frequency]); 
			{
				countArray[frequency]++;									

			}
			else 
			{
				countArray[frequency] = 1;
				valueArray[frequency] = dataArray[i];
			}
		} // end of for loop

	return frequency;
}

I see the this function is logically wrong ..
also you have not defined the function
void frequencyArray(int array[], int n);
these seems to be a problem ..
cheers
xxx

[GFreak45]

umm you have arraySize defined as 0... so it goes doesnt itterate through them at all in the showArray and bubbleSort functions...

when you are calling it n is equal to 0 still so it doesnt even do the loop at all

void bubbleSort(int array[], int n) {

	for(int i=0; i<n-1; i++) { //same as: for (int i=0; i < -1; i++)

		for(int j=i+1; j<n; j++) { //same as: for (int j=0; j < 0; i++)

			if ( array[j] < array[i]) {
				swap(array, i, j);
			}
		}
	}

	return;
}