input file fuction

I have completed the code for my program, which is to calculate the area, perimeter, and type of triangle formed from the given lengths of its sides. The sides of the triangle are to be accessed from a source file containing several rows of triples. The program complies and executes correctly (I'm assuming) but I can not seem to access the values stored in my source file, simply returning only 0's for all sides. Any ideas?

PS.

the program is returning the same results twice. What do I need to do to fix this?
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
#include <fstream>
#include <iostream>
#include <iomanip>
#include <cmath>
#include <cstdlib>

using namespace std;

bool isTriangle (double num1, double num2, double num3)
{
   double a, b, c;
   a=num1+num2;
   b=num2+num3;
   c=num1+num3;
   if (a > num3 && b > num1 && c > num2)
      return true;
   else 
      return false;
}
  
bool isRight(double sideA, double sideB, double sideC)
{
   double AA, BB, CC, AB, AC, BC;
   AA=sideA*sideA;
   BB=sideB*sideB;
   CC=sideB*sideB;
   AB=AA+BB;
   AC=AA+CC;
   BC=BB+CC;
   if (AB==CC||BC==AA||AC==BB)
      return true; 
   else
      return false;
}

bool isEquilateral (double sideA, double sideB, double sideC)
{
   if (sideA==sideB&&sideB==sideC)
      return true;
   else
      return false;
}

bool isIsosceles (double sideA, double sideB, double sideC)
{
   if (sideA==sideB||sideA==sideC||sideB==sideC)
      return true;
   else
      return false;
}

bool isScalene (double sideA, double sideB, double sideC)
{
   if (sideA!=sideB&&sideA!=sideC&&sideB!=sideC)
      return true;
   else
      return false;
}

void calcTriangle (double sideA, double sideB, double sideC, double& perimeter, double& area)
{
   perimeter=sideA+sideB+sideC;
   double S=perimeter/2;
   double SA, SB, SC;
   SA=S-sideA;
   SB=S-sideB;
   SC=S-sideC;
   area=sqrt(S*SA*SB*SC);
}

int main()
{
   fstream inFile;
   string inFileName;
   double num1, num2, num3;

   cout<<"Enter the name of the data file> ";
   cin>>inFileName;
   cout<<endl;
   inFile.open(inFileName.c_str(),ios::in);
   if (inFile.fail())
   {
      cout<<"Unable to open "<<inFileName<<endl;
      exit(1);
   }
    cout << setw(32) << right << "Triangle Program Report";
    cout << endl;
    cout << endl;
    cout << "=======================================";
    cout << endl;
    cout << endl;
   
   double N1, N2, N3;
    
   while (inFile>>N1>>N2>>N3)
   {
      inFile>>N1>>N2>>N3;
      if (isTriangle (num1, num2, num3))
      {
         cout << "The sides of the triangle are:";
       	 cout << endl;
         cout << endl;
   	  	 cout << "A = ";
       	 cout << setw(6) << setprecision(4) << fixed << num1;
       	 cout << ";  B = " << num2;
       	 cout << ";  C = " << num3;
       	 cout << endl;
       	 cout << endl;
       	 cout << endl;

       double perimeter, semiperimeter, area;
       calcTriangle (num1, num2, num3, perimeter, area);
       
       cout << "Perimeter = " << perimeter << endl;
       cout << endl;
       cout << "Area";
       cout << setw(8) << setprecision(4) << right << " = " << area;
       cout << endl;
       cout << endl;
       cout << endl;
         
       cout << "Classification:";
       cout << endl; 
       cout << endl;cout << setw(15) << left << "Right:";
       
       if (isRight(num1, num2, num3))
            cout<<"Y"<<endl;
       else
            cout<<"N"<<endl;

       cout << setw(15) << left << "Isoscoles:";
         
		 if (isIsosceles(num1, num2, num3))
            cout<<"Y"<<endl;
         else
            cout<<"N"<<endl;

       cout << setw(15) << left << "Scalene:";
         
		 if (isScalene(num1, num2, num3))
            cout<<"Y"<<endl;
         else
            cout<<"N"<<endl;

         cout << setw(15) << left << "Equilateral:";
         
         if (isEquilateral(num1, num2, num3))
            cout<<"Y"<<endl;
         else
            cout<<"N"<<endl;
      }
      else
     {
         cout << "*** ";
         cout << setprecision(4) << fixed << num1 << ", ";
         cout << num2 << ", and " << num3;
         cout << " cannot form the sides of a triangle ***";
         cout << endl;
     } 
     cout << "----------------------------------------";
     cout << endl;
     cout << endl;
     cout << endl;
   
    cout<<"***         END OF REPORT         ***";
    cout << endl;
    cout << endl;
   
}
   system("PAUSE");
     
     return EXIT_SUCCESS;
   
}


Sample source file: (triple.in)

1
2
3
7.5 4.5 6
1.0 2.0 5.0
4.1 4.1 5.3
Last edited on
your problem is in this code:
1
2
3
4

   while (inFile>>N1>>N2>>N3)
   {
      inFile>>N1>>N2>>N3;


You read from the file twice in a row instead of letting the loop do the work. like:
1
2
3
4

   while (!inFile.eof())
   {
      inFile>>N1>>N2>>N3;


You were reading from the file twice every pass of the loop. The new code should solve that problem.
Topic archived. No new replies allowed.