ProjectEuler(8) Help!

http://projecteuler.net/problem=8
Im stuck on this problem, right now im trying to read it into a file and calculate the max from there, but i get some crazy weird output on the console. Can anyone find some problems with my code?
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
#include <iostream>
#include <fstream>
#define MAX_BOUND 1000 //Array size
void InitArr(char Ar[]); //Set Char
int main()
{
    int info;
    int POSITION = 5; //Postition of sum(5 number increments)
    int SUM = 1; //Resets after every for loop
    long MAX,i;
    char Arr[MAX_BOUND];
    InitArr(Arr);
    while(POSITION < 1000)
    {
        for(i = 0; i < POSITION;i++)
        {
            int Temp = Arr[i] - '0'; //Removes Ascii coding and leaves it as an integer
            SUM = SUM * Temp; //Create sum
        }
        if(SUM > MAX) //If the sum is more than the current max, then set max to sum.
            MAX = SUM;
        SUM = 1; //Reset SUM
        POSITION += 5; //Add 5 to the position
    }
    std::cout << "THE MAX IS " << MAX;
}

void InitArr(char Ar[])
{
    std::ifstream TextObj("ArrDigits.txt");
    for(int i = 0; i < MAX_BOUND; i++)
    {
        Ar[i] = TextObj.get(); //Grab character and put it into the array
    }
    TextObj.close(); //Close file

}


ArrDigits.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
73167176531330624919225119674426574742355349194934
96983520312774506326239578318016984801869478851843
85861560789112949495459501737958331952853208805511
12540698747158523863050715693290963295227443043557
66896648950445244523161731856403098711121722383113
62229893423380308135336276614282806444486645238749
30358907296290491560440772390713810515859307960866
70172427121883998797908792274921901699720888093776
65727333001053367881220235421809751254540594752243
52584907711670556013604839586446706324415722155397
53697817977846174064955149290862569321978468622482
83972241375657056057490261407972968652414535100474
82166370484403199890008895243450658541227588666881
16427171479924442928230863465674813919123162824586
17866458359124566529476545682848912883142607690042
24219022671055626321111109370544217506941658960408
07198403850962455444362981230987879927244284909188
84580156166097919133875499200524063689912560717606
05886116467109405077541002256983155200055935729725
71636269561882670428252483600823257530420752963450


Thanks for the help!
Last edited on
Initialize MAX to 0.
1
2
3
4
5
for ( i = 0; i < POSITION; ++i )
{
     int Temp = Arr[i] - '0' ;
     SUM = SUM * Temp ;
}


This cycles through everything in the array up to POSITION. Thought you wanted to do this in sets of 5?

1
2
     SUM = 1; //Reset SUM
        POSITION += 5; //Add 5 to the position 


You don't want to do POSITION += 5. While 0-4 and 5-9 are both runs of elements you need to check, so are 1-5, 2-6, 3-7 and 4-8.

And, as Naraku noted MAX is not initialized before use.
Topic archived. No new replies allowed.