printing a vector of pointers

[Xendraw]

in my class, i wish to print a vector of objects via pointers, so that i can add certain functions later, anyway here is my class now:

class Deck
{

    private: vector<Card> cardvector; vector<Card *> pcardvector;

    public:

            Deck (vector<Card> cardvector2)
            {
                cardvector = cardvector2;

                for (int x = 0; cardvector.size(); ++x)
                {
                    pcardvector[x] = &cardvector[x];
                }
            }

            void printdeck ()
            {
                for (int x; x < 52; ++x)
                {
                    switch(cardvector[x].getvalue())
                    {
                        case 1: cout << "Ace"; break;

                        case 11: cout << "Jack"; break;

                        case 12: cout << "Queen"; break;

                        case 13: cout << "King"; break;

                        default: cout << cardvector[x].getvalue(); break;
                    }
                    cout << " of ";
                    cout << cardvector[x].getsuit() << endl;
                }
            }

as you can see the printdeck function isn't using pointers yet, i need it to print using the pointers created in the constructor, just in case, here is the class of the card:

class Card
{
    private: string suit; int value;

    public:
            Card()//default constructor (no arguments) allows you to make an
            {     //array
                value = 0;
            }

            Card(int v, string s)// allows the private attributes to be set
            {
                value = v;
                suit = s;
            }

            int getvalue()// returns the cards value
            {
                return value;
            }

            string getsuit()// returns the cards suit
            {
                return suit;
            }
};

and this is the my main (includes the function that creates the deck):

vector<Card> deck1;

void createDeck()
{
    int n,i,j;
    string b;
    j = 0;

    for(n = 0; n < 4; n++)
    {
        for(i = 1; i < 14; ++i)
        {
            switch (n)
            {
                case 0: b = "Hearts";
                break;

                case 1: b = "Spades";
                break;

                case 2: b = "Diamonds";
                break;

                case 3: b = "Clubs";
                break;
            };

            deck1.push_back(Card(i, b));

        }
    }

}


int main()
{
    createDeck();
    Deck(deck1).printdeck();
    return 0;
}

[clanmjc]

Just do this?

pcardvector[x]->getValue()  //Inside your print function 

in replace of.. in all your code

cardvector[x].getvalue()

Is this what you are asking?

[Xendraw]

yes, i thought it was that as well, however it makes my program crash

[bluecoder]

but why do you want to use pointer in the vector ?

[clanmjc]

Here is one problem.

//where is the stop condition x < cardvector.size()
for (int x = 0; cardvector.size(); ++x)
{
     pcardvector[x] = &cardvector[x]; //and this is a problem see below.
}

pcardvector contains no elements, its size is 0, trying to index into the vector is going to fail. You will need to push_back(&cardvector[x])

//x is not initialized here
for (int x; x < 52; ++x)

Once you make these changes call the pointer vector like you think it should be called.

[Xendraw]

Deck (vector<Card> cardvector2)
            {
                cardvector = cardvector2;

                for (int x = 0; x < cardvector.size(); ++x)
                {
                    pcardvector[x].push_back(&cardvector[x]);
                }
            }

something like that?

[clanmjc]

Like this.
pcardvector.push_back(&cardvector[x]);

[Xendraw]

oh, i understand that now, the same way i have done in the createdeck function, yes?

[bluecoder]

cool .. clanmjc .. good thing to know ..thanks

but how do i display the value which is in
pcardvector

i mean to say how do i display the value of cardvector which is stored in pcardvector;

thanks
xxx

[Xendraw]

that would also be useful to know, thanks for asking blue

[clanmjc]

After making the suggested changes above, replace your calls to the cardvector outputs with pcardvector[x]->getSuite().

[Xendraw]

it has warnings where the for loop arguement is, saying : trying to compare signed and unsigned variables, and the program doesnt actually output anything

[clanmjc]

Which line?

[Xendraw]

19 and 27

#include <iostream>
#include <string>
#include <cstdlib>
#include <vector>

using namespace std;

class Deck
{

    private: vector<Card> cardvector; vector<Card *> pcardvector;

    public:

            Deck (vector<Card> cardvector2)
            {
                cardvector = cardvector2;

                for (int x = 0; x < cardvector.size(); ++x)
                {
                    pcardvector.push_back(&cardvector[x]);
                }
            }

            void printdeck ()
            {
                for (int x; x < pcardvector.size(); ++x)
                {
                    switch(pcardvector[x]->getvalue())
                    {
                        case 1: cout << "Ace"; break;

                        case 11: cout << "Jack"; break;

                        case 12: cout << "Queen"; break;

                        case 13: cout << "King"; break;

                        default: cout << pcardvector[x]->getvalue(); break;
                    }
                    cout << " of ";
                    cout << pcardvector[x]->getsuit() << endl;
                }
            }

[clanmjc]

Thats because vector.size returns size_t, you can change your indices to size_t instead of int and that warning will go away.

[Xendraw]

what is size_t? i have never heard of that before

[Xendraw]

ok that compiles with no warning, but it still displays nothing upon running, just returns zero

[clanmjc]

Post all your modified code.

[Xendraw]

you are the boss:

main:

#include <iostream>
#include <string>
#include <ctime>
#include <cstdlib>
#include <vector>
#include <list>
#include "class.cpp"
#include "deck class.cpp"

using namespace std;

vector<Card> deck1;

void createDeck()
{
    int n,i,j;
    string b;
    j = 0;

    for(n = 0; n < 4; n++)
    {
        for(i = 1; i < 14; ++i)
        {
            switch (n)
            {
                case 0: b = "Hearts";
                break;

                case 1: b = "Spades";
                break;

                case 2: b = "Diamonds";
                break;

                case 3: b = "Clubs";
                break;
            };

            deck1.push_back(Card(i, b));

        }
    }

}


int main()
{
    createDeck();
    Deck(deck1).printdeck();
    return 0;
}

deck class:

#include <iostream>
#include <string>
#include <cstdlib>
#include <vector>

using namespace std;

class Deck
{

    private: vector<Card> cardvector; vector<Card *> pcardvector;

    public:

            Deck (vector<Card> cardvector2)
            {
                cardvector = cardvector2;

                for (size_t x = 0; x < cardvector.size(); ++x)
                {
                    pcardvector.push_back(&cardvector[x]);
                }
            }

            void printdeck ()
            {
                for (size_t x; x < pcardvector.size(); ++x)
                {
                    switch(pcardvector[x]->getvalue())
                    {
                        case 1: cout << "Ace"; break;

                        case 11: cout << "Jack"; break;

                        case 12: cout << "Queen"; break;

                        case 13: cout << "King"; break;

                        default: cout << pcardvector[x]->getvalue(); break;
                    }
                    cout << " of ";
                    cout << pcardvector[x]->getsuit() << endl;
                }
            }

            void nextcard ()
            {

            }

            void shufflecards ()
            {

            }
};

card class:

#include <iostream>
#include <string>

 using namespace std;

 class Card
{
    private: string suit; int value;

    public:
            Card()//default constructor (no arguments) allows you to make an
            {     //array
                value = 0;
            }

            Card(int v, string s)// allows the private attributes to be set
            {
                value = v;
                suit = s;
            }

            int getvalue()// returns the cards value
            {
                return value;
            }

            string getsuit()// returns the cards suit
            {
                return suit;
            }
};

[clanmjc]

Do you see the problem here?
for (size_t x; x < pcardvector.size(); ++x)