Vector class, Iterator and Inheritance

[mahinkhan22]

I have made two classes of Canvas one makes use of Vectors and other uses and array.

The problem is in class that uses vectors and the problem is that toString method of Rectangle class is not being invoked

how can I do that.

Rephrasing

I want to use vector to invoke method toString of Rectangle class

class Shapes
{
    protected:
        string name;
        string type;
        string color;
        Border outline;
    public:
        //constructors
        Shapes()
        {
            name = "*";
            type = "*";
            color = "*";
        }
        Shapes(string n, string t, string c,string bC,int bW)
        {
            outline.setBorder(bC,bW);
            setName(n);
            setType(t);
            setColor(c);
        }
        //setters
        void setShape(string n, string t, string c,string bC,int bW)
        {
            setName(n);
            setType(t);
            setColor(c);
            outline.setBorder(bC,bW);
        }
        void setName(string n)
        {
            name = n;
        }
        void setType(string t)
        {
            type = t;
        }
        void setColor(string c)
        {
            color = c;
        }
        //getters
        string getName()
        {
            return name;
        }
        string getType()
        {
            return type;
        }
        string  getColor()
        {
            return color;
        }
        virtual string toString()
        {
            string s;
            ostringstream oss;
            oss <<"Name         :"<<getName()<<endl;
            oss <<"Type         :"<<getType()<<endl;
            oss <<"Border Color :"<<outline.getBorderColor()<<endl;
            oss <<"Border Width :"<<outline.getBorderWidth()<<endl;
            oss <<"Shape Color  :"<<getColor()<<endl;
            s = oss.str();
            return s;
        }
};
class Rectangle : public Shapes
{
    protected:
        int length;
        int width;
    public:
        //constructors
        Rectangle()
        {
            length =0;
            width =0;
        }
        Rectangle(string n, string t, string c,string bC,int bW,int l, int w)
            :Shapes(n,t,c,bC,bW)
        {
            setLength(l);
            setWidth(w);
        }
        //setters
        void setRectangle(string n, string t, string c,string bC,int bW,int l, int w)
        {
            Shapes::setShape(n,t,c,bC,bW);
            setLength(l);
            setWidth(w);
        }
        void setLength(int l)
        {
            length = l;
        }
        void setWidth(int w)
        {
            width = w;
        }
        //getters
        int getLength()
        {
            return length;
        }
        int getWidth()
        {
            return width;
        }
        //method to toString
        string toString()
        {
            string s;
            ostringstream oss;
            oss <<"Rectangle";
            oss <<"\tlength"<<length;
            oss <<"\twidth"<<width;
            s = oss.str();
            return s;

        }

};

class Canvas
{
    private:
        vector<Shapes> listOfshapes;
    public:
        //constructor
        Canvas()
        {
        }
        //method to add a shape
        void addShape(Shapes shap)
        {
            listOfshapes.push_back(shap);
        }
        void display()
        {
            for(vector<Shapes>::iterator iter =listOfshapes.begin()
                ;iter != listOfshapes.end();iter++)
            {
                cout << iter->toString()<<endl;
            }
        }
};
/*class Canvas
{
      private:

             Shapes *s[100];
             int count;

      public:
             Canvas()
             {
				 count = 0;
			 }
             void addShape(Shapes *f)
             {
				 s[count] = f;
				 count+=1;
			 }
			 void display()
			 {
				 int j=0;
				 while(j<count)
				 {
					 cout << endl << s[j]->toString();
					 j+=1;
				 }
			 }

};*/
int main()
{
    Rectangle r1("my Rectangle","teet","blue","freen",3,4,5);
    Canvas c;
    c.addShape(r1);  //use this when canvas is made of vector
    //c.addShape(&r1); //use this when canvas is made of array
    c.display();
    return 0;
}

[Athar]

You need a vector of pointers to Shape.

[mahinkhan22]

is this the way ??
this is also not working

class Canvas
{
    private:
        vector<Shapes> *listOfshapes;
    public:
        //constructor
        Canvas()
        {
        }
        //method to add a shape
        void addShape(Shapes *shap)
        {
            listOfshapes->push_back(*shap);
        }
        void display()
        {
            for(vector<Shapes>::iterator iter =listOfshapes->begin()
                ;iter != listOfshapes->end();iter++)
            {
                cout << iter->toString()<<endl;
            }
        }
};

[Athar]

No, that declares a pointer to a vector of shapes.
This way:
vector<Shapes*> listOfshapes;

[mahinkhan22]

Alaa :)
Thanks You were super help.

here is the class, it works fine. But is it fine logically?

class Canvas
{
    private:
        vector<Shapes*> listOfshapes;
    public:
        //constructor
        Canvas()
        {
        }
        //method to add a shape
        void addShape(Shapes *shap)
        {
            listOfshapes.push_back(shap);
        }
        void display()
        {
            for(vector<Shapes*>::iterator iter =listOfshapes.begin()
                ;iter != listOfshapes.end();iter++)
            {
                //cout<< listOfshapes[0]->toString();
                cout << (*iter)->toString()<<endl;
            }
        }
};

[Athar]

Well, the main problem I see is memory management. You aren't deleting the pointers in the vector anywhere.
Which is good, because in your example the only element in it wasn't created by new, so that wouldn't be valid.
However, you'll likely want be able to store shapes allocated by new.