What's wrong with this!!!

[hassaanid2011]

Hello!!!
Finally, after lot of work i write my program but my program crashes...Here's the code of my program:

//User.h
class User
{
      protected:
      int ID;
      char *Name;
      char *Address;
      char *Status;
      
      public:
      User(){};
      User(int id,char *name,char *address,char *status){
      if(id<0)
      {
           ID=0;
           }
           else
           {
               ID=id;
               }
      if(strlen(name)>0)
      {
           Name=new char[strlen(name)+1];
           strcpy(Name,name);
           }
           else
           {
               Name=NULL;
               }
      if(strlen(address)>0)
      {
           Address=new char[strlen(address)+1];
           strcpy(Address,address);
           }
           else
           {
               Address=NULL;
               }
      if(strlen(status)>0)
      {
           Status=new char[strlen(status)+1];
           strcpy(Status,status);
           }
           else
           {
               Status=NULL;
               }
      }
      ~User(){
      }
      void setID()
      {
           cout<<"Enter ID: ";
           cin>>ID;
           }
      void setName()
      {
           cout<<"Enter Name: ";
           cin>>Name;
           }
      void setAddress()
      {
           cout<<"Enter Address: ";
           cin>>Address;
           }
      void setStatus()
      {
           cout<<"Set Status: ";
           cin>>Status;
           }
      int getID()
      {
           return ID;
           }
      char *getName()
      {
           return Name;
           }
      char *getAddress()
      {
           return Address;
           }
      char *getStatus()
      {
           return Status;
           }
};
//Members.h
class Members: public User
{
      char *Password;
      
      public:
      Members(){};
      Members(char *password){
      if(strlen(password)>0)
      {
           Password=new char[strlen(password)+1];
           strcpy(Password,password);
           }
           else
           {
               Password=NULL;
               }
      }
      ~Members(){
      }
      void setPassword()
      {
           cout<<"Enter Password: ";
           cin>>Password;
      }
      char *getPassword()
      {
           return Password;
           }
      void AddMember()
      {
           cout<<"Adding new member information! Please wait....\n"<<endl;
           setID();
           setName();
           setAddress();
           setStatus();
           setPassword();
           cout<<"New member information successfully added....\n"<<endl;
           }
};
#include "User.h"
#include "Members.h"
int main()
{
    Members obj1;
    obj1.AddMember();
    system ("PAUSE");
    getch();
}

This program successfully compiles but after (Set Status prompt) this program crashes. What the hell is wrong with this code? Any kind of help to fix this problem is appreciated.....Thanks!!!

[Ivan Sidarau]

Do you forget about memory allocation for status variable?

It is a much better to use std::string instead of char* for Name, Address, Status.

[hassaanid2011]

No memory is allocated for status variable you can see in this code but after (Set Status prompt not on Set Status) when try to ask for (Enter Password) in derived class.

[hassaanid2011]

Please someone help me on this problem......... :(

[ne555]

You are using the default constructor, that do nothing.

[hassaanid2011]

Can u set the default values of variables in default constructor.......Or can you fix this?

[hassaanid2011]

Anybody here who can fix this code???? :(

[Galik]

Try using std::string rather than char*:
http://cplusplus.com/reference/string/string/

[hassaanid2011]

I want you guys to fix that piece of code because i don't know anything about C++ strings.....I don't know how to use them.....Please see the code above and try to fix this code with your knowledge......Thanks!!!

[ciphermagi]

Dear hassaanid2011,

I would like to respectfully suggest that you moderate your requests, and make some attempt at researching the solutions that were so kindly given to you. To further this endeavor, I shall compile them here, as follows:

Research std::string at http://cplusplus.com/reference/string/string
Refrain from using char*

In addition, I would like to suggest, very respectfully, that you look at this post, as it may assist you in learning how to successfully request assistance in an internet forum:

http://www.cplusplus.com/forum/beginner/1/#msg6680

Last, I would like you to consider doing one of the following two things: RTFM or choose another career.

Very Respectfully,
ciphermagi