Inheritance Problem!!!

[hassaanid2011]

Hello Guys!!!
I am trying to create the two classes (Base Class & Derived Class) but my AddMember() function is creating problem for me.....I Think :D Here's the code:

class User
{
      protected:
      int ID;
      char *Name;
      public:
      User(){};
      User(int,char *){
      int *ID=new int[7];
      char *Name=new char[15];
      }
      void setID()
      {
           cout<<"Enter ID: ";
           cin>>ID;
           int *ID=new int[7];
           }
      void setName()
      {
           cout<<"Enter Name: ";
           cin>>Name;
           char *Name=new char[15];
           }
      int getID()
      {
           return ID;
           }
      char *getName()
      {
           return Name;
           }
      ~User(){
      }
};
class Members: public User
{
      char *Password;
      
      public:
      Members(){};
      Members(int,char *,char *){
      char *Password=new char[8];
      }
      void setPassword()
      {
           cout<<"Enter Password: ";
           cin>>Password;
           char *Password=new char[8];
      }
      char *getPassword()
      {
           return Password;
           }
      void AddMember()
      {
           cout<<"Adding new member information! Please wait...."<<endl;
           setID();
           setName();
           setPassword(); //Program crashes on this step
           }
      ~Members(){
      }
};
int main()
{
    Members obj1;
    obj1.AddMember();
    system ("PAUSE");
    getch();
}

This Program compiles with no errors but when AddMember() function try to ask for Password (line 59) the program crashes. I don't know why this happened everything compiled successfully but now hell program crashes. Anybody can detect the problem? Thanks!!!

[hanst99]

void setName()
      {
           cout<<"Enter Name: ";
           cin>>Name;
           char *Name=new char[15];
           }

No comment. PS: There is little point to a set method if the method does the work of a retrieving a value itself (same for the rest of the class). Also, c strings are evil. (so are system and C arrays in general, but w/e).

A set method should just take a value and set a member. Maybe check that value for correctness, but other than that that's it.

[eypros]

In line 37 you declare a variable:
char *Password;

You declare and initialize the same variable (Password) at the same time at line 42:
(line 42) char *Password=new char[8];
I think that shouldn't even compile. Surely it's wrong. Use constructor to initialize your variables. Only for const variables you can initialize when declared.

You have done the same with your base class declaration.

Also in line 48 you declare a new varibale with same name (local one that is). Is this what you wnated to do?
char *Password=new char[8];

Take into mind that line 47 stores the value entered to the some of the other variables. Not the local one. Not that it matters.

Each time you allocate a variable to the stack (with new) you MUST deallocate it using delete at some point (normally destructor). Otherwise there are memory leaks. That simple

[KMat]

Hai,

I have to tried to execute the above code in my Solaris 10 system.
I didn't receive any prompt for typing password, but i could able to provide ID and Name as cin.

hassaanid2011, do you have the same problem or your executable is crashing at the time of run?
if yes, what is the core file says?

BR/ KMat

[hassaanid2011]

@KMat My program crashes after Name prompt(when trying to ask for password)....I am using windows 7 and debug and close program windows opened....Any idea what cause this?

[ne555]

           cout<<"Enter Name: ";
           cin>>Name;

'Name' is pointing to garbage. The same occurs with 'Password'.

[hassaanid2011]

@ne555 Thanks for pointing out but can you tell me how to fix this problem and allocate memory for them?