please help me with my program.

[Cosimo Vilardo]

My program seems to always print out "temperature is valid" for every set of data. It would be appreciated if someone could get me over this hump as I need to hand in this program by today.

#include<iostream>
#include <fstream>
using namespace std;
ifstream infile("in1.dat");
ofstream outfile("out1.txt");
int validtemperature(int,int,int);
int classify(int,int,int);
double findavg(int,int,int);
double whatseason(double);
int main()
{
    
    int num1, num2, num3, result, count_valid=0, count_invalid=0;
    int totalgroups=0;
    bool valid;
    
    if(!infile)
    {
         cout << "unable to open file for reading";
    }    
    
    
    
    infile >> num1 >> num2 >> num3;
    while (infile) {
    
    cout<<num1<<" "<<num2<<" "<<num3<<endl;
    valid=validtemperature(num1,num2,num3);
    if (valid==true){
         cout<<"The set of temperatures is valid"<<endl;
         count_valid++;
         classify(num1,num2,num3);
         infile >> num1 >> num2 >> num3;
    }
    else if(valid==false){
              cout<<"The set of temperatures is invalid"<<endl;
              count_invalid++;
              infile >> num1 >> num2 >> num3;
              }
    totalgroups++;          
    }
    
    
infile.close();
outfile.close();    
system ("pause");
return 0;
}


//Check to see if temperature>=-10 and <=105
int validtemperature(int x,int y,int z){


    if(x>=-10&&x<=105){
         x==true;
    }
    else if(!(x>=-10&&x<=105)){
         x==false;
    }
       
    if (y>=-10&&y<=105){
         y==true;
    }
    else if(!(y>=-10&&y<=105)){ 
         y==false;
    }
    
    if (z>=-10&&z<=105){
         z==true;
    }     
    else if(!(z>=-10&&z<=105)){ 
         z==false;
    }     
    
    if ((x&&y&&z)==1){
         return true;
    }
    else if((x||y||z)==0){
         return false;
    }
}
//calls find average and then calls whatseason with average
int classify(int x,int y,int z){
    
    double average;
    
    average=findavg(x,y,z);
    whatseason(average);
    
}

//finds average of the 3 intergers from data file
double findavg(int x,int y,int z){
    
    int sum;
    double avg;
    
    sum=x+y+z;
    avg=sum/3;
    
    return avg;
}

//tells you what season it is according to the temperature
double whatseason(double x){
       cout<<"The average is "<<(double)x<<endl;
       
       if(x>=100)
            cout<<"It is roasting season"<<endl;
       else if(x>=80&&x<100)
                 cout<<"It is summer"<<endl;
       else if(x>=60&&x<80)
                 cout<<"It is spring"<<endl;
       else if(x>=40&&x<60)
                 cout<<"It is fall"<<endl;
       else if(x>=0&&x<40)
                 cout<<"It is winter"<<endl;
       else if(x<0)
                 cout<<"It is freezin' season"<<endl;
return 0;
}

here is my output

12 15 18
The set of temperatures is valid
The average is 15
It is winter
23 27 25
The set of temperatures is valid
The average is 25
It is winter
56 59 63
The set of temperatures is valid
The average is 59
It is fall
44 49 44
The set of temperatures is valid
The average is 45
It is fall
-12 1 -9
The set of temperatures is valid
The average is -6
It is freezin' season
100 110 102
The set of temperatures is valid
The average is 104
It is roasting season
105 103 102
The set of temperatures is valid
The average is 103
It is roasting season
99 95 91
The set of temperatures is valid
The average is 95
It is summer
67 75 80
The set of temperatures is valid
The average is 74
It is spring
72 77 69
The set of temperatures is valid
The average is 72
It is spring
34 40 41
The set of temperatures is valid
The average is 38
It is winter
-15 -17 -8
The set of temperatures is valid
The average is -13
It is freezin' season
106 107 100
The set of temperatures is valid
The average is 104
It is roasting season
22 25 19
The set of temperatures is valid
The average is 22
It is winter
96 93 97
The set of temperatures is valid
The average is 95
It is summer
77 79 83
The set of temperatures is valid
The average is 79
It is spring
50 47 51
The set of temperatures is valid
The average is 49
It is fall
-10 -1 0
The set of temperatures is valid
The average is -3
It is freezin' season
106 108 109
The set of temperatures is valid
The average is 107
It is roasting season
-11 -15 -19
The set of temperatures is valid
The average is -15
It is freezin' season
29 34 37
The set of temperatures is valid
The average is 33
It is winter
71 65 69
The set of temperatures is valid
The average is 68
It is spring
101 102 99
The set of temperatures is valid
The average is 100
It is roasting season
45 55 65
The set of temperatures is valid
The average is 55
It is fall
37 37 37
The set of temperatures is valid
The average is 37
It is winter
Press any key to continue . . .

I have about 6 sets of the numbers that should print out "temperature is invalid"

[helios]

Your validtemperature() seems like a really odd way of writing this:

inline bool valid(int x){
    return x>=-10 && x<=105;
}
int validtemperature(int x,int y,int z){
    return valid(x) && valid(y) && valid(z);
}

The condition at the end of your version ((x||y||z)==0)) probably doesn't do what you were expecting. It doesn't mean "if any of x or y or z equals zero"; it means "if ((x is not zero) or (y is not zero) or (z is not zero)) equals zero". The condition correctly written could have been x==0 || y==0 || z==0 or, since comparisons to zero can be done implicitly, !x || !y || !z. But see below.

You keep doing this:

if (p){
    //do something
}else if (!p){
    //do something else
}

If p is not true, then the only possibility is that it's false. You don't need to keep testing the same conditions over and over again:

if (p){
    //do something
}else{
    //do something else
}

[Cosimo Vilardo]

Thanks for the help but i seem to still get the same output. It's really bugging me.

[helios]

Can you post your code as it is now?

Also, don't start parallel threads for the same problem.