Code not compiling properly

[heatedcrows]

hi guys, i am supposed to write a blackjack program for school, and below is what i have so far. The program is not complete yet, but when i try compiling it (with many different kinds of compilers, the code just doesnt compile (I dont have any specific errors). When i try and compile it on dev c++, it seems to compile, but when i try and run it, it just crashes.
Any help to find out what i am doing wrong would be great.

#include <iostream>
#include <fstream> 
#include <iostream.h>
#include <string.h>

using namespace std;

/* *********************************************************************************************************** */
void instructions (void);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int startgame (int money, bool deck[4][13]);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int bet_taker (int money);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int card_pick (int &i, int &j, bool deck [4][13]);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int player_calculator (int player_cards [10]);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int dealer_calculator (int dealer_cards [10]);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
void card_displayer (int i, int j, int turn);
/* *********************************************************************************************************** */

/* *********************************************************************************************************** */
int turn_changer (int &turn);
/* *********************************************************************************************************** */

int main ()
{
	int main_choice;
	bool deck [4][13];
    /* this is a bool becuase if it is true, the card can be used,
     if it is false, the card has already been used*/
	int money = 0;
	
	for (int i = 0; i < 4; i = i + 1)
    {
        for (int j = 0; i < 13; j = j + 1)
        {
            deck [i][j] = true;
        }
    }
	
	cout << "Welcome to the blackjack program" << endl;
	cout << "If you would like to view the instructions, press 1" << endl;
	cout << "If you would like to start the game, press 2" << endl;
	cout << "If you would like to quit the game, press 3" << endl;
	cout << "Please enter your choice now: ";
	
	cin >> main_choice;
	
	while ((main_choice > 3) || (main_choice < 1))
	{
		cout << "That is not a valid choice, make a valid choice now";
		cin >> main_choice;
    }
	
	if(main_choice == 1)
	{
        cout << "You have chosen to read the instructions: " << endl;
        instructions ();  
	}
	
	if (main_choice == 2)
	{
        //call the game starting function
        cout << "You have chosen to start the game" << endl;
        money = startgame (money,deck);
	}
	
	if (main_choice == 3)
	{
		cout << "Thank you for playing the game of blackjack" << endl;
		system ("pause");
		exit (0);
	}
}

void instructions (void)
{
     //add instructions here
}

int startgame (int money, bool deck[4][13])
{
     int game_option;
     int bet;
     int i;
     int j;
     int person_count = 0;
     int dealer_count = 0;
     int player_cards [10];
     int dealer_cards [10];
     int turn = 0;
     int player_card_number = 0;
     int dealer_card_number = 0;
     
     for (int clear = 0; clear < 10; clear = clear + 1)
     {
         player_cards [clear] = 0;
         dealer_cards [clear] = 0;
     }
     
     if (money == 0)
     {
               
           cout << "You have been awarded 500 dollars, because you had none before" << endl;
           money = 500;
     }
     
     cout << "If you would like to be dealt a hand, press 1" << endl;
     cout << "If you would like to see how much money you have, press 2" << endl;
     cout << "If you would like to exit to the main menu, press 3" << endl;
     
     cout << "Make your choice now: ";
     cin >> game_option;
     
     while ((game_option > 3) || (game_option < 1))
     {
           cout << "That is not a valid choice, make a valid choice now: ";
           cin >> game_option;
     }
     
     if (game_option == 1)
     {
           bet = bet_taker (money);
           money = money - bet;
           card_pick (i,j,deck);
           card_displayer (i,j,turn);
           turn_changer (turn);
     }
     
     if (game_option == 2)
     {
           cout << "The amount of money you have is " << money << "dollars" << endl;
           system ("pause");
     }
     
     if (game_option == 3)
     {
           cout << "Thank you for playing the game of blackjack" << endl;
           return money;
     }
     
}

int bet_taker (int money)
{
    int bet;
    cout << "How much money would you like to bet? ";
    cin >> bet;
           
    while ((bet > money) || (bet < 1))
    {
          cout << "That is an invalid bet! " << endl;
          cout << "Please enter a bet that is greater than zero, and within the amount of money you have!" << endl;
          cout << "Enter a valid bet here: ";
          cin >> bet;
    }
}

int card_pick (int &i, int & j, bool deck [4][13])
{
    do{
    //insert code for picking a random card here (with i amd j)
    }while (deck [i][j] == false);
    deck [i][j] == false;
}

int player_calculator (int player_cards [10])
{
    //calculate the value of player cards here
}

int dealer_calculator (int dealer_cards [10])
{
    //calculate the value of dealer cards here
}

void card_displayer (int i, int j, int turn)
{
     string who_turn;
     string suit;
     string face_cards;
     
     if (i == 0)
     {
           suit = "diamond";
     }
     
     if (i == 1)
     {
           suit = "clubs";
     }
     
     if (i == 2)
     {
           suit == "hearts";     
     }
     
     if (i == 3)
     {
           suit == "spades";
     }
     
     if (turn == 0)
     {
           who_turn = "dealer";
     }
     
     if (turn == 1)
     {
           who_turn = "player";
     }
     
     if (j == 0)
     {
           face_cards = "ace";
     }
     
     if (j == 10)
     {
           face_cards = "jack";
     }
     
     if (j == 11)
     {
           face_cards = "queen";
     }
     
     if (j == 12)
     {
           face_cards = "king";
     }
     
     if ((j > 0) && (j < 10))
     {
            cout << who_turn << "got a " << i << "of " << suit << endl;
     }
     
     else cout << who_turn << "got a(n) " << face_cards << "of " << suit << endl;
}

int turn_changer (int &turn)
{
    if (turn == 0)
    {
             turn = 1;
    }
    
    else turn = 0;
    
    return turn;
}

Thanks in advance,

heatedcrows

[Mathhead200]

Did the compiler give you anything, any messages or line numbers that might help?

[heatedcrows]

When i compiled in dev c++, i got no errors other than an antiquated header. Then, when i tried running it (which i tried multiple times) the program would crash immediately.

[hanst99]

If it DOES compile, then you don't have compilation problems. First of all, get a real IDE, not Dev-C++. Eclipse CDT, Code::Blocks, Visual C++ -anything really.

Then - when a program crashes, it's most likely a segmentation fault. *Probably* you are accessing an invalid index of your deck array somewhere.

That being said, there are some serious problems with your code. <iostream.h> is deprecated, and even worse you include it together with <iostream>. You should never do that. Next, you should include <string>, not <string.h>.

Your main function does not always return a value. Same with startgame, bet_taker, card_pick (which also has a comparison in the middle of nowhere), player_calculator and dealer_calculator. Other than that, your logic is all over the place and rather hard to follow.
You also have some oddities like turn_changer manipulating AND returning turn, unnecessary system calls... it's overall a royal mess.

[heatedcrows]

thanks for the feedback, i scrapped this, and made the program with completely different code.