Why am i getting this output?

[cdd]

Im trying to write a program that outputs the next permutation of a numerical string in lexcographic order. My issue is why my program is outputing in a wierd format. For some reason on the print of the final string, if it was run through the Reverse_Tail function, which reverse the order of the tail digits, the output would be as seen below:


Normal:

2 1 3 4

Weird:

2
1 3 4

Note: all of the funtions work like they were ment to, its just that the output is weird.

Here is the Reverse_Tail function:

void Reverse_Tail(vector<char>& List,int k){
  
  int i = k+1;
  
  int lim = (List.size() - i)/2;
  
  int len = List.size()-1;

  while(i < List.size() - lim){
    
    List = Swap(List,i,len);
    len--;
    i++;

}

}

and here is the whole program:

#include<iostream>
#include<vector>

using namespace std;

void Reverse_Tail(vector<char>& List,int k);
vector<char> Swap(vector<char> InputList,int k, int l);
vector<char> GetInput();
int Find_K(vector<char> List);
int Find_l(vector<char> List,int k);

int main(){
  
  vector<char> Test2,Test = GetInput();
  
  int K = Find_K(Test);
  int l = Find_l(Test,K);
 
  for(int i=0;i<Test.size();i++){
  
     cout << Test[i] << " " ;
      
}
  
 cout << endl << "K = " << K << endl<< "l = " << l << endl<< endl;
  
  Test2 = Swap(Test,K,l);
  //Ran the next for loop spit vector before the Reverse_Tail function and it does display normally
     for(int i=0;i<Test2.size();i++){
  
     cout << Test2[i] << "  " ;
      
}
  cout << endl<< endl;
  
  Reverse_Tail(Test2,K);
  // now when i run the same loop again it displays incorrectly

    for(int i=0;i<Test2.size();i++){
  
     cout << Test2[i] << "  " ;
      
}
  cout << endl<< endl;
  return 0;
}

void Reverse_Tail(vector<char>& List,int k){
  
  int i = k+1;
  
  int lim = (List.size() - i)/2;
  
  int len = List.size()-1;

  while(i < List.size() - lim){
    
    List = Swap(List,i,len);
    len--;
    i++;

}

}

vector<char> Swap(vector<char> InputList,int k, int l){
  
  vector<char> OutList = InputList;
  
  int Temp = OutList[l];
  
  OutList[l] = InputList[k];
  
  OutList[k] = Temp;
  
  return OutList;
  
}

int Find_l(vector<char> List,int k){
  
  int l=List.size()-1;
  
  while(List[l] < List[k]){
    
    l--;
    
  }
  
  return l;
  
}


//Remeber k is an index
int Find_K(vector<char> List){
  
  int k = List.size()-2;
  
  while(List[k] > List[k+1]){
    
    k--;
    
  }
  
  if(k == List.size()-1){
    
    return -1;
    
  }
  
  return k;
  
}

vector<char> GetInput(){

vector<char> InputString;
 
cout << "Please input the string of symbols you would like to gain all permutations of: ";

char temp = 0 ;

while( temp != '\n' ){

cin.get(temp);

InputString.push_back(temp);

}

return  InputString;

}

[helios]

while( temp != '\n' ){

cin.get(temp);

InputString.push_back(temp);

}

Like this, exactly one newline will get into the string.

[cdd]

ok i see thanks alot!

[cdd]

ok new problem, i modified it so the program computes all of the permutations but i am getting a memory error:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Aborted

here is the current program:

#include<iostream>
#include<vector>

using namespace std;

vector<char> Next_Permutation(vector<char> InList);
void Reverse_Tail(vector<char>& List,int k);
vector<char> Swap(vector<char> InputList,int k, int l);
vector<char> GetInput();
int Find_K(vector<char> List);
int Find_l(vector<char> List,int k);
int Factorial(int n);

int main(){
 
 vector<char> Input = GetInput();//Getting initial input use 1234 for test
  
 int limit = Factorial(Input.size()); // finds how many permutations will be made
 
 vector<char>* AllPerms = new vector<char>[limit]; //AllPerms is the collection of all permutations(it is an array of vectors where each vector is a permutation)
 
 AllPerms[0] = Input; //setting intial permutation;
 
 for(int i=1;i<2;i++){
  
   
   // here is where i believe the program crashes. I've tried      test = Next_Permutation(AllPerms[i-1])       then 
   // doing        AllPerms[i] = Test          and the program runs through the first line fine but crashed on AllPerms[i] = Test?
   
  AllPerms[i] = (Next_Permutation(AllPerms[i-1]));
   
}
 for(int j=0; j < limit;j++){
   
  for(int i=0;i<AllPerms[j].size();i++){
  
     cout << AllPerms[j][i] << " " ;
      
}

cout << endl;

 }
 //cout << endl << "K = " << K << endl<< "l = " << l << endl<< endl;
  

  cout << endl<< endl;
  return 0;
}

int Factorial(int n){
  
  if(n==0)
    return 1;
  else
    return n*Factorial(n-1);
  
}

vector<char> Next_Permutation(vector<char> InList){
  
  int K = Find_K(InList);
  int l = Find_l(InList,K);
  
  vector<char> Output = Swap(InList,K,l);
  
  Reverse_Tail(Output,K);
  
}

void Reverse_Tail(vector<char>& List,int k){
  
  int i = k+1;
  
  int lim = (List.size() - i)/2;
  
  int len = List.size()-1;

  while(i < (List.size() - lim -1)){
    
    List = Swap(List,i,len);
    len--;
    i++;

}

}

vector<char> Swap(vector<char> InputList,int k, int l){
  
  vector<char> OutList = InputList;
  
  int Temp = OutList[l];
  
  OutList[l] = InputList[k];
  
  OutList[k] = Temp;
  
  return OutList;
  
}

int Find_l(vector<char> List,int k){
  
  int l=List.size()-1;
  
  while(List[l] < List[k]){
    
    l--;
    
  }
  
  return l;
  
}

int Find_K(vector<char> List){
  
  int k = List.size()-2;
  
  while(List[k] > List[k+1]){
    
    k--;
    
  }
  
  if(k == List.size()-1){
    
    return -1;
    
  }
  
  return k;
  
}

vector<char> GetInput(){

vector<char> InputString;
 
cout << "Please input the string of symbols you would like to gain all permutations of: ";

char temp = 0 ;

while( temp != '\n' ){

cin.get(temp);

InputString.push_back(temp);

}

InputString.pop_back();

return  InputString;

}