- Forum
- General C++ Programming
- String and loop problem
String and loop problem
Hi, I am somewhat a beginner at C++ and i have been making a text adventure game lately. I put in a fun little easter egg when you type in your name as a swear word, but I have been having problems with it. Here's the code:
/* I included these libraies:
#include<iostream>
#include<string>
#include<cmath>
#include<fstream>
#include<cstdlib>
#include<stdio.h>
#include<conio.h>*/
//I have declared all necessary variables.
cin >> name;
if (name == "fuck" || "ass" || "shit" || "damn"){
do{
cout << "One more time?" << endl;
cin >> name;
}while(name == "fuck" || "ass" || "shit" || "damn");
}
//the rest of the game is here
if you need any other info on the code let me know and ill give it to you!
@shacktar thanks! it worked! :D
/* I included these libraies:
#include<iostream>
#include<string>
#include<cmath>
#include<fstream>
#include<cstdlib>
#include<stdio.h>
#include<conio.h>*/
//I have declared all necessary variables.
cin >> name;
if (name == "fuck" || "ass" || "shit" || "damn"){
do{
cout << "One more time?" << endl;
cin >> name;
}while(name == "fuck" || "ass" || "shit" || "damn");
}
//the rest of the game is here
if you need any other info on the code let me know and ill give it to you!
@shacktar thanks! it worked! :D
Last edited on
Wow, this forum doesn't have a swear filter...
Anyway, this:
is invalid. In both your cases (in the if statement and the while condition), it should be:
Anyway, this:
(name == "fridge" || "donkey" || "excrement" || "darn")is invalid. In both your cases (in the if statement and the while condition), it should be:
((name == "fridge") || (name == "donkey") || (name == "excrement") || (name == "darn"))
Last edited on
As a general rule, if you find yourself copy/pasting things, you are probably doing something wrong. Duplicate code is bad.
In this case:
Could be trimmed to this, which is exactly the same, functionally:
Notice how we only have one condition, instead of having to duplicate it.
Furthermore, the || operator doesn't work like you seem to think. It evaluates expressions on each side of it. If either side of the || operator is nonzero, then || gives you nonzero (true).
example:
The expressions here are
Notice that "ass" is nonzero. Therefore this will always result in 'true', and the if block will always execute.
What you probably wanted is something like this:
In this case:
|
|
Could be trimmed to this, which is exactly the same, functionally:
|
|
Notice how we only have one condition, instead of having to duplicate it.
Furthermore, the || operator doesn't work like you seem to think. It evaluates expressions on each side of it. If either side of the || operator is nonzero, then || gives you nonzero (true).
example:
|
|
The expressions here are
name == "fuck" and "ass"Notice that "ass" is nonzero. Therefore this will always result in 'true', and the if block will always execute.
What you probably wanted is something like this:
|
|
Topic archived. No new replies allowed.