Index

[BaconFred]

Hello!

I just need some help with showing me why I sometimes get the same card over again. When I have declared them and also done a if statement if the variable had been used before.

So what's the problem.
- I want a unique card to only show once, only one red king, only one red ten and so on.

Here is the code:

#include <iostream>
using namespace std;

       class BlackJack{
       public:
       bool hjarter[13];
       bool spader[13];
       bool ruter[13];
       bool klover[13];
       string tempF, tempK;
       int farg, summa, svar2;
       
           BlackJack(){

	        for ( int i = 0; i < 13; i++ ){

		    hjarter[i] = false;
            spader[i] = false;
            ruter[i] = false;
            klover[i] = false;

            }
            
            summa = 0;
            
            }
            
            void nyttKort(){

	        // slumpa fram färg
	       
           farg = rand()%3;
           int varde;
                     
               do{      
                     
	           if(farg == 0){ // 1
                
                   tempF = "hjärter";
                         
	               varde = rand()%13;
	
               if ( hjarter[varde] == false ){ // 2

		       if ( varde <= 8 ) {
                    
                    cout << tempF << " " << varde + 2;         
                    summa = summa + varde + 2;                                                             
			     
               }  
               
               else if ( varde == 9  ){
                    
                    cout << tempF << " knekt";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 10 ){
                    
                    cout << tempF << " dam";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 11 ){
                    
                    cout << tempF << " kung";
                    summa = summa + 10;
                    
               }
               
               else    
               
               ;
               
               } // End 2
               
               } // End 1
               
               }while ( hjarter[varde] == true );
               
               hjarter[varde] == true;
               
               ///////////////////////////////////////// NY FÄRG
               
                              do{      
                     
	           if(farg == 1){ // 1
                
                   tempF = "spader";
                         
	               varde = rand()%13;
	
               if ( spader[varde] == false ){ // 2

		       if ( varde <= 8 ) {
                    
                    cout << tempF << " " << varde + 2;         
                    summa = summa + varde + 2;                                                             
			     
               }  
               
               else if ( varde == 9  ){
                    
                    cout << tempF << " knekt";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 10 ){
                    
                    cout << tempF << " dam";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 11 ){
                    
                    cout << tempF << " kung";
                    summa = summa + 10;
                    
               }
               
               else
               
               ;
               
               } // End 2
               
               } // End 1
               
               }while ( spader[varde] == true );
               
               spader[varde] == true;
               
               ///////////////////////////////////////// NY FÄRG
               
                              do{      
                     
	           if(farg == 2){ // 1
                
                   tempF = "klöver";
                         
	               varde = rand()%13;
	
               if ( klover[varde] == false ){ // 2

		       if ( varde <= 8 ) {
                    
                    cout << tempF << " " << varde + 2;         
                    summa = summa + varde + 2;                                                             
			     
               }  
               
               else if ( varde == 9  ){
                    
                    cout << tempF << " knekt";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 10 ){
                    
                    cout << tempF << " dam";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 11 ){
                    
                    cout << tempF << " kung";
                    summa = summa + 10;
                    
               }
               
               else
               
               ;
               
               } // End 2
               
               } // End 1
               
               }while ( klover[varde] == true );
               
               klover[varde] == true;

	           ///////////////////////////////////////// NY FÄRG
               
                              do{      
                     
	           if(farg == 3){ // 1
                
                   tempF = "ruter";
                         
	               varde = rand()%13;
	
               if ( ruter[varde] == false ){ // 2

		       if ( varde <= 8 ) {
                    
                    cout << tempF << " " << varde + 2;         
                    summa = summa + varde + 2;                                                             
			     
               }  
               
               else if ( varde == 9  ){
                    
                    cout << tempF << " knekt";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 10 ){
                    
                    cout << tempF << " dam";
                    summa = summa + 10;
                    
               }
               
               else if ( varde == 11 ){
                    
                    cout << tempF << " kung";
                    summa = summa + 10;
                    
               }
               
               else
               
               ;
               
               } // End 2
               
               } // End 1
               
               }while ( ruter[varde] == true );
               
               ruter[varde] == true;

	}

    void summaK(){
         
         cout << "\nDin summa :" << summa;
         
    }
		




};

int main(void){
        
        int svar;
        srand(time(0));
        BlackJack spelare;
        
        do {
        cin >> svar;
        
        if ( svar == 1 ){
             
        spelare.nyttKort();
        spelare.summaK();
        cout << "\n";
        
        }
        
        }while ( svar != 0 );
    
        system("pause");
        return 0;
    
}

[hamsterman]

I don't see what the error is, but in general, this is not the best approach.
If you want to have a random sequence, literally, have a random sequence. Declare a struct Card{ int farg, varde; }; (I'm just guessing what those words mean). Declare an array of 52 Cards and fill it in a for loop. Then use std::random_shuffle (defined in <algorithm>) to shuffle the deck. Finally have an integer which marks the top of the deck and move it every time you draw a card.

[BaconFred]

Yeah but I'm doing a school project so I haven't learned all the things you said there =)
Well of course I can compile it an run it, but I for example get red king more than 1 time when it's not supposed to, when I only want it 1 time. It's like it doesn't check the list or something :)

Thanks for your answer!

[hamsterman]

The algorithm to check whether a card has been played, is not vary simple (not the way you do it right now anyway). What if you roll farg = 0 but all hjarter cards have already been drawn? You'll get stuck in an infinite loop.

You could do like I said. If you don't understand something about that method, ask.

Another way, more similar to yours would be to generate a single random number 'i' with rand()%52. Have an array 'deck' of 52 booleans. Regenerate 'i' in a loop until deck[i] is false (just like you do now). When you do that, 'i' will be the index of a unique card. then farg = i/13 and varde = i%13. After that you can do with farg and varde whatever you need without any kind of checking.