Problem in printing text file!

[alibaba1988]

Hi there,
There is my code:

void printfile(const list<char> &myList)
{
   list<char>::const_iterator itr;
   
   for (itr = myList.begin(); itr != myList.end(); itr++ ) {
      cout << *itr;
   }
   cout << "\n";
}

void getfile(list<char> &myList, const char *file)
{
   ifstream fin;
   char character;
   
   fin.open(file);
   if (!fin) {
      cout << "can't read " << file << "\n";
      exit(0);
   }
   
   while (!fin.eof()) {
      fin.get(character);
      myList.push_back(character);
   }
   fin.close();   
}

The problem is the output always has one more character as same as the last character in text file.
For example: "i have a mouse" this string in text.txt
when i run the program it always print out i have a mousee
Does somebody know what's happening with it? Thanks!

[diedrexler]

you might want to read up on how get() works from the docs on fstream. It's been overloaded so and each one has its subtleties.

To get it working use this line:

 character = fin.get();

[ne555]

   while (!fin.eof()) {
      fin.get(character);
      myList.push_back(character);
   }

eof will be set when you read it. The operation fails and character does not change (I think that's undefined), but you put it in the list again.
Change it to

while( fin.get(character) )
  myList.push_back(character);

[alibaba1988]

Thanks both of you.