Template class LinkedList Problem

[mdanyjam]

I'm Getting this error when i compile my Program.
Error 2 error LNK2019: unresolved external symbol "public: void __thiscall SinglyLL<int>::remove(void)" (?remove@?$SinglyLL@H@@QAEXXZ) referenced in function _main

[b]

Here is the Code..

.[/b]

#include<iostream>
using namespace std;

template <class N>
struct Node
{
		N data;
		Node *next;
		Node(){data = 0; next = NULL;}
		//Node(T &content){data = content;}
		~Node(){delete next;}
};

template<class T>
class SinglyLL
{
	struct Node
	{
		T data;
		Node *next;
		Node(){data = 0; next = NULL;}
		Node(const T &content){data = content;}
		~Node(){delete next;}
	};

	Node* head;
	Node* c;
	// head holds the complete List
	// c Holds the Current Node

public:
	SinglyLL();
	void add(T n);
	void remove();
	void next();
	void back();
	T current();
	void display();
	~SinglyLL();
};

template<class T>
SinglyLL<T>::SinglyLL()
{
	head = NULL;
	c = NULL;
}

template <class T>
void SinglyLL<T>::add(T n)
{
	Node<n> *temp = new Node();
	temp->data = n;
	if(head == NULL)
	{
		// Add the Very First Node, Creation of List
		temp->next = NULL;
		head = temp;
		c = head;
	}
	else if(c->next == NULL)
	{	
		//Add New Node At The End
		c->next = temp;
		c = c->next;
	}
	else
	{
		// Add New Node After Current Node
		Node<n> *temp2 = c->next;
		temp->next = temp2;
		c->next = temp;
		c = c->next;
	}
}


template <class T>
void SinglyLL<T>::remove()
{
	Node<T> *temp = head;
	if(head != c)
	{
		while(temp->next != c)
		{
			temp = temp->next;
		}
		Node<T> *rem = c;
		Node<T> *temp2 = c->next;
		temp->next = temp2;
		temp = c;
		delete rem;
	}
}

template <class T>
void SinglyLL<T>::next()
{
	if(c->next != NULL)
		c = c->next;
}

template <class T>
void SinglyLL<T>::back()
{
	Node<T> *temp = head;
	
	if(head != c)
	{
		while(temp->next != c)
		{
			temp = temp->next;
		}
	}
	c = temp;
}

template <class T>
T SinglyLL<T>::current()
{
	return c->data;
}

template <class T>
void SinglyLL<T>::display()
{
	Node<T> *temp = head;
	while(temp != NULL)
	{
		cout<<temp->data<<" ";
		temp = temp->next;

	}
}

template <class T>
SinglyLL<T>::~SinglyLL()
{
	delete head;
	delete c;
}



int main()
{
	SinglyLL<int> ll;
	ll.add(5);
	ll.add(10);
	ll.add(13);
	ll.add(186);
	ll.add(132);
	ll.back();
	ll.add(23);
	ll.add(25);
	ll.add(444);
	//ll.add(23);
	ll.display();
	cout<<ll.current();
	cout<<endl;
	ll.remove();
	ll.display();
	system("pause");
	return 0;
}

[ne555]

template <class N>
struct Node
{
		N data;
		Node *next;
		Node(){data = 0; next = NULL;}
		//Node(T &content){data = content;}
		~Node(){delete next;}
};

template<class T>
class SinglyLL
{
	struct Node //not a template
	{
		T data;
		Node *next;
		Node(){data = 0; next = NULL;}
		Node(const T &content){data = content;}
		~Node(){delete next;}
	};
//...
template <class T>
void SinglyLL<T>::add(T n)
{
	Node<n> *temp = new Node(); //what? 

which Node will call (outer or inner)?
why do you pass from a no-template Node to a templatized Node?
n does not name a type (incorrect template parameter)

[b2ee]

Which compiler are you using? I don't think GNU can complie this through and then give you that error report.

[mdanyjam]

template <class N>
struct Node
{
		N data;
		Node *next;
		Node(){data = 0; next = NULL;}
		//Node(T &content){data = content;}
		~Node(){delete next;}
};

template<class T>
class SinglyLL
{
	struct Node //not a template
	{
		T data;
		Node *next;
		Node(){data = 0; next = NULL;}
		Node(const T &content){data = content;}
		~Node(){delete next;}
	};
//...
template <class T>
void SinglyLL<T>::add(T n)
{
	Node<n> *temp = new Node(); //what?  

I'm Using the Outer one... Sorry that I've posted it in hurry so i forgot to remove the inner Node structure before posting...

I'm using Visual Studio 2010 c++...

[ne555]

Then it should be Node<T> *temp = new Node<T>();

[mdanyjam]

i have tried that it isn't working...

[diedrexler]

You don't need that inner struct definition for it to be visible in the SinglyLL class. Changing references where the Node is used to Node<T> should get you started without any compilation problems. Just did on my VS 2010 Ultimate.

[Hint: check your destructor & remove functions. ]

[mdanyjam]

Thanks To all of u Guys...