Help with running the program

[Bubbletea]

I am trying to get the time for sorting a large array using bubble sort and insertion sort. however, my program always crash when I tried the size of 750000, I think its because of my compiler or operating system. Can someone run the code for me with the input 750000, and tell me the result? Thank you.

#include<iostream>
#include <ctime>
#include <time.h>
using namespace std;

void insertionSort(int arr[], int length) {
      int i, j, tmp;
      for (i = 1; i < length; i++) {
            j = i;
            while (j > 0 && arr[j - 1] > arr[j]) {
                  tmp = arr[j];
                  arr[j] = arr[j - 1];
                  arr[j - 1] = tmp;
                  j--;
            }
      }
}

void bubbleSort(int arr[], int n) {
      bool swapped = true;
      int j = 0;
      int tmp;
      while (swapped) {
            swapped = false;
            j++;
            for (int i = 0; i < n - j; i++) {
                  if (arr[i] > arr[i + 1]) {
                        tmp = arr[i];
                        arr[i] = arr[i + 1];
                        arr[i + 1] = tmp;
                        swapped = true;
                  }
            }
      }
}

int main(){
    
   srand(time(NULL)); 
  
   time_t begin, end; 
    
    int size;
    cout<<"Enter the number of items in the arrays: ";
    cin>>size;
   
   int array1[size];
   int array2[size];
   
   for(int i=0; i<size; i++)
   { 
     array1[i] = (rand()%2147483648);
   }
   
   for(int i=0; i<size; i++)
   {
   array2[i]=array1[i];
   }
   
    time(&begin);
    bubbleSort(array1,size);
    time(&end);
    cout<<"Time elapsed: " << difftime(end, begin) << " seconds"<< endl;
 
    time(&begin);
    insertionSort(array2,size);
    time(&end);
    cout<<"Time elapsed: " << difftime(end, begin) << " seconds"<< endl;

    
    return 0;
}

[savavampir]

Iam not sure how much you can (max) allocate on stack, did you try to create your arrays dynamically?

int size;
    cout<<"Enter the number of items in the arrays: ";
    cin>>size;
   
   int* array1 = new int[size];
   int* array2 = new int[size];

[savavampir]

Read this http://cs.nyu.edu/exact/core/doc/stackOverflow.txt , don't know how much is it accurate.

[Bubbletea]

thanks, but can you just run the program for me and give me the results?

[king214]

thanks, but can you just run the program for me and give me the results?

Do you not have a compiler?

[savavampir]

Few tips:
1. Change all post to prefix increment
2. This:

for(int i=0; i<size; i++)
   { 
     array1[i] = (rand()%2147483648);
   }
   
   for(int i=0; i<size; i++)
   {
   array2[i]=array1[i];
   }

to this:

for(int i=0; i<size; ++i)
   { 
     array1[i] = (rand()%2147483648);
     array2[i]=array1[i];
    }

3. Use std::vector with std::sort, qsort...
4. Use queryperformancecounter/queryperformancefrequency functions instead time_t if avilable

[tejashs]

try putting unsigned or long in line 6 of your program

void insertionSort(int arr[], int length) {

void insertionSort(int arr[], unsigned int length) {

i thing for just int(signed) in you can assign value between +65535 to -65536