removing leading+trailing dashes from strings

[dutChBZ]

Very good speed optimized code.

I mean size optimized.

Thank you.

[dutChBZ]

It seems to me that there're bugs in the last post:

std::string remove_dashes( const std::string& src )
{
    std::string::size_type first_non_dash = src.find_first_not_of( '-' );
    if( first_non_dash == std::string::npos ) return src; // return std::string();

    std::string::size_type last_non_dash = src.find_last_not_of( '-' );
    if( last_non_dash == first_non_dash ) return std::string(); // kick this

    return std::string( src, first_non_dash, last_non_dash - first_non_dash ); // + 1);
}

==>fixed:

std::string remove_dashes( const std::string& src )
{
    std::string::size_type first_non_dash = src.find_first_not_of( '-' );
    if( first_non_dash == std::string::npos ) return std::string(); // all dashes

    std::string::size_type last_non_dash = src.find_last_not_of( '-' );

    return std::string( src, first_non_dash, last_non_dash - first_non_dash + 1 );
}

==>optimized:

void S::F_CutDash(string& s)
{
	if (s.find('-') != string::npos) { // rather seldom
		int i = s.find_first_not_of('-');
			
		if (i == string::npos)
			s.erase();
		else
			s.assign(s, i, s.find_last_not_of('-') - i + 1);
	}
}