Why is the value showing as 0 in my function?

[x3ldonx]

Isn't it written correctly?

#include <stdio.h>
#include <stdlib.h>

void Instruct( void );
void GetNumbers( int [] );
int FindLargest (int []);

void main()
{
	int a[ 10 ];

	Instruct();
	GetNumbers( a );

	printf("the largest value is %d\n", FindLargest(a));
	
	
	system( "pause" );
}

void Instruct( void ) 
{
	printf( "This program will determine the largest and smallest values in a set of ten numbers. "
	"It will also compute the sum and average of the numbers.\n\n" );
}

void GetNumbers( int [] )
{
	int b[ 10 ];
	int number = 0;
	
	printf( "Please enter your list of ten numbers: " );

	for ( int i = 0 ; i < 10; i++ ) {
		scanf( "%d", &number );
		b[ i ] = number;
	}

	printf( "Your array has these values: " );

	for ( int i = 0 ; i < 10; i++ ) {
		printf( "%d ", b[ i ] );
	}

	printf( "\n" );
}

int FindLargest ( int array [] )

{
	
	int maxNumber = 0 ;
	for(int i = 0; i < 10; i++)
	{
		if(array[i] > maxNumber)
	maxNumber = array[i];
	}
	return maxNumber;
	}

[Albatross]

The problem is with your GetNumbers. Do you see what happens there?

-Albatross

[x3ldonx]

I don't see it, my GetNumbers function returns the values that the user enters, and that is what I want to happen.

Are you referring to something else?

[Duthomhas]

No, it doesn't. Compare the headers for GetNumbers() and FindLargest().

BTW, I would recommend passing the size of the array as an additional argument, instead of assuming it will always be ten.

[edit] fixed typo

[Albatross]

Actually, Duoas brings up a good point. Don't assume the array size will be 10; it might be a good idea to pass the array size as an extra variable. But! Get your program to work for a size 10 array first. :)

Line 27: Are we missing something here?
Line 29: Do we have something redundant here?

-Albatross

[zhiyuanhou]

void GetNumbers( int b[] )
{
	int number = 0;
	
	printf( "Please enter your list of ten numbers: " );

	for ( int i = 0 ; i < 10; i++ ) {
		scanf( "%d", &number );
		b[ i ] = number;
	}

	printf( "Your array has these values: " );

	for ( int i = 0 ; i < 10; i++ ) {
		printf( "%d ", b[ i ] );
	}

	printf( "\n" );
}

this function may be you want;

[x3ldonx]

ok, so I fixed what you suggested.

I have modified the FindLargest function and now I get a "-76387648", type number (which I assume is the memory location)

My GetNumbers function still works the same, should there have been a change?

#include <stdio.h>
#include <stdlib.h>
#define SIZE 10
void Instruct( void );
void GetNumbers( int [], int size);
int FindLargest (int []);

void main()
{
	int a[ SIZE ];

	Instruct();
	GetNumbers( a , SIZE);

	FindLargest(a);
	//printf("%d",FindMax(array));
	
	system( "pause" );
}

void Instruct( void ) 
{
	printf( "This program will determine the largest and smallest values in a set of ten numbers. "
	"It will also compute the sum and average of the numbers.\n\n" );
}

void GetNumbers( int array [], int size )
{
	int b[ SIZE ];
	int number = 0;
	
	printf( "Please enter your list of ten numbers: " );

	for ( int i = 0 ; i < size; i++ ) {
		scanf( "%d", &number );
		b[ i ] = number;
	}

	printf( "Your array has these values: " );

	for ( int i = 0 ; i < size; i++ ) {
		printf( "%d ", b[ i ] );
	}

	printf( "\n" );
}

int FindLargest ( int array [] )

{
	int maxNumber;
	int temp = array[0] ;

	printf("the largest value is");
	for(int i = 0; i < 10; i++)
	{
		if(array[i] > temp)
	maxNumber = array[i];
	}
	return printf("%d", temp);
	}

[x3ldonx]

Im back at square 1, Now instead of the long negative number, I get 1.

void GetNumbers( int b [], int size )
{
	int number = 0;
	
	printf( "Please enter your list of ten numbers: " );

	for ( int i = 0 ; i < size; i++ ) {
		scanf( "%d", &number );
		b[ i ] = number;
	}

	printf( "Your array has these values: " );

	for ( int i = 0 ; i < size; i++ ) {
		printf( "%d ", b[ i ] );
	}

	printf( "\n" );
}

int FindLargest ( int array [] )

{
	int maxNumber;
	int temp = array[0] ;

	printf("the largest value is");
	for(int i = 0; i < 10; i++)
	{
		if(array[i] > temp)
	maxNumber = array[i];
	}
	return printf("%d", temp);
	}

[x3ldonx]

OMG, I worked now!