Fish task

I have doubt if my understanding about the task is right or not since I don't get the score I want.
The task says:

You are given two non-empty arrays A and B consisting of N integers. Arrays A and B represent N voracious fish in a river, ordered downstream along the flow of the river.

The fish are numbered from 0 to N − 1. If P and Q are two fish and P < Q, then fish P is initially upstream of fish Q. Initially, each fish has a unique position.

Fish number P is represented by A[P] and B[P]. Array A contains the sizes of the fish. All its elements are unique. Array B contains the directions of the fish. It contains only 0s and/or 1s, where:

0 represents a fish flowing upstream,
1 represents a fish flowing downstream.
If two fish move in opposite directions and there are no other (living) fish between them, they will eventually meet each other. Then only one fish can stay alive − the larger fish eats the smaller one. More precisely, we say that two fish P and Q meet each other when P < Q, B[P] = 1 and B[Q] = 0, and there are no living fish between them. After they meet:

If A[P] > A[Q] then P eats Q, and P will still be flowing downstream,
If A[Q] > A[P] then Q eats P, and Q will still be flowing upstream.
We assume that all the fish are flowing at the same speed. That is, fish moving in the same direction never meet. The goal is to calculate the number of fish that will stay alive.

For example, consider arrays A and B such that:

A[0] = 4 B[0] = 0
A[1] = 3 B[1] = 1
A[2] = 2 B[2] = 0
A[3] = 1 B[3] = 0
A[4] = 5 B[4] = 0
Initially all the fish are alive and all except fish number 1 are moving upstream. Fish number 1 meets fish number 2 and eats it, then it meets fish number 3 and eats it too. Finally, it meets fish number 4 and is eaten by it. The remaining two fish, number 0 and 4, never meet and therefore stay alive.

Write a function:

int solution(vector<int> &A, vector<int> &B);

that, given two non-empty arrays A and B consisting of N integers, returns the number of fish that will stay alive.

For example, given the arrays shown above, the function should return 2, as explained above.

Write an efficient algorithm for the following assumptions:

N is an integer within the range [1..100,000];
each element of array A is an integer within the range [0..1,000,000,000];
each element of array B is an integer that can have one of the following values: 0, 1;
the elements of A are all distinct.


And this is my algorithm's output:

1
2
3
4
5
6
7
8
9
10
11
12
13
int main()
{
	std::vector A1{ 4,3,2,1,5 }, B1{ 0, 1, 0,0,0 };
	std::vector A2{ 4,3,2,1,5 }, B2{ 1,1,0,1,0};
	std::vector A3{ 4,7,3,1,5,6,2 }, B3{ 0,1,1,0,1,0,1};
	std::vector A4{ 5,3,1,9,2,4,6,7,8,10 }, B4{ 0,1,0,0,0,1,1,0,0,1 };
	std::vector A5{3,5,2,4,1,7,6}, B5{1,0,1,0,0,1,1};
	std::cout << solution(A1,B1) << '\n';  // prints  2
	std::cout << solution(A2,B2) << '\n';  // prints  3
	std::cout << solution(A3, B3) << '\n'; // prints  5
	std::cout << solution(A4, B4) << '\n'; // prints  6
	std::cout << solution(A5, B5) << '\n'; // prints  5
}


My question is, are the results correct? If not, could you tell me which one is wrong based on the task's description or give me an example to test it by my algo.

PS: Now I only need some guide to know what the task actually expects. In the next post(s) I will send my algo for it.
Last edited on
Fish don't "flow", they "swim". Only fluids flow (by definition).

are the results correct

No.

A1,B1 is correct
A2, B2 should give 1
A3, B3 should give 3
A4, B4 is correct
A5, B5 is correct
Last edited on
A2, B2 is:

Upstream ====> Downstream
             | 4 | 3 | 2 | 1 | 5 |
             | 1 | 1 | 0 | 1 | 0 |
             |-->|-->|<--|-->|<--|


Here starting from upstream towards downstream, 3 eats 2 then 5 eats 1 then it eats the rest, 3 and 4, so only 5 remains. How should it give two?
Last edited on
You are correct that only 5 remains (which doesn’t correspond to your code). I revised my answer and added the others.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
#include <iostream>
#include <vector>
#include <stack>
using namespace std;

int solution( const vector<int> &A, const vector<int> &B )
{
   // ... the code that I'm not going to give you 'cos it's more than my life's worth
   // https://cplusplus.com/forum/general/284338/#msg1232258
}

//==============================================================================

int main()
{
   vector< vector<int> > tests = { {4,3,2,1,5}            , {0,1,0,0,0},
                                   {4,3,2,1,5}            , {1,1,0,1,0},
                                   {4,7,3,1,5,6,2}        , {0,1,1,0,1,0,1},
                                   {5,3,1,9,2,4,6,7,8,10 }, {0,1,0,0,0,1,1,0,0,1},
                                   {3,5,2,4,1,7,6}        , {1,0,1,0,0,1,1}       };
   for ( int i = 0; i < tests.size() / 2; i++ ) cout << solution( tests[2*i], tests[2*i+1] ) << '\n';
}



2
1
3
6
5


the code that I'm not going to give you
Thank you for that. Only understanding the task was rather puzzling for me. The code is not.
Registered users can post here. Sign in or register to post.