Bug in program (program crashes at freeaddrinfo())

[niklas]

I made this stripped down version of a program im having trouble debugging.

The program hangs / crashes at freeaddrinfo about 90% of the time and succeeds the last 10%.

This seems like it is something dns specific (dns lookup of www.google.no returns 3 ip's?) since most domains gets resolved and connected to just fine (usually test towards niklas.endoftheinternet.org)

Here is the stripped down version of the project which is able to recreate the bug. The crash happens in tcpConnect()

Any help appriciated

/*
 *
 *        Stripped code sample to test a bug
 *        Files: 1
 *        -    main.cpp
 *
 */
 
 
 /*
 The program hangs at freeaddrinfo about 50% of the time
 The program crashes at freeaddrinfo about 40% of the time
 The program runs successfully 10% of the time
 
 Tested on Windows 7(64-bit), compiled with minGW
 
 */

 /*
Compilescript: Notepad++

SET g++ = C:\Dev-Cpp\bin\g++.exe
SET obj = $(CURRENT_DIRECTORY)\$(NAME_PART)
"$(g++)" -c "$(FULL_CURRENT_PATH)" -o "$(obj).o"
"$(g++)" "$(obj).o" -lalleg -lkernel32 C:/Dev-Cpp/lib/libws2_32.a -luser32 -lgdi32 -lcomdlg32 -lole32 -ldinput -lddraw -ldxguid -lwinmm -ldsound -o "$(obj).exe" 
UNSET obj
UNSET g++


 */
 
 
 
#include <windows.h>
#include <stdio.h>
#include <Ws2tcpip.h>

void error(char* szExitMessage);
SOCKET connectWalk(struct addrinfo* ai_SocketInfo);
int tcpConnect(char* host, char* port, SOCKET* connection);

using namespace std;
int main(){
    //Initialize WSAData
    
    int nStatus = 0;
    WSADATA wsadata;
    
    printf("Starting WSAData...\r\n");
    nStatus = WSAStartup(MAKEWORD(2,2),&wsadata);
    if(nStatus != NO_ERROR){
        error("Error at WSAData\r\n");
    }
    
    //Connect part
    
    char* szHost = "www.google.no";
    char* szPort = "80";
    
    SOCKET sDownloadSock;
    
    nStatus = tcpConnect(szHost, szPort, &sDownloadSock);
    
    printf("Connected Successfully, lets try to send something.");
    
    
    char szTest[512] = "";
    sprintf(szTest, "GET /%s HTTP/1.1\r\nHost: %s\r\n\r\n", "", szHost);
    nStatus = send(sDownloadSock, szTest, strlen(szTest), 0);
    
    printf("Debugging: \r\n\tsend() / nStatus = %d\r\n\tWSAGetLastError() = %d\r\n", nStatus, WSAGetLastError());
    
    
    error("Success!");
}




void error(char* szExitMessage){
    printf("%s\r\n", szExitMessage);
    system("pause");
    exit(1);
}



int tcpConnect(char* host, char* port, SOCKET* connection){
    printf("tcpConnect: Connecting to host: %s:%s.\r\n", host, port);
    int status;
    struct addrinfo setupInfo, *tempDeleter;
    struct addrinfo* retInfo;
    tempDeleter = &setupInfo;
    memset(&setupInfo, 0, sizeof(setupInfo));
    
    setupInfo.ai_family = AF_UNSPEC;
    setupInfo.ai_socktype = SOCK_STREAM;
    setupInfo.ai_flags = AI_PASSIVE;
    status = getaddrinfo(host, port, &setupInfo, &retInfo);
    if(status != 0){
        printf("Failed @ getaddrinfo![%d//%d]", status, WSAGetLastError());
        freeaddrinfo(&setupInfo);
        freeaddrinfo(retInfo);
        *connection = INVALID_SOCKET;
        error("failed after getaddrinfo");
    }
    
    *connection = connectWalk(retInfo); 
    
    printf("freeing addrinfo's\r\n");
    
    //This is where the program hangs
    // It starts hanging here about 50% of the time.
    freeaddrinfo(retInfo);        
    freeaddrinfo(tempDeleter);
    //end of crash place 1
    printf("freeaddrinfo() done, tcpConnect done.");
    if(*connection == INVALID_SOCKET){
        error("Failed when connecting to socket");
        closesocket(*connection);
        *connection = INVALID_SOCKET;
        return 1;
    }
    return 0;
}




SOCKET connectWalk(struct addrinfo* ai_SocketInfo){
       struct addrinfo* tryInfo;
       SOCKET retSock;
       
       for(tryInfo = ai_SocketInfo; tryInfo != NULL; tryInfo = tryInfo->ai_next){ //walk through sockets and connect to first available one
                   if((retSock = socket(tryInfo->ai_family, tryInfo->ai_socktype, tryInfo->ai_protocol)) == -1){
                               #ifdef PRINTSOCKERRORS
                               log("WALKERROR: socket");
                               #endif
                               continue;
                               }
                   
                   if(connect(retSock, tryInfo->ai_addr, tryInfo->ai_addrlen) == -1){
                                       
                                       closesocket(retSock);
                                       #ifdef PRINTSOCKERRORS
                                       log("WALKERROR: @connect\r\n");
                                       #endif
                                       continue;
                                       }
                   
                   break;
                   }
       
       if(tryInfo == NULL){
                  closesocket(retSock);
                  #ifdef PRINTSOCKERRORS
                  log("WALKERROR: could not connect!");
                  #endif
                  freeaddrinfo(ai_SocketInfo);
                  return INVALID_SOCKET;
                  }
       freeaddrinfo(ai_SocketInfo);
       return retSock;
}

[m4ster r0shi]

Why are you trying to free something that wasn't allocated dynamically here -> freeaddrinfo(tempDeleter); ?

[niklas]

Because thats what they did in the examples on msdn, and if i remove it there is no difference, still hangs. Also im pretty sure i tried removing it and it made a small memoryleak in another project of mine, not completely sure about this though.

edit: removed that freeaddrinfo() from both projects, doesn't fix anything though
edit2: program eats 100% of a processor core while in freeaddrinfo.

[niklas]

/facepalm, i "free'd" the same addrinfo in connectWalk AND tcpConnect. Memorycleanup is good, but not too much -.-"

Solved then i guess.