Segmentation Fault when trying to count words in a file.

[Disch]

Right away I can tell your swap function doesn't work. It swaps the local vars x and y, which are copies of the passed variables. It doesn't change the variables that you pass to it, therefore it effectively does nothing.

You'd need to pass them by reference:

void swap(int& x,int& y) // note the '&' symbols 

Of course, you could just use std::swap.

[BlackFrost]

Indeed, I realized that... I have since began trying to make it work again. I'll post my entire code again for reference, as I'm close to solving this.

In the struct, wordCount is how many times the word appears in the file, so I messed that up. Here, the only problem the compiler reports is this:

p1.cpp:79: error: no match for 'operator<' in '*((+(((unsigned int)idx) * 8u)) + list) < *((+(((unsigned int)idxMin) * 8u)) + list)'

I feel like I'm getting closer to doing this. I sure hope so at least.

#include <fstream>
#include <iostream>
#include <iomanip>

using namespace std;

/*********************************************************************/
/*  Author:     removed                                              */
/*  Course:     CSC136 010                                           */
/*  Assignment: #1                                                   */
/*  Due Date:   September 11, 2010                                   */
/*  Filename:   p1.cpp                                               */
/*  Purpose:    This program will determine the number of characters */
/*                and lines in a file and print the number of times  */
/*                each word occurs and sort them accordingly.        */
/*********************************************************************/

//Global struct.
  struct wordRec
  {
    string word;
    int wordCount;
  }; 
  
  wordRec list[1000];

//This function calculates the number
//of characters and lines in the file.
int charCount(ifstream& inf, int& a, int& b)
{
  //Declare variables.
  char c;
  string d;
  a, b = 0;
  
  //Finds the number of characters.
  inf.get(c);
  inf.seekg(0, ios::end);
  a = inf.tellg();
  inf.seekg(0, ios::beg);
  
  //Finds the number of lines.
  while (getline(inf, d, '\n'))
    b++;
}

void wordCalc(ifstream& inf, wordRec list[], int& count)
{
  string s;
  int i = 0;
 
  while ((inf >> s) && (i < 1000))
    {
    list[i].word = s;
    i++;
    }
  count = i;
}

void swap(wordRec& x, wordRec& y)
{
  wordRec temp;
  temp = x;
  x = y;
  y = temp;
}

void selSort(wordRec list[], int& elts)
{
  int spot = 0;
  int idxMin = 0;
  int idxMax = elts;

  for(int spot = 0; spot < elts - 1; spot++)
    {
    int idxMin = spot;
    for(int idx = idxMin+1; idx < elts; idx++)
      {
      if(list[idx] < list[idxMin])
        idxMin = idx;
      if(idxMin != spot)
        swap(list[idxMin],list[spot]);
      else
        {
          swap(list[idxMin],list[idxMax]);
          list[spot].wordCount++;
          elts--;
        }
      }
    }
}


int main()
{
  //Delcare variables.
  string fileName;    
  ifstream inf;          
  int charNum, newLine, count;
  
  //Prompt user for filename and attempt to
  //open that file.
  cout << "Enter filename.\n >";
  cin >> fileName;
  inf.open(fileName.c_str());
  
  //If the file doesn't open, display an
  //error message and close the program.
  if (!inf.is_open())
  {
    cout << "File " << fileName << " does not exist in the client's current directory." << endl;
    exit(1);
  }
  
  //Finds the number of characters and lines.
  charCount(inf, charNum, newLine); 
  
  //Reopen the program.
  inf.close();
  inf.clear();
  inf.open(fileName.c_str());
  
  //Function call to count the words.
  wordCalc(inf, list, count);
  
  selSort(list, count);
  
  int i = 0;
  for(i = 0; i < count; i++)
    cout << list[i].word << endl;
  
  
  
  
  return 0;
}

[BlackFrost]

Ended up figuring it out. Still, I owe a lot to you guys for pushing me in the right direction. So, thanks. :)