help with stack

[CodeHunger123]

Hello, I'm trying to create a stack wherein it can accept any data types, but somehow I'm having some errors while running the program.

I keep on getting the error LNK2019 and LNK1120.

It would be great if you could help me with this, thank you!


the code:

//Main.cpp File
#include <iostream>
#include <string>
#include "Data.h"
using namespace std;

int main()
{
IntStack<string> stack(5);
string catchVar;

cout << "Pushing hello\n";
stack.push("hello");
cout << "Pushing good\n";
stack.push("good");
cout << "Pushing morning\n";
stack.push("morning");
cout << "Pushing afternoon\n";
stack.push("Afternoon");
cout << "Pushing evening\n";
stack.push("Evening");
cout << "Popping...\n";
stack.pop(catchVar);
cout << catchVar << endl;
stack.pop(catchVar);
cout << catchVar << endl;
stack.pop(catchVar);
cout << catchVar << endl;
stack.pop(catchVar);
cout << catchVar << endl;
stack.pop(catchVar);
cout << catchVar << endl;
}

//Implementation.cpp file
#include <iostream>
#include "Data.h"
using namespace std;

template <typename T>
IntStack<T>::IntStack(int size)
{
stackArray = new T[size];
stackSize = size;
top = -1;
}

template <typename T>
void IntStack<T>::push(T num)
{
if (isFull())
{
cout << "The stack is full.\n";
}
else
{
top++;
stackArray[top] = num;
}
}

template <typename T>
void IntStack<T>::pop(T& num)
{
if (isEmpty())
{
cout << "The stack is empty.\n";
}
else
{
num = stackArray[top];
top--;
}
}

template <typename T>
bool IntStack<T>::isFull()
{
bool status;

if (top == stackSize - 1)
status = true;
else
status = false;
return status;
}

template <typename T>
bool IntStack<T>::isEmpty()
{
bool status;

if (top == -1)
status = true;
else
status = false;

return status;
}

//data.h file

#pragma once
template<typename T>
class IntStack
{
private:
T* stackArray;
int stackSize;
int top;

public:
IntStack(int size);
void push(T num);
void pop(T& num);
bool isFull();
bool isEmpty();
};

[coder777]

I keep on getting the error LNK2019 and LNK1120.

These are linker errors. That could mean either you did not implement certain functions or you have a double definition. Further details within the error should tell what exactly the problem is.

[seeplus]

If a class/struct is templated, it can't be split between header and implementation files. The whole class/struct has to be coded in the same header file.

[seeplus]

As one file, consider:

#include <iostream>
#include <string>

template<typename T>
class IntStack {
private:
	T* stackArray {};
	int stackSize {};
	int top {-1};

public:
	IntStack(unsigned size);
	~IntStack() { delete[] stackArray; }

	IntStack(const IntStack&) = delete;
	IntStack& operator=(const IntStack&) = delete;

	void push(const T& num);
	void pop(T& num);
	bool isFull() const;
	bool isEmpty() const;
};

template <typename T>
IntStack<T>::IntStack(unsigned size) : stackArray(new T[size]), stackSize(size) {}

template <typename T>
void IntStack<T>::push(const T& num) {
	if (isFull())
		std::cout << "The stack is full.\n";
	else
		stackArray[++top] = num;
}

template <typename T>
void IntStack<T>::pop(T& num) {
	if (isEmpty())
		std::cout << "The stack is empty.\n";
	else
		num = stackArray[top--];
}

template <typename T>
bool IntStack<T>::isFull() const {
	return top == stackSize - 1;
}

template <typename T>
bool IntStack<T>::isEmpty() const {
	return top == -1;
}

int main() {
	IntStack<std::string> stack(5);
	std::string catchVar;

	std::cout << "Pushing hello\n";
	stack.push("hello");
	std::cout << "Pushing good\n";
	stack.push("good");
	std::cout << "Pushing morning\n";
	stack.push("morning");
	std::cout << "Pushing afternoon\n";
	stack.push("Afternoon");
	std::cout << "Pushing evening\n";
	stack.push("Evening");
	std::cout << "Popping...\n";
	stack.pop(catchVar);
	std::cout << catchVar << '\n';
	stack.pop(catchVar);
	std::cout << catchVar << '\n';
	stack.pop(catchVar);
	std::cout << catchVar << '\n';
	stack.pop(catchVar);
	std::cout << catchVar << '\n';
	stack.pop(catchVar);
	std::cout << catchVar << '\n';
}

Pushing hello
Pushing good
Pushing morning
Pushing afternoon
Pushing evening
Popping...
Evening
Afternoon
morning
good
hello