bubble sort syntax error (wrong Output)

[pika77]

/*
Design and develop a Bubble Sort program using two
different modular programming methods, i.e. pass-by-
value,
*/

#include <iostream>
using namespace std;
void display(int x);
void check_if(int n1, int n2);
int main()
{
    int i, j, pass = 0;
    int a[10] = { 100,33,49,23,84,2,72,17,82,64 };
    cout << "Input list ...\n";
    for (i = 0; i < 10; i++) {
    display(a[i]);
    }
    
    cout << endl;
    for (i = 0; i < 10; i++)
    {
        for (j = i + 1; j < 10; j++)
        {
            check_if(a[j], a[i]);
        }
        pass++;
    }
    cout << "Sorted Element List ...\n";
    for (i = 0; i < 10; i++) {
    display(a[i]);         // Output is wrong 
    }
    cout << "\nNumber of passes taken to sort the list:" << pass << endl;
	return 0;
}

void display(int x)
{ 
   cout << x << "\t";   
}

void check_if(int n1,int n2)
{
    int temp;

    if (n1 < n2)
    {
        temp = n2;
        n2 = n1;
        n1 = temp;
    }
}

[seeplus]

Now is the time to brush up your debugging skills - or get to grips with it if you haven't used it before.

Using the debugger trace through the code and watch the contents of the variables. When it doesn't execute as expected from your design/algorithm then you have found an issue. Fix that and then repeat the debugging until the program works as expected.

[pika77]

hmm is it something wrong in this function?

void check_if(int n1,int n2)
{
    int temp;

    if (n1 < n2)
    {
        temp = n2;
        n2 = n1;
        n1 = temp;
    }
}

is that i need to use pass-by-references to solve this? something like passing the whole array instead of individual element?

[pika77]

but then if like this it become pass-by-references instead of pass-by-value.

[MikeyBoy]

Yes, if you want the changes in value for n1 and n2 to be reflected in the calling code, you need to pass them by reference.

[thmm]

Replace line 19 with

if (a[j] < a[i])
    std::swap(a[j], a[i]);

You need to include <utility>
Your sort logic is right.

Input list ...
100	33	49	23	84	2	72	17	82	64	
Sorted Element List ...
2	17	23	33	49	64	72	82	84	100	
Number of passes taken to sort the list:10

[pika77]

owwh I see. Thks again for helping me ^^.