the good ol EXPECTED unqualified ID before 'public'

[dkg123]

this error has my program completely hung

code in q:

#include <iostream>

#include <string>

#include <fstream>

#include <cstdlib>

#include <vector>

using namespace std;


class Question

public:
{
              Question();

              Question(std::string theQuestion, int pointValue);
					{
             question=theQuestion;

              value=pointValue;
              }


              std::string getQuestion();
              {
                return question;
              }


              int getValue();
              {
                return value;
              }

              virtual std::string printOptions(){return "";};

              virtual std::string getAnswer(){return "";};
private:


              std::string question;

              int value;
};

Its taking me to this class when I attempt to compile it.


Any help would be great. Or maybe point me in the right direction. I can upload the full source code if that would help but it said it was to long.

[malibor]

Question(std::string theQuestion, int pointValue);
					{
             question=theQuestion;

              value=pointValue;
              }

you should remove semicolon after function signature, present also in other functions.

[jlb]

Perhaps you should consider moving "public:" to after the opening brace of the class?

[dkg123]

Here's as far as I made it.

Still throwing mad errors.....

#include <iostream>

#include <string>

#include <fstream>

#include <cstdlib>

#include <vector>

using namespace std;


class Question
{

public:


Question(std::string theQuestion, int pointValue)
{
question=theQuestion;

value=pointValue;
}


std::string getQuestion()
{
return question;
}


int getValue()
{
return value;
}

virtual std::string printOptions(){return "";};

virtual std::string getAnswer(){return "";};

private:
std::string question;
int value;
};


class QuestionMC : public Question
{


public:


QuestionMC(std::string theQuestion, int pointValue, std::string theAnswer) : Question(theQuestion, pointValue)
{

answer = theAnswer;

for (int i=0; i<6; i++)

{

options[i] = "";

}
private:

std::string answer;

std::string options[6];
}

void addOption(string anOption)

{

for (int i=0; i<6; i++)

{

if (options[i]=="")

{

              options[i] = anOption;

              break;

}

}

}

string printOptions()

{

string str = "";

for (int i=0; i<6; i++)

{

if (options[i] != "")

{

              str = str + (char)(65+i) + ". " + options[i] + "\n";

}

else

{

              break;

}



}

return str;

}

string getAnswer()

{

return answer;

}

};



class QuestionTF : public Question

{

private:

string answer;

public:

QuestionTF(string theQuestion, int pointValue, string theAnswer) : Question(theQuestion, pointValue)

{

answer = theAnswer;

}

string printOptions()

{

return "True or False";

}

string getAnswer()

{

return answer;

}

};



class Examination

{

private:

vector questions;

public:

void LoadQuestions(ifstream &fin)

{

questions.clear();

int numberofquestions;

string questiontype;

string questiontext;

string correctanswer;



int pointvalue;



fin >> numberofquestions;



string extra;

char ex;

for (int i=0; i;)

{

fin >> questiontype;

if (questiontype == "TF")

{

              fin >> pointvalue;

              fin >> extra;

              getline(fin, questiontext);



              fin >> correctanswer;

              QuestionTF *questiontf = new QuestionTF(questiontext, pointvalue, correctanswer);

              questions.push_back(questiontf);                                                     

}

else if (questiontype == "MC")

{



              fin >> pointvalue;

              fin.ignore();

              getline(fin, questiontext);

              int numberofoptions;

              fin >> numberofoptions;

              string *answers;

              answers = new string[numberofoptions];

              fin.ignore();

              for (int i=0; i;)

              {

                            getline(fin, answers[i]);

             

              }

              fin >> correctanswer;

              QuestionMC *questionmc = new QuestionMC(questiontext, pointvalue, correctanswer);

              for (int i=0; i<1; i;)

              {

                            questionmc->addOption(answers[i]);

              }

              questions.push_back(questionmc);

}

}

}

int GetNumberOfQuestions()

{

return questions.size();

}

string getCorrectAnswer(int index)

{

return questions[index]->getAnswer();

}

void DisplayIthQuestion(int index)

{

cout << "Question Number" << (index+1) << ": ";

cout << questions[index]->getQuestion() << endl;

cout << questions[index]->printOptions() << endl;

}

int getPointsValue(int i)

{

return questions[i]->getValue();

}

void DisplayQuestions()

{

for (int i=0; i;i++)

{

cout << "Question Number" << (i+1) << ": ";

cout << questions[i]->getQuestion() << endl;

cout << questions[i]->printOptions() << endl;

cout << "Correct Answer: " << questions[i]->getAnswer() << endl << endl;

}

}

};


class Student

{

private:

int pointsAvailable;

int pointsScored;

public:

Student()

{

pointsAvailable = 0;

pointsScored = 0;

}

void SetPointsScored(int point)

{

pointsScored = point;

}

int GetPointsScored()

{

return pointsScored;

}

void SetPointsAvailable(int point)

{

pointsAvailable = point;

}

int GetPointsAvailable()

{

return pointsAvailable;

}

};



char DisplayMenu();

string ConvertToupper(string str);



int main()

{

Examination exam;

char option;

int totalpoints = 0;

int totalAvailablePoints = 0;

option = DisplayMenu();

Student student;

while (option != 'Q')

{

switch (option)

{

case 'L':

{

string filename;

cout << "Enter the filename: ";

cin >> filename;

ifstream fin;

fin.open(filename.c_str());

while (!fin)

{

cout << "Error: Input file does not exists. Try again." << endl;

cout << "Enter the filename: ";

cin >> filename;

fin.open(filename.c_str());

}

exam.LoadQuestions(fin);

fin.close();

}

break;

case  'T':

{

string answer;

for (int i=0; i<1; i++)

{

cout << endl;

exam.DisplayIthQuestion(i);

cout << "Enter correct answer: ";

cin >> answer;

answer = ConvertToupper(answer);

string correct = ConvertToupper(exam.getCorrectAnswer(i));

cout << "The correct answer is: " << correct << endl;

if (answer == correct)

{

student.SetPointsScored (student.GetPointsScored() + exam.getPointsValue(i));

cout << "Good job here!" << endl;

}

else

{

cout << "Better luck next time...." << endl;

}

student.SetPointsAvailable (student.GetPointsAvailable() + exam.getPointsValue(i));

}


}

break;

case  'S':

{

cout << "Total points available: " << student.GetPointsAvailable() << endl;

cout << "Total points scored: " << student.GetPointsScored() << endl;

cout << "Percentage of points: " << ((double)student.GetPointsScored()/(double)student.GetPointsAvailable()) * 100.0 << endl;

}

break;

}

option = DisplayMenu();

}

return 0;

}



string ConvertToupper(string str)

{

for (int i=0 ;i;)

{

str[i] = toupper(str[i]);

}

return str;

}

char DisplayMenu()

{

char option;

while (true)

{

cout << endl << "\tL - Load an Exam" << endl;

cout << "\tT -Take an exam Exam" << endl;

cout << "\tS - Show exam results" << endl;

cout << "\tQ - Quit" << endl;

cout << "Enter an option: ";

cin >> option;

option = toupper (option);

if (option == 'L' || option == 'T' || option == 'S' ||option == 'Q')

return option;

else

cout << "ERROR: Input a valid option." << endl;

}
}

Essentially it's supposed to be a program that displays a menu and allows the user to pick from a set of options

1.load exam
2.take exam
3.show exam
4.quit

In other sections we created a program that creates the "exams" I mentioned which just names the text file "exam.txt"

At this point I am thinking that I should've just wrote the program from scratch instead of using this really buggy sample code.


Anyway....If anyone wants to try to figure it out have at it.
This semester (as far as this class goes) is toast.

[dkg123]

Source code from the previous project. Apparently there is supposed to be a bit of synergy between these two but for some reason, I can't see it.

//Week 4 Sample Solution to build upon in Week 5

//CS 215

//Dr. Howard Evans



#include <iostream>

#include <string>

#include <fstream>

#include <cstdlib>



using namespace std;











class Question // super class

{

public:



string getQuestion()//gets the question

{

return question;

}



virtual int getValue() //gets the point value of the question

{

return value;

}



virtual string getQuestionType()// gets the type of question

{

return questiontype;

}





virtual void setQuestion(string answer, int value)

{

}

virtual void setNewQuestion(string answer, int value)

{

}

virtual void printOptions()

{

}



virtual string getAnswer()

{

return answer;

}



private:

string question,  answer;

int value;

string questiontype;

};





class QuestionTF: public Question// class for true and false questions

{

public:

void setQuestion(string theQuestion, int pointValue)

{

string theAnswer;

questiontype = "TF";

question = theQuestion;

value = pointValue;

options = "true/false";

//get the answer from the file

getline(cin,theAnswer);

answer = theAnswer;

}



void setNewQuestion(string theQuestion, int pointValue)

{

string theAnswer;

questiontype = "TF";

question = theQuestion;

value = pointValue;

options = "true/false";

//get the answer from user

cout<<"Enter answer true/false\n";

getline(cin,theAnswer);

answer = theAnswer;

}



int getValue() //gets the point value of the question

{

return value;

}



string getQuestionType()// gets the type of question

{

return questiontype;

}



void printOptions()//prints the options for that question

{

cout<<question<<endl;

cout<<answer<<endl;

}



string getAnswer()//outputs the answer for that question

{

return answer;

}

private:

string question, questiontype;

string answer;

string options;

int value;

};







class QuestionMC: public Question//class for multiple choice

{

public:

void setQuestion(string theQuestion, int pointValue)

{

string line;

questiontype = "MC";

getline(cin,line);

numberOfOptions = atoi(line.c_str());

cout<<numberOfOptions<<endl;

question = theQuestion;

value = pointValue;

//get the individual choice lines and load to options array

for (int count = 0; count<numberOfOptions;count++){

getline(cin,line);

options[count] = line;

}

//get the answer from the file and load into answer

getline(cin, line);

answer = line;

}



void setNewQuestion(string theQuestion, int pointValue)

{

string line;

questiontype = "MC";

//get the number of choices from the user

cout<<"Enter the number of choices:  ";

getline(cin,line);

numberOfOptions = atoi(line.c_str());



question = theQuestion;

value = pointValue;

//get the individual choice lines and load to options array

for (int count = 0; count<numberOfOptions;count++){

cout<<"\nEnter next option:  ";

getline(cin,line);

options[count] = line;

}

//get the answer from the user and load into answer

cout<<"\nEnter Answer:  ";

getline(cin, line);

answer = line;

}

void printOptions()// prints the questions, options, and answer

{

//char first = 'A';

cout<<question<<endl;

for(int count = 0; count<numberOfOptions;count++){

cout<<options[count]<<"\n";

}

cout<< answer << "\n";

}



int getValue() //gets the point value of the question

{

return value;

}



string getQuestionType()// gets the type of question

{

return questiontype;

}



string getAnswer()// prints the answer

{

return answer;

}

private:

int numberOfOptions;

string question, answer;

string options[6];

string questiontype;

int value;

};



class Exam

{

public:

int loadExam()

{

//ifstream infile;

//string examName = exam;

ifstream infile("exam.txt");

streambuf *cinbuf = cin.rdbuf();       //save old buf

cin.rdbuf(infile.rdbuf());             //redirect std::cin to infile.txt!



string line, theQuestion, questiontype, theAnswer;

int  questionvalue;



//get the number of questions from the first line in the file

getline(cin,line);

numquestions = atoi(line.c_str());

for(int count = 0; count<numquestions;count++){

getline(cin,line);

//get the next line with the question type and the value of the question

int npos = line.size();

int prev_pos = 0;

int pos = 0;

while( line[pos]!=' ')

pos++;

questiontype = line.substr(prev_pos, pos-prev_pos);

prev_pos = ++pos;

questionvalue = atoi(line.substr(prev_pos, npos-prev_pos).c_str()); // Last word



//process a true/false question

if (questiontype == "TF")

{

myQuestions[count] = new QuestionTF;

getline(cin,theQuestion);

myQuestions[count]->setQuestion(theQuestion,questionvalue);

}

//process a multiple choice question

if (questiontype =="MC")

{

myQuestions[count] =new QuestionMC;

getline(cin,theQuestion);

myQuestions[count]->setQuestion(theQuestion,questionvalue);

}



}

cin.rdbuf(cinbuf);   //restore cin to standard input

return numquestions;

}



void displayExamQuestions(int numquestions)

{

string qtype;

//print out the questions that have been processed

for(int count = 0; count<numquestions;count++)

{

qtype=myQuestions[count]->getQuestionType();

cout<<qtype<<" "<<myQuestions[count]->getValue()<<"\n";

myQuestions[count]->printOptions();

cout<<"\n";

}

}





private:



Question *myQuestions[10];

int numquestions;

};



int displayMenu();   //function prototype







int main() {



Exam myExam;

int numquestions, choice;

string examName = "exam.txt";
string outputfilename;
string choice2;





while((choice = displayMenu())!=3)

switch(choice)

{

case 1: numquestions = myExam.loadExam();
if (choice = 1){

cout<<"Which exam file would you like to load?\n";
cin>>choice2;


}


break;

case 2: myExam.displayExamQuestions(numquestions);

break;

default: cout<<"Invalid choice.  Try again.\n";

}



getchar();

return 0;

}



int displayMenu()

{

int choice;



cout<< "Enter your choice for this Exam."<<endl;

cout<< "1.   Load Exam "<<endl;

cout<< "2.   Display Exam "<<endl;

cout<< "3.   Quit"<<endl;

cin>>choice;

return choice;


cin.ignore();

}

[dkg123]

Also, sorry about the wack indentations....this is sample code.

Thanks again everyone.

[jlb]

Please fix the "wack indentations" and remove most of those "wack double spacing".

Part of your problems should be much easier to identify if you properly use some indentation style (no indentation is not a style).

You seem to be missing at least one closing brace, proper indentation should help identify where.

Also in future when you have " mad errors....." post the errors, all of them, exactly as they appear in your development environment. These messages should tell you exactly where to start looking for the errors and should even tell you what the errors actually are.

It looks like you tried to write the program in one big chunk instead of compiling early and often, usually after as little as one change/addition to the code.