SFML my move function is not working correctly

[Utku]

In my SFML application, my own move function does not work properly. If I write the move function's code directly to the main function, it works correctly.

My aim is:

https://i.stack.imgur.com/TGaQC.jpg

This happens if I write the code directly in main function, but it does not work if I write the code in a function. The output if I write in a function:

https://i.stack.imgur.com/fzNXJ.jpg

My class and functions:

#include <SFML/Window.hpp>
#include <SFML/Graphics.hpp>
#include <iostream>

#define WIDTH 1200
#define HEIGHT 1200

  typedef enum
{
	VEHICLE1,
	VEHICLE2,
	VEHICLE3,
	VEHICLE4,
	VEHICLE5,
	VEHICLE6
} tVehicleType;

sf::RenderWindow renderWindow(sf::VideoMode(WIDTH, HEIGHT), "Traffic Simulator");

class Vehicle
{
    float x;
    float y;
    float angle;
    bool origin_set;
	sf::Texture texture; //vehicle texture object
    sf::Sprite sprite; //vehicle sprite object
	tVehicleType myVehicleType;
	
	
public:
	//Constructor for the Vehicle class:
	// t: Vehicle type
	// corx coordinate of the current vehicle position
	// cory coordinate of the current vehicle position
	// angle: vehicle heading angle, i.e., orientation
    Vehicle(tVehicleType, float, float, float, sf::Sprite &, sf::Texture &);
	
	// Moves the vehicle and draws it to screen at the new location:
	// x: x coordinate to move the vehicle to
	// y: y coordinate to move the vehicle to
	// angle: new vehicle heading angle after the move
	void move(int, int, float &, float &, sf::Sprite &);
};

Vehicle::Vehicle(tVehicleType vehicleType, float initx, float inity, float initAngle, sf::Sprite &mySprite, sf::Texture &myTexture)
{
	this->myVehicleType = vehicleType;
	this->x = initx;
	this->y = inity;
	this->angle = initAngle;
	this->sprite = mySprite;
	this->texture = myTexture;
	
	// Load the file, "." states the project directory with custom working directory
	if (!myTexture.loadFromFile("./images/vehicles/car" + std::to_string(myVehicleType + 1) + ".png", sf::IntRect(0, 0, 64, 32)))
	{
		std::cout << "Could not load the vehicle image file" << std::endl;
    }
    
    mySprite.setTexture(myTexture);
}

void Vehicle::move(int increment, int increment2, float &x, float &y, sf::Sprite &mySprite)
{
    x += increment;
    y += increment2;
	
    if(x == 150 && y == 150)
    {
	mySprite.setRotation(0);
	increment = 1;
	increment2 = 0;
    }
	
    else if((x == 239*2 + 90) && y == 150)
    {
	mySprite.setRotation(90);
	increment = 0;
	increment2 = 1;
    }
	
    else if((x == 239*2 + 90) && y == 239*2 + 150)
    {
	mySprite.setRotation(0);
	increment = 1;
	increment2 = 0;
    }
	
    else if((x == 239*4 + 90) && y == 239*2 + 150)
    {
	mySprite.setRotation(90);
	increment = 0;
	increment2 = 1;
    }
	
    else if((x == 239*4 + 90) && y == 239*4 + 90)
    {
	mySprite.setRotation(180);
	increment = -1;
	increment2 = 0;
    }
	
    else if((x == 150) && y == 239*4 + 90)
    {
	mySprite.setRotation(270);
	increment = 0;
	increment2 = -1;
    }
	
}

And, this is my main function:

int main()
{
	float x = 150.f;
	float y = 150.f;
	float angle = 0.f;
	int increment = 1;
	int increment2 = 0;
	
	tVehicleType myVehicleType = VEHICLE5;
	
	sf::Sprite mySprite;
	sf::Texture myTexture;
	
	Vehicle *myVehicle;
	
	myVehicle = new Vehicle(myVehicleType, x, y, angle, mySprite, myTexture);
	
	sf::FloatRect boundingBox = mySprite.getGlobalBounds();
	mySprite.setOrigin(sf::Vector2f(boundingBox.width / 2, boundingBox.height / 2));
	
	while (renderWindow.isOpen())
	{
		sf::Event event;

		while(renderWindow.pollEvent(event))
		{
			if (event.type == sf::Event::Closed)
                 renderWindow.close();
		}
		
		mySprite.setPosition(x, y);
		
		renderWindow.clear(sf::Color::White);
		
		myVehicle->move(increment, increment2, x, y, mySprite);
		
		renderWindow.draw(mySprite);
		renderWindow.display();
		
		sf::sleep(sf::seconds(0.01f));
	}
	
	return 0;
}

[coder777]

The problem in Vehicle::move(int increment, int increment2, ...) is that increment/increment2 are passed as copies. I. e. changing them inside move() will have no effect outside of the function.

[Utku]

@coder777 Thank you for your reply. I change my function according to your comment:

void Vehicle::move(int &increment, int &increment2, float &x, float &y, sf::Sprite &mySprite)

I write increment/increment2 as reference. So, they are passed as reference.

Thank you very much again!