stacking issue in a game

[adam2016]

Hey guys,

sorry about the second question in the space of 30 minutes,I'm pretty bored so I decided to mess around and try create a kind of connect four kind of game with SDL,anyway I seem to have a bug that I can't get to the bottom off,

basically after the 5th ball I would like the balls to keep and stacking up but after 5 the next one comes down and disappears through the top one

here is what I'm talking about - https://youtu.be/-GvFJ5xHuAg

would be cool if someone could point me in the right direction :)

thanks

#include <iostream>
#include <SDL2/SDL.h>
#include <SDL2/SDL_image.h>
#include <vector>

using namespace std;

const int WIDTH = 500;
const int HEIGHT = 500;
bool p1,p2;
SDL_Event event;
SDL_Renderer* renderer;
SDL_Window* window;
class Ball;
class BallTracker;
vector<Ball*> redBall;
vector<Ball*> blueBall;
//BallTracker tracker[6];

class BallTracker{

   public:

       int colNumber;
       int amountOfBalls;

       BallTracker(){

           amountOfBalls = 0;

       }
};

class Ball{

   public:
     SDL_Surface* surface;
     SDL_Texture*  texture;
     SDL_Rect destRct;
     int number;
     int colNumber;
     string color;

     Ball(){

        surface = IMG_Load("red.png");
        texture = SDL_CreateTextureFromSurface(renderer,surface);
        destRct.y = 20;
        destRct.h = 80;
        destRct.w = 80;
     }

     ~Ball(){

       SDL_DestroyTexture(texture);

     }

};




bool initGame(){

    if(SDL_Init(SDL_INIT_EVERYTHING) < 0){

        cout << "failed to init" << endl;
        return false;
    }
    if(IMG_Init(IMG_INIT_PNG) < 0){

        cout << "failed to init image" << endl;
        return false;
    }

    window = SDL_CreateWindow("C0nnect f0ur",SDL_WINDOWPOS_CENTERED,SDL_WINDOWPOS_CENTERED,WIDTH,HEIGHT,SDL_WINDOW_RESIZABLE);
    renderer = SDL_CreateRenderer(window,-1,0);
    SDL_SetRenderDrawColor(renderer,255,255,255,255);
    p1 = false;
    p2 = false;

}

void renderGame(){


   SDL_RenderClear(renderer);

   for(int i = 0; i < redBall.size(); i++){

      SDL_RenderCopy(renderer,redBall.at(i)->texture,NULL,&(redBall.at(i)->destRct));

   }

   SDL_RenderPresent(renderer);

}

void cleanUp(){

   SDL_DestroyRenderer(renderer);
   SDL_DestroyWindow(window);

}

Ball& createBall(){

     Ball* ball = new Ball;
     ball->color = "red";
     ball->number = 1;

     redBall.push_back(ball);

     return *ball;

}

bool collision(Ball& ball){

     if(ball.destRct.y + ball.destRct.h == HEIGHT){

        return true;
     }
     for(int i = 0; i < redBall.size(); i++){

         if((ball.destRct.y + ball.destRct.h ==  redBall.at(i)->destRct.y) && (ball.colNumber == redBall.at(i)->colNumber)){

            return true;
         }

     }

    return false;
}





void choosenCol(int col){

   Ball& ball = createBall();
   ball.destRct.x = 0;
   cout << "rb size" << redBall.size() << endl;

   switch(col){

   case 1:
       while(!collision(ball)){

          ball.colNumber = 1;
          ball.destRct.x = 0;
          ball.destRct.y++;
          // renderBallMoving(ball);
          renderGame();
          SDL_Delay(2);

       }
       break;
   case 2:
        while(!collision(ball)){

          ball.colNumber = 2;
          ball.destRct.x = 80;
          ball.destRct.y++;
          // renderBallMoving(ball);
          renderGame();
          SDL_Delay(2);

       }
        break;
   case 3:
        break;
   case 4:
        break;
   case 5:
        break;
   case 6:
        break;

   }
}


int SDL_main(int argc,char* argv[])
{

    bool quit = false;

    initGame();

    while(!quit){


        SDL_PollEvent(&event);
        if(event.type == SDL_KEYDOWN){

            switch(event.key.keysym.sym){

        case SDLK_1:
            cout << "ball being created in col 1" << endl;
            choosenCol(1);
            break;
        case SDLK_2:
            cout << "ball being created in col 1" << endl;
            choosenCol(2);
            break;

            }
        }

        renderGame();
    }

    cleanUp();
}

[tpb]

...

[adam2016]

hey tpb,

that was the plan but finding it hard to implement it with a GUI

[tpb]

...

[adam2016]

thanks Tpb :)

that code looks a lot more elegant and compact than mine,

just a question though which part of the code places the discs into the array? I noticed an int array but how does this correlate with the discs?

thanks

[tpb]

...

[adam2016]

that looks pretty good,only less than 150 lines of code,that is pretty compact compared to mine,

I took your advice and made a two dimensional board array,but instead of ints I used chars,if red was chosen the position/offset of the array would be an 'r' for player one or 'y' for player two,my game still looks bad lol but just doing this for fun only took a couple of hours altogether.Also not finished it yet either

https://youtu.be/FzDQvKYGnNw

[adam2016]

also tpb,please do not delete posts on here it is a selfish thing to do,your answers and code may help someone in the future.(to be honest not that I used it apart from the board idea)

thanks