Segmentation fault(core dumped)

[Ensei]

It is somewhat big for a post but it's a simple, linear logic.
It's probably n00b mistake, but I just have to know...
Thank you

#include <iostream>

#include <string>

#include <vector>

#include <fstream>

using namespace std;

class Consumidor
{
   public:
    static int numeroIdentificacao;
    int id;
    string tipoConsumidor;
    string nomeProprietario;
    string morada;
    string codigoPostal;
    vector <double> Consumos;
    Consumidor() : id(0) 
    {tipoConsumidor = ""; nomeProprietario = "";morada = "";codigoPostal = "";}
    Consumidor(string tipo, string nom, string morad, string codpost, vector <double> consum) : id(numeroIdentificacao)
     { tipoConsumidor = tipo; nomeProprietario = nom; morada = morad;           codigoPostal = codpost; Consumos = consum;  numeroIdentificacao++; }

     int getID() {return id;}

     string getTipo() {return tipoConsumidor;}

     string getNome() {return nomeProprietario;}

     string getMorada() {return morada;}

     string getPostal() {return codigoPostal;}

     double getConsumo(int i) {return Consumos.at(i-1);}

     double getConsumoTotal();

     void setID(int i) {id = i;}

     void setTipo(string t) {tipoConsumidor = t;}

     void setNome(string n) {nomeProprietario = n;}

     void setMorada(string m) {morada = m;}

     void setPostal(string p) {codigoPostal = p;}

     void setConsumo(int i, double c) {Consumos.at(i - 1) = c;}

     void fonteFile(string); 

	 void adicionarConsumidor(); 

	 void removerConsumidor(int); 

	 void removerConsumidor(string); 

	 virtual void imprim(); 

     void imprimUm(int);  

     void imprimUm(string); 

     void imprimTotal(ofstream &);	

     void imprimTotal(vector<Consumidor*> v);

     void imprimConsumos();

     virtual double Gastos();   

     vector <Consumidor*> consumi;

};

double Consumidor :: Gastos() 
{
double d; return d;
}



class Menus : public Consumidor

{

  public:

         Menus() : Consumidor() {};

         void MainMenu();

         void MiniMenu(int);

         void MiniMenu(string);

};   



class Empresa : public Consumidor

{

   public:

	string dono;



   public:

	Empresa(string tipo, string nom, string morad, string codpost, vector<double> consum, string don) :  Consumidor(tipo, nom, morad, codpost, consum)

                   {dono = don;}

    void setDono(string don)

    {dono = don;}

    string getDono()

    {return dono;}

};



class PequenaMedia : public Empresa//********************************************************

{

   public:

	float taxapm;



   public:

	PequenaMedia(string tipo, string nom, string morad, string codpost, vector<double> consum, string don, double taxa) : Empresa (tipo, nom, morad, codpost, consum, don)

                 { taxapm = taxa; }

	void setTaxaPM(float taxa)

	{taxapm = taxa;}

	double getTaxa()

	{ return taxapm;}

    void imprim();

    double  Gastos() {return getConsumoTotal() * taxapm;}

};



class Grande : public Empresa //********************************************************

{

  public:

	float taxagrande;



   public:

	Grande(string tipo, string nom, string morad, string codpost, vector<double> consum, string don, double taxa) : Empresa (tipo, nom, morad, codpost, consum, don)

              { taxagrande = taxa; }

    void setTaxaG(float taxa)

    {taxagrande = taxa;}   

    double getTaxa()

    { return taxagrande;}      

    void imprim();

    double  Gastos() {return getConsumoTotal()*taxagrande;}

};



class Particular : public Consumidor//********************************************************

{

   public:

    Particular (string tipo, string nome, string morada, string codpost, vector<double> gastos) : Consumidor (tipo, nome, morada, codpost, gastos)

    {}

};



class Comercial : public Particular //********************************************************

{

   public:

	float taxacomercial;



   public:

	Comercial(string tipo, string nom, string morad, string codpost, vector<double> consum, double taxa) : Particular(tipo, nom, morad, codpost, consum)

	{taxacomercial = taxa;}

	 void setTaxaCM(float taxa)

	 { taxacomercial = taxa; }

	 double getTaxa()

	 { return taxacomercial;}

	 void imprim();

     double  Gastos() {return getConsumoTotal() * taxacomercial;}

};





class Domestico: public Particular//********************************************************

{

   public:

	float taxadomestico;



   public:

	Domestico(string tipo, string nom, string morad, string codpost, vector<double> consum, double taxa) : Particular(tipo, nom, morad, codpost, consum)

	

    {taxadomestico = taxa;}

	void setTaxaDM(float taxa)

	{taxadomestico = taxa;}

	double getTaxa()

	{ return taxadomestico;}

    void imprim();

    double Gastos() {return getConsumoTotal() * taxadomestico;}

};

int Consumidor :: numeroIdentificacao = 1;

double Consumidor :: getConsumoTotal()
{

       double soma = 0;

       unsigned int i = 0;

       for(i = 0; i < Consumos.size(); i++)

       {

             soma += Consumos.at(i);

       }

       return soma;

}

void Consumidor :: fonteFile(string nome)

{

     ifstream file (nome.c_str()); 

     string tipo, name, morada, codpost, dono;

     vector <double> con;

     float taxa;

     char lixo;

     while(!file.eof())

     {

       getline(cin, tipo);

       if(tipo == "PD" || tipo == "PC")

        { 

          getline(file, name);

          getline(file, morada);

          getline(file, codpost);

          file >> con.at(0) >> con.at(1)>> con.at(2)>> con.at(3)>> con.at(4)>> con.at(5)>> con.at(6)>> con.at(7)>> con.at(8)>> con.at(9)>> con.at(10)>> con.at(11);

          file >> taxa;

          file >> lixo;

          if(tipo == "PD") 

             {

                   Domestico pd = Domestico(tipo, name, morada, codpost, con, taxa); 

                   consumi.push_back(&pd);

                   return;

             }

          else if(tipo == "PC") 

             { 

                   Comercial pc = Comercial(tipo, name, morada, codpost, con, taxa); 

                   consumi.push_back(&pc);

                   return;

             }

          }

       else if(tipo == "EMP" || tipo == "EG")

        { 

          getline(file, dono);

          getline(file, name);

          getline(file, morada);

          getline(file, codpost);

          cin >> con.at(0) >> con.at(1)>> con.at(2)>> con.at(3)>> con.at(4)>> con.at(5)>> con.at(6)>> con.at(7)>> con.at(8)>> con.at(9)>> con.at(10)>> con.at(11);

          file >> taxa;

          file >> lixo;

          if(tipo == "EG")  

          { 

                  Grande eg = Grande(tipo, name, morada, codpost, con, dono, taxa); 

                  consumi.push_back(&eg); 

                  return;

          }

          else if(tipo == "EMP") 

          {

                  PequenaMedia emp = PequenaMedia(tipo, name, morada, codpost, con, dono, taxa); 

                  consumi.push_back(&emp);

                  return;

          }

        }

     }     

} 

[kempofighter]

What debugger are you using? Where did the software stop running? The stack dump should tell you something.

[Ensei]

Im using Ubuntu Geany 0.16.

The exact problems I ran into was:
if I run a function to run the vector<Consumidor*>consumi using iterators to print (eg: (*it)->imprim(); return; ) it goes over that line

also if I try to acess the vector directly ( eg: consumi.at(i)->imprim(); ) it acuses segmentation fault

I can push_back() objects with no problem, but it fails to acess the vector to print it.

[kempofighter]

          if(tipo == "EG")  

          { 

                  Grande eg = Grande(tipo, name, morada, codpost, con, dono, taxa); 

                  consumi.push_back(&eg); 

                  return;

          } // at this point eg is destroyed and consumi has a bad pointer 

There is your problem. You are taking the address of temporary objects and then inserting them into a dynamic array. You can't do that. At the end of that code block your vector contains a dangling pointer to an object that has been destroyed automatically at the end of the block scope.

Based on what I saw there is no really simple solution. You have to rework the program and either use new to construct the objects or you will to make your classes copyable with the copy constructor and assignment operator so that you can copy the objects into the container. You could implement the clone pattern and clone the temporary objects so that you can push the pointer to the clone into the vector.

[Ensei]

Thanks, I think it's working as I want now

BTW, sorry for the double post, I was trying to post the rest of the code and somehow doubleposted.