Problems with Stacks.

[ScottyYDg]

The program I've written manages to print out a few, then spits out the Stack Empty error. I suppose I just need a second pair of eyes to tell me where I messed up.

#include <iostream>
#include <fstream>
#include <string>
using namespace std;
struct info 
{
	string name;
	double avg;
};

class stack {
private:
	int array[50];
	int top;
public:
	stack() {
		top = 0;
	}
	bool isempty() {
		if (top == 0)
			return true;
		else
			return false;
	}
	bool isfull() {
		if (top == 50)
			return true;
		else
			return false;
	}
	void push(int n) {
		if (!isfull()) {
			array[top] = n;
			top++;
		}
		else {
			cout << "Stack is Full" << endl;
		}
	}
	int pop() {
		if (!isempty()) {
			top = top - 1;
			return array[top];
		}
		else {
			cout << "Stack empty" << endl;
			return -1;
		}
	}

};

class PlayerInfo 
{
private:
	info list[100];
	stack st_high;
	stack st_low;
	int count;
public:
	PlayerInfo() { count = 0; }
	void AddPlayer(string name, double batAvg) 
	{
		list[count].name = name;
		list[count].avg = batAvg;
		count++;
	}
	void printHigh()
	{
		double max;
		max = list[0].avg;

		for (int i = 0; i < count; i++) {
			if (list[i].avg > max)
				max = list[i].avg;
		}
		for (int i = 0; i < count; i++) {
			if (list[i].avg == max)
				st_high.push(i);
		}
		while (!st_high.isempty()) {
			cout << list[st_high.pop()].name << "   " << list[st_high.pop()].avg << endl;
		}
	}
	void printLow() {

		double min;
		min = list[0].avg;

		for (int i = 0; i<count; i++) {
			if (list[i].avg < min)
				min = list[i].avg;
		}
		for (int i = 0; i<count; i++) {
			if (list[i].avg == min)
				st_low.push(i);
		}
		while (!st_low.isempty()) {
			cout << list[st_low.pop()].name << "   " << list[st_low.pop()].avg << endl;
		}
	}
};


int main() 
{
	PlayerInfo pl;
	ifstream infile;
	string name;
	double avg;

	infile.open("avgs.txt"); // Assuming the name of input file is "Input.txt"
	while (infile >> name >> avg) 
	{
		pl.AddPlayer(name, avg);
	}
	pl.printHigh();
	pl.printLow();
	infile.close();
	return 0;
}

Here's a link to avgs.txt: http://programming.msjc.edu/cppii/avgs.txt

[tpb]

Look more closely at this in the printHigh function:

		while (!st_high.isempty()) {
			cout << list[st_high.pop()].name << "   " << list[st_high.pop()].avg << endl;
		}

You're popping twice from the stack. You need to call pop only once, save the value and use it twice.

		while (!st_high.isempty()) {
			int i = st_high.pop();
			cout << list[i].name << "   " << list[i].avg << endl;
		}

Same problem in the printLow function.

[ScottyYDg]

Thank you very much!