I need assistance with my connect 4 game?

[hhjkkh10]

Whenever i input a letter as a column number my program goes crazy and starts printing out text again and again like its in an infinite loop. Would be awesome if someone could take a look at it for me. Thanks in advance :)

#include <iostream>
#include <string>
#include <time.h>
using namespace std;

char playerXorO; 
char verticalGrid[6][7];
int columnNumber; // 
int columnCount[8] = { 5, 5, 5, 5, 5, 5, 5, 5};
bool columnFull = true;
char XorO[2] = { 'X', 'O' };

void boardCreate() 
{
	for (int j = 0; j <= 5; j++) // gives every element in the verticalGrid array the value of a blank space
	{
		for (int i = 0; i <= 6; i++)
		{
			verticalGrid[j][i] = ' ';
		}
	}
}

void columnSelect()
{
	for (int i = 1; i <= 7; i++) {		// for loop allows the user to select and drop a disc into a column in the gird
		if (columnNumber == i)
		{
			if (isalpha(columnNumber))
			{
				columnFull = true;
			}
			if (columnCount[i] == -1)
			{
				cout << "Please select another column as this one is full!" << endl;
				columnFull = true;
			}
			if (columnFull == false)
			{
				verticalGrid[columnCount[i]][i - 1] = playerXorO;
				columnCount[i]--;
			}
		}
	}
}

void columnPrint()
{
	if (columnFull == false) {				// prints out the gameboard
		for (int j = 0; j <= 5; j++)
		{
			cout << "+--+--+--+--+--+--+--+" << endl;

			for (int i = 0; i <= 6; i++)
			{
				cout << "| " << verticalGrid[j][i];
			}
			cout << "|" << endl;
		}
		cout << "+--+--+--+--+--+--+--+" << endl;
	}

}

int main()
{
	
	string inputStart;
	string name1, name2, name; 
	
	int turn = 0;
	bool winFlag1 = false;
	int winFlagCount = 0, winFlagCount1 = 0, winFlagCount2 = 0, winFlagCount3 = 0;
	bool gameLoop = true;
	
	// prints out the text that tells the user about connect 4 and the rules
		cout << "Welcome to connect 4!" << endl;
		cout << "Connect 4 is a two player board game where there are discs that consist of the letter X or the letter O," << endl;
		cout << "the aim of the game is to match 4 discs of the same letter diagonally, vertically or horizontally.\nYou drop discs in a 7x6 board." << endl;
		cout << "1) Each player must have one turn each time." << endl;
		cout << "2) Once you select a column you cannot change your mind." << endl;

	while (gameLoop == true) {
		cout << "Please type in start to start the game!" << endl; // tells the user to type in start
		cin >> inputStart;

		if (inputStart == "start" || inputStart == "START")
		{
			gameLoop = false;
			
			boardCreate(); // calling the function that creates the board



			cout << "Please enter player 1's name." << endl; // collects the data for player 1 and 2's name
			cin >> name1;
			cout << "Please enter player 2's name." << endl;
			cin >> name2;

			cout << name1 << " goes first!" << endl;

			while (turn < 42 && winFlag1 == false)
			{
				winFlagCount = 0;
				winFlagCount1 = 0;
				winFlagCount2 = 0;
				winFlagCount3 = 0;
				columnFull = false;
				if (turn % 2 == 0) // selection sequence allows the players to switch turns
				{
					name = name1;
					cout << name1 << ", please select the column number you would like to drop your disc from!" << endl;
					playerXorO = 'X';
				}
				else
				{
					name = name2;
					cout << name2 << ", please select the column number you would like to drop your disc from!" << endl;
					playerXorO = 'O';
				}


				cin >> columnNumber;

				if (columnNumber <= 0 || columnNumber >= 8) //if statement makes sure the user doesnt input an invalid column number
				{
					columnFull = true;
					cout << "That is an invalid column! Please pick a column from 1-7." << endl;
				}

				columnSelect(); // calling the function that allows discs to drop into the grid

				columnPrint(); // calling the function that prints out the game board



				if (columnFull == false)
				{
					turn++;
				}

				//this for loop checks to see if the user has won diagonally
				for (int j = 0; j < 4; ++j)
				{
					for (int i = 5; i > 2; --i)
					{
						if (verticalGrid[j][i] == playerXorO)
						{
							winFlagCount++;
							if (verticalGrid[j + 1][i - 1] == playerXorO)
							{
								winFlagCount++;
								if (verticalGrid[j + 2][i - 2] == playerXorO)
								{
									winFlagCount++;
									if (verticalGrid[j + 3][i - 3] == playerXorO)
									{
										winFlagCount++;

										if (winFlagCount == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				//another loop that checks the other diagonal direction
				for (int j = 0; j < 4; ++j)
				{
					for (int i = 5; i > 2; --i)
					{
						if (verticalGrid[j][i - 3] == playerXorO)
						{
							winFlagCount1++;
							if (verticalGrid[j + 1][i - 2] == playerXorO)
							{
								winFlagCount1++;
								if (verticalGrid[j + 2][i - 1] == playerXorO)
								{
									winFlagCount1++;
									if (verticalGrid[j + 3][i] == playerXorO)
									{
										winFlagCount1++;

										if (winFlagCount1 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				
				//this for loop checks to see if the user has won vertically
				for (int numColumn = 0; numColumn < 7; ++numColumn)
				{
					for (int check = 5; check > 2; --check)
					{
						if (verticalGrid[numColumn][check] == playerXorO)
						{
							winFlagCount2++;
							if (verticalGrid[numColumn][check - 1] == playerXorO)
							{
								winFlagCount2++;
								if (verticalGrid[numColumn][check - 2] == playerXorO)
								{
									winFlagCount2++;
									if (verticalGrid[numColumn][check - 3] == playerXorO)
									{
										winFlagCount2++;

										if (winFlagCount2 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}

				//this for loop checks to see if the user has won horizontally
				for (int numRow = 0; numRow < 6; ++numRow)
				{
					for (int check1 = 6; check1 > 2; --check1)
					{
						if (verticalGrid[check1][numRow] == playerXorO)
						{
							winFlagCount3++;
							if (verticalGrid[check1 - 1][numRow] == playerXorO)
							{
								winFlagCount3++;
								if (verticalGrid[check1 - 2][numRow] == playerXorO)
								{
									winFlagCount3++;
									if (verticalGrid[check1 - 3][numRow] == playerXorO)
									{
										winFlagCount3++;
										if (winFlagCount3 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				

				// these 2 if statements end the game as when turn = 45 the while loop doesn't run anymore
				if (winFlag1 == true)
				{
					turn = 45;
				}

				if (turn == 42)
				{
					cout << "The game has ended in a draw!" << endl;
					turn = 45;
				}



			}

		}
		else
		{

		}
	}
			
	return 1;
}

[TheIdeasMan]

Hi,

Your columnNumber is of type int, so if you type in an alphabetical char, it will be equivalent to the ascii code of that char.

Some other problems:

You need to make more use of functions: there is too much code in main. Your comments describe quite well what should be in a function.

Avoid global variables, they will bite you in ass one day :+)

You can use for loops instead of all those nested if statements.

Good Luck !!

[TheIdeasMan]

Please don't start a new topic about the same subject, just keep the same one going. It's a time waster for us, because people wind up making the same comments on both topics.

http://www.cplusplus.com/forum/general/215125/

[SamuelAdams]

There are multiple ways, but here is one.

#include <iostream>
#include <string>
#include <time.h>
using namespace std;

char playerXorO; 
char verticalGrid[6][7];
char columnNumberX; // 
int columnNumber; // 
int columnCount[8] = { 5, 5, 5, 5, 5, 5, 5, 5};
bool columnFull = true;
char XorO[2] = { 'X', 'O' };

void boardCreate() 
{
	for (int j = 0; j <= 5; j++) // gives every element in the verticalGrid array the value of a blank space
	{
		for (int i = 0; i <= 6; i++)
		{
			verticalGrid[j][i] = ' ';
		}
	}
}

void columnSelect()
{
	for (int i = 1; i <= 7; i++) {		// for loop allows the user to select and drop a disc into a column in the gird
		if (columnNumber == i)
		{
			if (isalpha(columnNumber))
			{
				columnFull = true;
			}
			if (columnCount[i] == -1)
			{
				cout << "Please select another column as this one is full!" << endl;
				columnFull = true;
			}
			if (columnFull == false)
			{
				verticalGrid[columnCount[i]][i - 1] = playerXorO;
				columnCount[i]--;
			}
		}
	}
}

void columnPrint()
{
	if (columnFull == false) {				// prints out the gameboard
		for (int j = 0; j <= 5; j++)
		{
			cout << "+--+--+--+--+--+--+--+" << endl;

			for (int i = 0; i <= 6; i++)
			{
				cout << "| " << verticalGrid[j][i];
			}
			cout << "|" << endl;
		}
		cout << "+--+--+--+--+--+--+--+" << endl;
	}

}

int main()
{
	
	string inputStart;
	string name1, name2, name; 
	
	int turn = 0;
	bool winFlag1 = false;
	int winFlagCount = 0, winFlagCount1 = 0, winFlagCount2 = 0, winFlagCount3 = 0;
	bool gameLoop = true;
	
	// prints out the text that tells the user about connect 4 and the rules
		cout << "Welcome to connect 4!" << endl;
		cout << "Connect 4 is a two player board game where there are discs that consist of the letter X or the letter O," << endl;
		cout << "the aim of the game is to match 4 discs of the same letter diagonally, vertically or horizontally.\nYou drop discs in a 7x6 board." << endl;
		cout << "1) Each player must have one turn each time." << endl;
		cout << "2) Once you select a column you cannot change your mind." << endl;

	while (gameLoop == true) {
		cout << "Please type in start to start the game!" << endl; // tells the user to type in start
		cin >> inputStart;

		if (inputStart == "start" || inputStart == "START")
		{
			gameLoop = false;
			
			boardCreate(); // calling the function that creates the board



			cout << "Please enter player 1's name." << endl; // collects the data for player 1 and 2's name
			cin >> name1;
			cout << "Please enter player 2's name." << endl;
			cin >> name2;

			cout << name1 << " goes first!" << endl;

			while (turn < 42 && winFlag1 == false)
			{
				winFlagCount = 0;
				winFlagCount1 = 0;
				winFlagCount2 = 0;
				winFlagCount3 = 0;
				columnFull = false;
				if (turn % 2 == 0) // selection sequence allows the players to switch turns
				{
					name = name1;
					cout << name1 << ", please select the column number you would like to drop your disc from!" << endl;
					playerXorO = 'X';
				}
				else
				{
					name = name2;
					cout << name2 << ", please select the column number you would like to drop your disc from!" << endl;
					playerXorO = 'O';
				}

				cin >> columnNumberX;
				if ( (columnNumberX=='1') || (columnNumberX=='2') || (columnNumberX=='3') || (columnNumberX=='4') || (columnNumberX=='5') || (columnNumberX=='6') || (columnNumberX=='7') )
				{
				columnNumber=columnNumberX- 48;
				}
				else
				{
					columnFull = true;
					cout << "That is an invalid column! Please pick a column from 1-7." << endl;
				}

				columnSelect(); // calling the function that allows discs to drop into the grid

				columnPrint(); // calling the function that prints out the game board



				if (columnFull == false)
				{
					turn++;
				}

				//this for loop checks to see if the user has won diagonally
				for (int j = 0; j < 4; ++j)
				{
					for (int i = 5; i > 2; --i)
					{
						if (verticalGrid[j][i] == playerXorO)
						{
							winFlagCount++;
							if (verticalGrid[j + 1][i - 1] == playerXorO)
							{
								winFlagCount++;
								if (verticalGrid[j + 2][i - 2] == playerXorO)
								{
									winFlagCount++;
									if (verticalGrid[j + 3][i - 3] == playerXorO)
									{
										winFlagCount++;

										if (winFlagCount == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				//another loop that checks the other diagonal direction
				for (int j = 0; j < 4; ++j)
				{
					for (int i = 5; i > 2; --i)
					{
						if (verticalGrid[j][i - 3] == playerXorO)
						{
							winFlagCount1++;
							if (verticalGrid[j + 1][i - 2] == playerXorO)
							{
								winFlagCount1++;
								if (verticalGrid[j + 2][i - 1] == playerXorO)
								{
									winFlagCount1++;
									if (verticalGrid[j + 3][i] == playerXorO)
									{
										winFlagCount1++;

										if (winFlagCount1 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				
				//this for loop checks to see if the user has won vertically
				for (int numColumn = 0; numColumn < 7; ++numColumn)
				{
					for (int check = 5; check > 2; --check)
					{
						if (verticalGrid[numColumn][check] == playerXorO)
						{
							winFlagCount2++;
							if (verticalGrid[numColumn][check - 1] == playerXorO)
							{
								winFlagCount2++;
								if (verticalGrid[numColumn][check - 2] == playerXorO)
								{
									winFlagCount2++;
									if (verticalGrid[numColumn][check - 3] == playerXorO)
									{
										winFlagCount2++;

										if (winFlagCount2 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}

				//this for loop checks to see if the user has won horizontally
				for (int numRow = 0; numRow < 6; ++numRow)
				{
					for (int check1 = 6; check1 > 2; --check1)
					{
						if (verticalGrid[check1][numRow] == playerXorO)
						{
							winFlagCount3++;
							if (verticalGrid[check1 - 1][numRow] == playerXorO)
							{
								winFlagCount3++;
								if (verticalGrid[check1 - 2][numRow] == playerXorO)
								{
									winFlagCount3++;
									if (verticalGrid[check1 - 3][numRow] == playerXorO)
									{
										winFlagCount3++;
										if (winFlagCount3 == 4) {
											cout << name << " wins congratulations!" << endl;
											winFlag1 = true;
											break;
										}
									}
								}
							}
						}
					}
				}
				

				// these 2 if statements end the game as when turn = 45 the while loop doesn't run anymore
				if (winFlag1 == true)
				{
					turn = 45;
				}

				if (turn == 42)
				{
					cout << "The game has ended in a draw!" << endl;
					turn = 45;
				}



			}

		}
		else
		{

		}
	}
			
	return 1;
}

[hhjkkh10]

Thanks for the tips and the code, i will defo check it out today thanks!

[hhjkkh10]

@SamuelAdams just thought i should tell you that there is a strange bug when the win condition doesnt work with your fix. It tends to only happen when there are a few turns left.

[SamuelAdams]

Basically this is what I added, and a few other lines to make this work.
It was added so that you wouldn't have that endless loop if they entered a char.
The only thing I can think of is that it checks to make sure it's a valid value.
It does not check if the column is full or anything else.

				cin >> columnNumberX;
				if ( (columnNumberX=='1') || (columnNumberX=='2') || (columnNumberX=='3') || (columnNumberX=='4') || (columnNumberX=='5') || (columnNumberX=='6') || (columnNumberX=='7') )
				{
				columnNumber=columnNumberX- 48;
				}

[TheIdeasMan]

Why don't you make the Column a char instead?

@SamuelAdams solution is some thing to be avoided, IMO

There is a lot that need to be fixed up here, some of it was detailed in the other topic:

http://www.cplusplus.com/forum/general/215125/

@OP

See how time is being wasted here with this duplicate topic?