Infile, Outfile help!

[vinci65812301]

heyya guys i seem to be having a problem, hopefully someone can point it out, my outfile only prints out one line of results so not sure what the error is.

[vinci65812301]

#include <iostream>
#include <fstream>
#include <ctime>
#include <cstdlib>
#include <iomanip>
#include <string>

using namespace std;

const int MAX = 100;

enum NumType {Odd, Even};

struct Number
{
int no;
NumType type;
int oddDigits;
int evenDigits;
int sumDigits;
int noDigits;
};

void arrayToOutfile (ofstream&, char [], Number [], int);
void constructInfile (fstream&, char []);
int constructArray (fstream&, char [], Number []);
void processArray (Number [], int);
NumType whatType (int);
void getStringLabel (NumType, char []);

int main ()
{
srand (time_t(NULL));
fstream inFile;
char fileName [MAX];
//int size = rand() % 100;

cout << "Enter filename: ";
cin >> fileName;

constructInfile (inFile, fileName);

cout << "----------------------------------------" << endl;

Number n [MAX];

int size = constructArray(inFile, fileName, n);
cout << "Elements in Array = " << size << "\n\n";

processArray (n, size);

cout << "----------------------------------------" << endl;

ofstream outFile;

cout << "Enter the output filename: ";
cin >> fileName;

arrayToOutfile (outFile, fileName, n, size);
}



void constructInfile (fstream& inFile, char fileName[])
{
inFile.open (fileName, ios::out);

if (!inFile)
{
cout << fileName << " cant be created for write"
<< endl;

exit (-1);
}

int size = rand() % 100;

for (int i = 0; i < size; i++)
{
inFile << rand() << "\t"
<< "// Number" << i << endl;
}

cout << "written to outfile successfully" << endl;

inFile.close();

}

int constructArray (fstream& inFile, char fileName[], Number n[])
{
inFile.open (fileName, ios::in);

if (!inFile)
{
cout << fileName << " cant be accessed for array creation."
<< endl;
exit (-1);
}
cout << "Begin file to array" << endl;
int i = 0;
while (inFile >> n[i].no)
{
++i;
}

inFile.close();
cout << "File to array transfer success" << endl;

return i;

}

void processArray (Number n [], int size)
{

cout << "Begin processing array" << endl;

//Odd or Even
for (int i = 0; i < size; i++)
{
n[i].type = whatType (n[i].no);
}


//copy number n array to temp n array
Number t [MAX];

for (int i = 0; i < size; i++)
{
t[i].no = n[i].no;
}

for (int i = 0; i <size; i++)
{
n[i].evenDigits = 0;
n[i].oddDigits = 0;
}

//odd and even function

int countEven;
int countOdd;

for (int i = 0; i < size; i++)
{
countEven = 0;
countOdd = 0;
while (t[i].no > 0)
{
if (t[i].no % 2 == 1)
{
countOdd++;
t[i].no/= 10;
}
else
{
countEven++;
t[i].no/=10;
}
n[i].oddDigits = countOdd;
n[i].evenDigits = countEven;
}

}

//copy number n array to temp n array again.
for (int i = 0; i < size; i++)
{
t[i].no = n[i].no;
}


for (int i = 0; i <size; i++)
{
n[i].sumDigits = 0;
}

for (int i = 0; i < size;)
{
while (t[i].no > 0)
{
n[i].sumDigits = n[i].sumDigits + t[i].no % 10;
t[i].no /= 10;
}i++;
}

//copy number n array to temp n array again.
for (int i = 0; i < size; i++)
{
t[i].no = n[i].no;
}
//SET TO DEFAULT 0 for COUNT DIGITS
for (int i = 0; i <size; i++)
{
n[i].noDigits = 0;
}

//DIGIT COUNT
for ( int i = 0; i < size; i++)
{
int countDigits = 0;

while (t[i].no != 0)
{
t[i].no /= 10;
countDigits++;
}
n[i].noDigits = countDigits;
}


//for (int i = 0; i < size; i++)
//{

//}

cout << "The array was processed" << endl;
}

//Number type.
NumType whatType (int n)
{

if (n % 10 % 2 == 1)
return Odd;
else
return Even;
}

//Array to Outfile.
void arrayToOutfile (ofstream& outFile, char fileName[], Number n[], int size)
{
outFile.open (fileName);

outFile << "No" << "\t"
<< "Type" << "\t"
<< "Odd" << "\t"
<< "Even" << "\t"
<< "Sum" << "\t"
<< "Digit"
<< endl;

while (!outFile)
{
cout << "Array to " << fileName << " failed" << endl;
outFile.close ();
}

cout << "Begin from array to " << fileName << endl;

cout << fixed << showpoint << setprecision (3);

char label [MAX];

for (int i = 0; i < size; i++)
{
outFile << n [i].no << "\t";

NumType whatType (int n);

getStringLabel (n[i].type, label);

outFile << n[i].no << "\t"
<< label << "\t"
<< n[i].oddDigits << "\t"
<< n[i].evenDigits << "\t"
<< n[i].sumDigits << "\t"
<< n[i].noDigits << "\t"
<< endl;
}


outFile.close();

cout << "Array to outfile OK" << endl;
}

//String label
void getStringLabel (NumType type, char label[])
{

switch (type)
{
case Odd: strcpy (label, "Odd");
break;
case Even: strcpy (label, "Even");
break;
default: strcpy (label, "err");
}
}

[boost lexical cast]

Why don't you indent your code?

And then put then put your code in like this:

[.code.]
Your code here...
[./code.]

Remove the periods (.)
I put them there so it wouldn't actually format my post as code.

[vinci65812301]

[/output]
#include <iostream>
#include <fstream>
#include <ctime>
#include <cstdlib>
#include <iomanip>
#include <string>

using namespace std;

const int MAX = 100;

enum NumType {Odd, Even};

struct Number
{
    int no;
    NumType type;
    int oddDigits;
    int evenDigits;
    int sumDigits;
    int noDigits;
};

void arrayToOutfile (ofstream&, char [], Number [], int);
void constructInfile (fstream&, char []);
int constructArray (fstream&, char [], Number []);
void processArray (Number [], int);
NumType whatType (int);
void getStringLabel (NumType, char []);

int main ()
{
    srand (time_t(NULL));
    fstream inFile;
    char fileName [MAX];
	//int size = rand() % 100;

    cout << "Enter filename: ";
    cin >> fileName;

    constructInfile (inFile, fileName);

    cout << "----------------------------------------" << endl;

    Number n [MAX];

    int size = constructArray(inFile, fileName, n);
	cout << "Elements in Array = " << size << "\n\n";

    processArray (n, size);

    cout << "----------------------------------------" << endl;

    ofstream outFile;

    cout << "Enter the output filename: ";
    cin >> fileName;

    arrayToOutfile (outFile, fileName, n, size);
}



void constructInfile (fstream& inFile, char fileName[])
{
    inFile.open (fileName, ios::out);

    if (!inFile)
    {
        cout << fileName << " cant be created for write"
        << endl;

        exit (-1);
    }

    int size = rand() % 100;
    
	for (int i = 0; i < size; i++)
	{
		inFile << rand() << "\t"
		<< "// Number" << i << endl;
	}

    cout << "written to outfile successfully" << endl;

    inFile.close();

}

int constructArray (fstream& inFile, char fileName[], Number n[])
{
    inFile.open (fileName, ios::in);

    if (!inFile)
    {
        cout << fileName << " cant be accessed for array creation."
        << endl;
        exit (-1);
    }
    cout << "Begin file to array" << endl;
    int i = 0;
    while (inFile >> n[i].no)
    {
        ++i;
    }

    inFile.close();
    cout << "File to array transfer success" << endl;

    return i;

}

void processArray (Number n [], int size)
{

    cout << "Begin processing array" << endl;
    
	//Odd or Even 
    for (int i = 0; i < size; i++)
    {
        n[i].type = whatType (n[i].no);
    }


//copy number n array to temp n array
    Number t [MAX];

    for (int i = 0; i < size; i++)
    {
        t[i].no = n[i].no;
    }

    for (int i = 0; i <size; i++)
    {
        n[i].evenDigits = 0;
        n[i].oddDigits = 0;
    }

//odd and even function

    int countEven;
    int countOdd;

    for (int i = 0; i < size; i++)
    {
        countEven = 0;
        countOdd = 0;
        while (t[i].no > 0)
        {
            if (t[i].no % 2 == 1)
            {
                countOdd++;
                t[i].no/= 10;
            }
            else
            {
                countEven++;
                t[i].no/=10;
            }
            n[i].oddDigits = countOdd;
            n[i].evenDigits = countEven;
        }

    }

    //copy number n array to temp n array again.
    for (int i = 0; i < size; i++)
    {
        t[i].no = n[i].no;
    }

    
    for (int i = 0; i <size; i++)
    {
        n[i].sumDigits = 0;
    }

    for (int i = 0; i < size;)
    {
        while (t[i].no > 0)
        {
            n[i].sumDigits = n[i].sumDigits + t[i].no % 10;
            t[i].no /= 10;
        }i++;
    }

    //copy number n array to temp n array again.
    for (int i = 0; i < size; i++)
    {
        t[i].no = n[i].no;
    }
    //SET TO DEFAULT 0 for COUNT DIGITS
    for (int i = 0; i <size; i++)
    {
        n[i].noDigits = 0;
    }

    //DIGIT COUNT
    for ( int i = 0; i < size; i++)
    {
        int countDigits = 0;

        while (t[i].no != 0)
        {
            t[i].no /= 10;
            countDigits++;
        }
        n[i].noDigits = countDigits;
    }


    //for (int i = 0; i < size; i++)
    //{

    //}

    cout << "The array was processed" << endl;
}

//Number type.
NumType whatType (int n)
{

    if (n % 10 % 2 == 1)
        return Odd;
    else
        return Even;
}

//Array to Outfile.
void arrayToOutfile (ofstream& outFile, char fileName[], Number n[], int size)
{
    outFile.open (fileName);
	
	outFile << "No" << "\t"
    << "Type" << "\t"
    << "Odd" << "\t"
    << "Even" << "\t"
    << "Sum" << "\t"
    << "Digit"
    << endl;

    while (!outFile)
    {
        cout << "Array to " << fileName << " failed" << endl;
        outFile.close ();
    }

    cout << "Begin from array to " << fileName << endl;

    cout << fixed << showpoint << setprecision (3);

   char label [MAX];
   
	for (int i = 0; i < size; i++)
	 {	
	 	outFile << n [i].no << "\t";
	 
	 	NumType whatType (int n);
	 
        getStringLabel (n[i].type, label);

        outFile << n[i].no << "\t"
        << label << "\t"
        << n[i].oddDigits << "\t"
        << n[i].evenDigits << "\t"
        << n[i].sumDigits << "\t"
        << n[i].noDigits << "\t"
		<< endl;
    }

    
	outFile.close();

    cout << "Array to outfile OK" << endl;
}

//String label
void getStringLabel (NumType type, char label[])
{

        switch (type)
    {
        case Odd:   strcpy (label, "Odd");
            break;
        case Even:  strcpy (label, "Even");
            break;
        default:    strcpy (label, "err");
    }
}
[output]

[vinci65812301]

haha thxs was trying how to use tht....

[boost lexical cast]

vinci65812301 wrote:

heyya guys i seem to be having a problem, hopefully someone can point it out, my outfile only prints out one line of results so not sure what the error is.

Tell us what your code is supposed to do and where in your code (which line) the outfile prints out only 1 line.

[vinci65812301]

i think the prob lies on line 232 onwards theres no error and stuff in the compiler everything works, but the code is meant to print out multiple lines, so basically transfer the info from the infile to the outfile...

lemme knw if you need any info

[boost lexical cast]

On line 235:

outFile.open(fileName)

should be

outFile.open(fileName, ios::app)


This opens the file in append mode. If you don't open the file in append mode you don't append to the file and all exisiting data is overwritten. Keep in mind you still need to provide newlines if you want them.

[vinci65812301]

so this lets more lines to be in? originally it only allows one line? sorry first time seeing ios::app

[boost lexical cast]

It allows you to write to the file more than once. Without it every time you write to it everything that was in there before is "erased".

You can write more than one line into a file without ios::app but you have to do it all at once.

So, yes it does let more lines in even when you output to the file more than once.

File mode options:

ios::in Open for input operations.

ios::out Open for output operations.

ios::binary Open in binary mode.

ios::ate Set the initial position at the end of the file.
If this flag is not set, the initial position is the beginning of the file.

ios::app All output operations are performed at the end of the file, appending the content to the current content of the file.

ios::trunc If the file is opened for output operations and it already existed, its previous content is deleted and replaced by the new one.


class default mode parameter

ofstream ios::out
ifstream ios::in
fstream ios::in | ios::out

[vinci65812301]

ok ok thanks! so am i missing anything else? now it just shows two lines...but i need it to print out a list....sry for all the questions....really noob at this

[boost lexical cast]

Which line in your code prints out the list?

[vinci65812301]

same line 233 for the outfile....the infile works fine...infile is on line 65

[boost lexical cast]

vinci65812301 wrote:

ok ok thanks! so am i missing anything else? now it just shows two lines...but i need it to print out a list....sry for all the questions....really noob at this

Where does it "show"? On the screen with std::cout or in the file?

[vinci65812301]

as in where it prints out? in the .txt file

[boost lexical cast]

Are you trying to write "No\tType\tOdd\tEven\tSum\tDigit" to the file?

[vinci65812301]

i dont get your meaning....its alrdy in the file...like it shows up in the .txt

[boost lexical cast]

When you write to the outFile, you write "No\tType..." etc to it before you write to it from the inFile. This makes it so all the data from the inFile is after the "No\tType\tOdd...".

You need to first write "No\t" to the outFile, then the data from the inFile. After that "Type\t", then data from inFile and so on.

[boost lexical cast]

There's a lot of things in your code to be fixed (it's large so hard to tell) and it's getting late. Hopefully, you get help from someone else.

[vinci65812301]

so its smth like

outfile << "No" << "\t" << n[i].no << "\t" ?