Binary Search Tree Copy constructor crashing

[timk123]

Hello guys,

after copy constructor is done, console crashes... Any idea?

template <class bstitem>
class BinarySearchTree
{
    private:
        struct Node
        {
                bstitem data;
                Node* left;
                Node* right;
                Node(bstitem newdata): data(newdata), left(NULL), right(NULL) {}
        };

        typedef struct Node* NodePtr;
        NodePtr root;


        void copyConHelper(NodePtr root, NodePtr origin);


    public:

        BinarySearchTree();
        //Instantiates a new Binary Search Tree
        //post: a new Binary Search Tree object

        ~BinarySearchTree();
        //destructor

        BinarySearchTree(const BinarySearchTree &BinarySearchTree);
};


template <class bstitem>
BinarySearchTree<bstitem>::BinarySearchTree(const BinarySearchTree &BST):root(BST.root)
{
	if(BST.root == NULL)
	{
		root = NULL;
	}
	else
	{
		copyConHelper(root, BST.root);
	}
}

template <class bstitem>
void BinarySearchTree<bstitem>::copyConHelper(NodePtr root, NodePtr origin)
{
	if (origin == NULL)
	{
		root = NULL;
	}
	else
	{
		root = new Node(origin->data);
		copyConHelper(root->left, origin->left);
		copyConHelper(root->right, origin->right);
	}

}

[cire]

I would imagine it's more likely when the destructor is called since your code only makes a shallow copy of the tree, so assuming you delete things in your destructor, the same pointer value would be fed to delete more than once (resulting in undefined behavior.)

Your copyConHelper does nothing. The only variables it modifies are local to the function itself.