Functions need help plz

[phone98]

This is what my code looks like

#include<iostream>
#include<fstream>
#include<iomanip>
#include<string>

using namespace std;

int sumList(const int[], int);
int indexOfMax(const int[], int);

void getElectionData(ifstream&, string[], int[], int& );
void printResults(const string[], const int[], int, int);
const int NUM_CANDIDATES = 10;

int main()
{
    ifstream inFile;
    string names[NUM_CANDIDATES];
    int votes[NUM_CANDIDATES];
    int totalVotes;
	int max;
    
    
    inFile.open("votingresults.txt");
    if (!inFile)
    {
        cout << "File not found!" << endl << endl;
        system("pause");
        return 1;
    }
    
    getElectionData(inFile, names, votes, max);
    totalVotes = sumList(votes ,max);
    printResults(names, votes, max, totalVotes);

    inFile.close();

	cout << max << endl << endl;
    return 0;
}

int sumList(const int list[], int size)
{
    int i, sum = 0;
    for(i = 0; i<size; i++)
    {
        sum = list[i] + sum;
    }
    return sum;
}

int indexOfMax(const int list[], int size)
{
    int i = 0;
	int maxIndex = 0;
	for(; i < size; i++)
	{
		if(list[i] > maxIndex)
		{
			maxIndex = list[i];
		}
	}
    return maxIndex;
}

void getElectionData(ifstream & iFile, string candidates[], int ballots[], int & count)
{
    int i = 0;
    while(iFile >> candidates[i] >> ballots[i])
    {
        i++;
		
    }
	count = i;
}

void printResults(const string candidates[], const int ballots[], int count, int totalBallots)
{
	int i = 0;
	int winner;

	cout << setw(15) << "Candidates" << setw(20) << "Num Votes" << setw(20) << "% of votes" << endl << endl;
	for(; i < 6; i++)
	{
		cout << setw(15) <<  candidates[i] << setw(20) << ballots[i] << setw(20) << totalBallots/count << endl;
	}

	winner = indexOfMax(ballots, count);
	cout << "The winner is: " << candidates[winner] << endl;

}

INCASE you need the file. its a .txt file and here is the info

ALVAREZ 8532
MORRISON 7176
HANSEN 6690
FERNANDEZ 9432
GARZA 8648
HARVEY 9330

Ok, so I was having problems with passing max in getElectionData function. but I think its fixed now... BUT now the program crashes :( i dont know what to do T_T please help

[starFish2]

With a few of changes, your code works.

#include<iostream>
#include<fstream>
#include<iomanip>
#include<string>

using namespace std;

int sumList(const int[], int);
int indexOfMax(const int[], int);

void getElectionData(ifstream&, string[], int[], int& );
void printResults(const string[], const int[], int, int);
const int NUM_CANDIDATES = 10;

int main()
{
    ifstream inFile;
    string names[NUM_CANDIDATES];
    int votes[NUM_CANDIDATES];
    int totalVotes;
	int max;
    
    
    inFile.open("votingresults.txt");
    if (!inFile)
    {
        cout << "File not found!" << endl << endl;
        system("pause");
        return 1;
    }
    
    getElectionData(inFile, names, votes, max);
    totalVotes = sumList(votes ,max);
    printResults(names, votes, max, totalVotes);

    inFile.close();

	cout << max << endl << endl;
    return 0;
}

int sumList(const int list[], int size)
{
    int i, sum = 0;
    for(i = 0; i<size; i++)
    {
        sum = list[i] + sum;
    }
    return sum;
}

int indexOfMax(const int list[], int size)
{
    int i = 0;
	int maxIndex = 0;
	int maxValue = 0;
	for(; i < size; i++)
	{
		if(list[i] > maxValue)
		{
			maxValue = list[i];
			maxIndex = i;
		}
	}
    return maxIndex;
}

void getElectionData(ifstream & iFile, string candidates[], int ballots[], int & count)
{
    int i = 0;
    while(iFile >> candidates[i] >> ballots[i])
    {
        i++;
		
    }
	count = i;
}

void printResults(const string candidates[], const int ballots[], int count, int totalBallots)
{
	int i = 0;
	int winner;

	cout << setw(15) << "Candidates" << setw(20) << "Num Votes" << setw(20) << "% of votes" << endl << endl;
	for(; i < 6; i++)
	{
		cout << setw(15) <<  candidates[i] << setw(20) << ballots[i] << setw(20) << totalBallots/count << endl;
	}

	winner = indexOfMax(ballots, count);
	cout << "The winner is: " << candidates[winner] << endl;

}

     Candidates           Num Votes          % of votes

        ALVAREZ                8532                8301
       MORRISON                7176                8301
         HANSEN                6690                8301
      FERNANDEZ                9432                8301
          GARZA                8648                8301
         HARVEY                9330                8301
The winner is: FERNANDEZ
6

[phone98]

I appreciate the help :-), so when comparing arrays like in this example

maxValue = list[i];

i'm comparing the array element right?

so can I treat array elements as single value?

I tend to get confused a lot with arrays T_T

[MikeyBoy]

so can I treat array elements as single value?

Sure. Each array element is a single value!

Although note that in:

maxValue = list[i];

you're not comparing anything - you're assigning a value to maxValue.