HELP with Structs and arrays

[AppleKidd]

I am new to structs and I am a bit confused. what I am trying to do is pass values from a txt file into a structure, and then passing the struct into an array.

The txt looks something like this 02 3 2004 Paul 4 1 22

Any help would be grateful

This is what I have so far.

#include <iostream>
#include <fstream>
#include <string>
using namespace std;
struct Date
{
	int day;
	int month;
	int year;
};

struct Weather
{
	Date date;
	char name[12];
	double sunShine;
	double rainFall;
	double midTemp;

};

int main()
{

	int list[30];
	int choice;
	char name[12];
	ifstream in("weather.txt");
	Weather c[30];
	Date d[30];
	for (int i = 0; i < 30; i++)
	{
		in >> c[i].name >> c[i].sunShine >> c[i].rainFall
			>> c[i].midTemp;
	}
	for (int i = 0; i < 30; i++)
	{
		in >> d[i].day >> d[i].month >> d[i].year;
	}

	if (in.is_open())
	{
		for (int i = 0; i < 30; i++)
		{
			in >> list[i];
		}
	}
	
	do
	{
		cout << "1) List the dates when a given meteorologist was on duty.\n";
		cout << "2) Find all the wet days.\n";
		cout << "3) Find all the sunny days.\n";
		cout << "4) Find the average rainfall between two dates.\n";
		cout << "5) Find the hottest day based on the midday temperature.\n";
		cout << "6) Find the day with the shortest sunshine.\n";
		cout << "7) Exit from the application.\n";

		cout << "Please select an option:\n";
		cin >> choice;

		 switch (choice)
		{
		 case 1:
			 for (int i = 0; i < 30; i++)
			 {
				 cout << list[i] << endl;
			 }

			break;
		case 2:
			break;
		case 3:
			break;
		case 4:
			break;
		case 5:
			break;
		case 6:
			break;
		case 7:
			break;
		default:
			break;
		}
			

	} while (choice != 7);
    return 0;
}

[shadder]

line 13 char name wont work, either use c-style strings char name[21] or proper strings string name

same goes for line 25

[AppleKidd]

That was meant to be like char name[12] . Its still only outputting 30 numbers.

[shadder]

What is your output and expected output?

also

case 1:
			 for (int i = 0; i < 30; i++)
			 {
				 cout << list[i] << endl;
			 }

what are you trying to achieve here?

[AppleKidd]

Case 1: was just testing. What i want to do is put the values from a txt file into a structure and then into an array.

[shadder]

and what output you are expecting from code? and what output you are getting?

[AppleKidd]

I am getting this 1) List the dates when a given meteorologist was on duty.
2) Find all the wet days.
3) Find all the sunny days.
4) Find the average rainfall between two dates.
5) Find the hottest day based on the midday temperature.
6) Find the day with the shortest sunshine.
7) Exit from the application.
Please select an option:
1
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
-858993460
1) List the dates when a given meteorologist was on duty.
2) Find all the wet days.
3) Find all the sunny days.
4) Find the average rainfall between two dates.
5) Find the hottest day based on the midday temperature.
6) Find the day with the shortest sunshine.
7) Exit from the application.
Please select an option:

My expected output is 30 outputs of different data

I am getting this 1) List the dates when a given meteorologist was on duty.
2) Find all the wet days.
3) Find all the sunny days.
4) Find the average rainfall between two dates.
5) Find the hottest day based on the midday temperature.
6) Find the day with the shortest sunshine.
7) Exit from the application.
Please select an option:
1
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
02 3 2004 Paul 4 1 22
1) List the dates when a given meteorologist was on duty.
2) Find all the wet days.
3) Find all the sunny days.
4) Find the average rainfall between two dates.
5) Find the hottest day based on the midday temperature.
6) Find the day with the shortest sunshine.
7) Exit from the application.
Please select an option:

[shadder]

if (in.is_open())
	{
		for (int i = 0; i < 30; i++)
		{
			in >> list[i];
		}
	}

what does this snippet of your code does?

[AppleKidd]

//Intaliazes the array as the data is stored in the weather.txt file
if (in.is_open())
	{
		for (int i = 0; i < 30; i++)
		{
			in >> list[i]; // The stored values 
		}
	}

That is what I think it does, I cant tell as the output is outputting just the 30 numbers.

[shadder]

where did you initialized the list[]?

[AppleKidd]

int main()
{

	int list[30]; // I initialized it here
	int choice;
	char name[12];
	ifstream in("weather.txt");
	Weather c[30];
	Date d[30];

[shadder]

int main()
{

	int list[30]; //This is called declaring
	int choice;
	char name[12];
	ifstream in("weather.txt");
	Weather c[30];
	Date d[30];

Since you didn't initialized the list to any values it just outputs garbage value

[AppleKidd]

Oh I always thought that was initializing, so how do I fix this.

[shadder]

Depends on what you want to do with list[], what does list[] stores?

[AppleKidd]

The list[] should store the data thats in the file. See the program is a menu. Read in data and when you press from 1-7 it will calculate something but my main goal at current is getting the data from the file into the the structs and from the struct into the array.

[shadder]

what exactly in data list[] should store? there are so many things

[AppleKidd]

What I was thinking the datalist[] should store the data thats in the txt. I'm I wrong saying this.

[Chervil]

The txt looks something like this 02 3 2004 Paul 4 1 22

I'm guessing that the input file has many lines which have that same format?

Then your program would need an array of Weather objects.
Which indeed you do have at line 29

    Weather c[30]; 

I see no reason for the other arrays,

int list[30];

and

Date d[30];

everything should be stored in that single array c. (A more meaningful name than a single letter for this most important part of the program might help with readability).