Alternative for GetValue

[ProgrammerXYZ]

What's an alternative for GetValue, or how would I identify it? It says identifier not found.

#include<iomanip>
#include<iostream>
#include<string>
using namespace std;

int Main()
{

	int num = 0;
	string ignoreNextChar = "false";

	string roman;
	cin >> roman;

	for (int i = 0; i < roman.length(); i++)
	{
		if (ignoreNextChar == "true")
		{
			ignoreNextChar = "false";
			continue;
		}
		int anyBloodyNameHere = GetValue(roman.at(i));
		if ((i + 1) < roman.length())
		{
			int nextVal = GetValue(roman.at(i + 1));
			if (nextVal > anyBloodyNameHere)
			{
				num += nextVal - anyBloodyNameHere;
				ignoreNextChar = "true";
				continue;
			}
		}
		num += GetValue(roman.at(i));
	}
	cout << num << endl;

}

int GetValue(char romanNumeral)
{
	switch (romanNumeral)
	{

	case 'M':
		return 1000;
	case 'D':
		return 500;
	case 'C':
		return 100;
	case 'L':
		return 50;
	case 'X':
		return 10;
	case 'V':
		return 5;
	case 'I':
		return 1;
	}
	return 0;
}

[shadowmouse]

You should at least declare, if not define GetValue() before main(), which by the way, should be main(), not Main().

[ProgrammerXYZ]

I did that, but how exactly would you do it. I put void GetValue(), and it says that function does not take 1 arguments

[ProgrammerXYZ]

Nevermind I got it

[TheIdeasMan]

Hi,

A few things:

ignoreNextChar could be of type bool , then line 18 could just be if (ignoreNextChar)

length() returns a std::size_t type not an int

If values must positive, consider using one of the unsigned types.

After calling GetValue(), test the result to see that it is not zero.

Try to avoid having using namespace std; Put std:: before each std thing - it's the easiest and best way in the end, all the experienced coders do this.

Good Luck !!