linked list

[shotjase]

i have this linked list which creates a list then displays it. it compiles but the append function is having problems, can ne1 c what im doing wrong.thanks

#include <iostream>
#include <cstdlib>
#include <cassert>
using namespace std;


struct nodeType
{
   int info;
   nodeType *link;
};

void printList(nodeType *first);
void append(nodeType * first, int x);

int main()
{
 
    int x;
    nodeType *head = NULL;   
    cout << "Enter some ints - terminate with control-Z "<< endl;
    while (cin >> x)
       append(head, x);  
    cout << endl;
    printList(head);
    system("pause");
    return EXIT_SUCCESS;
}

void append(nodeType * first, int x) 
{
   // append a node containing x to 
   // the end of the list first 
   nodeType *temp = new nodeType;
   temp ->info = x;
   temp->link = NULL;
   if (first == NULL)
      first = temp;

   else
   {
      nodeType *p = first;
      assert (p != NULL);
      while(p != NULL)
         p = p -> link;
          
      p->link = temp;
   }
}

void printList(nodeType *first)
{
    // displays the list 
    // pointed to by first
    nodeType *current = first;
    while (current != NULL)
    {
        cout << current->info << " ";
        current = current->link;
    }
    cout << endl;
}

[Duthomhas]

I think you mean to check that (p->link != NULL) [line 44].

[DiptenduDas]

Another thing I want to add...
U need to change the prototype of the below to methods

from

void printList(nodeType *first);
void append(nodeType * first, int x);

to

void printList(nodeType **first);
void append(nodeType ** first, int x);

Then make necessary changes in the corresponding methods..

[ropez]

I don't think he needs to change printList, and I think this will be better:

void append(nodeType *& first, int x);

Then he shouldn't need to change the code.

[DiptenduDas]

Yes repez U r right, Sorry my mistake :-(.