Binary Search Problem

Hello guys I create a code for Binary Tree. This program read values from a file to insert into a tree. the files contains number like 100,715,6161,1,50,etc.

The program runs, but the problem lies in the search tree and display. I fix it a couple of times but still cannot find the problem. Please assist me thanks.



http://cpp.sh/8fb52

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
# include <iostream>
# include <cstdlib>
# include <fstream>
# include <string>
using namespace std;

struct node

{

    int info;
    struct node *left;
    struct node *right;

}*root;


class BST

{

    public:

        void find(int, node **, node **);
        void inOrderPrint(node *);
        bool search(int);
        void del(int);
        bool insert(node*, int);
        void case_a(node *,node *);
        void case_b(node *,node *);
        void case_c(node *,node *);
        void display(node *, int);
        void load_from_file(char *);
        BST()
        {
            root = NULL;
        }
};



int main()

{

    int choice, num;
    BST bst;
    node *temp;
    while (1)
    {


        cout<<"       Binary Search Tree Menu        "<<endl;
        cout<<"=============================================="<<endl;
        cout<<"1. Read values from a file to insert into tree"<<endl;
        cout<<"2. Search the tree for a value" << endl;
        cout<<"3. Delete Element "<<endl;
        cout<<"4. Display"<<endl <<endl;
        cout<<"0. Exit"<<endl <<endl;
        cout<<"Enter your choice : " << endl;
        cout<<"=============================================="<<endl;
        cin>>choice;

        switch(choice)

        {

        case 1:
             char s[10];
             cout << "What file do you want to read:hw3_ input1, hw3_input2, or hw3_input3? " << endl;
              cin >> s;
             bst.load_from_file(s);
            break;
 case 2:

            if(root == NULL)
            {
                cout<<"Tree is empty, nothing to search"<< endl;
                continue;
            }


            cout <<"Enter a number to be search: " << endl;
            cin >> num;
            bst.search(num);

            if(root != NULL)
            {
                cout<<"FOUND"<<endl;
                    break;
            }
            else
            {
                cout<<"NOT FOUND"<<endl;
                break;
            }
            break;

        case 3:

            if (root == NULL)
            {

                cout<<"Tree is empty, nothing to delete"<<endl;
                continue;

            }

            cout<<"Enter the number to be deleted : ";
            cin >> num;
            bst.del(num);
            break;

        case 4:


            cout<<"Display BST:"<<endl;
            bst.display(root,1);
            //bst.inOrderPrint(root);
            cout<<endl;
            break;

        case 0:

            exit(1);

        default:

            cout<<"Error"<<endl;

        }

    }

}
//Find Element in the Tree
void BST::find(int item, node **par, node **loc)

{

    node *ptr, *ptrsave;

    if (root == NULL)

    {

        *loc = NULL;

        *par = NULL;

        return;

    }

    if (item == root->info)

    {

        *loc = root;

        *par = NULL;

        return;

    }

    if (item < root->info)

        ptr = root->left;

    else

        ptr = root->right;

    ptrsave = root;

    while (ptr != NULL)

    {

        if (item == ptr->info)

        {

            *loc = ptr;

            *par = ptrsave;

            return;

        }

        ptrsave = ptr;

        if (item < ptr->info)


            ptr = ptr->left;

    else

        ptr = ptr->right;

    }

    *loc = NULL;

    *par = ptrsave;

}
//Search Element from the tree

bool BST:: search(int item)
{
    node *temp = temp;

        while(temp!=NULL)
        {
            if(temp->info==item)
            break;

            if(item >temp->info)
            temp = temp->right;

            else
                if(item < temp->info)
                temp = temp->left;
        }

        if(temp ==NULL)
            return false;

        if(temp->info == item)
            return true;

        return false;
}
// Delete Element from the tree


void BST::del(int item)

{

    node *parent, *root;

    if (root == NULL)

    {

        cout<<"Tree empty"<<endl;

        return;

    }

    find(item, &parent, &root);

    if (root == NULL)

    {

        cout<<"Item not present in tree"<<endl;

        return;

    }

    if (root->left == NULL && root->right == NULL)

       case_a(parent, root);

    if (root->left != NULL && root->right == NULL)

       case_b(parent, root);

    if (root->left == NULL && root->right != NULL)

       case_b(parent, root);

    if (root->left != NULL && root->right != NULL)

       case_c(parent, root);

     free(root);

}
/*

 * Case A

 */

void BST::case_a(node *par, node *loc )

{

    if (par == NULL)

    {

        root = NULL;

    }

    else

    {

        if (loc == par->left)

            par->left = NULL;

        else

            par->right = NULL;

    }

}
/*

 * Case B

 */

void BST::case_b(node *par, node *loc)

{

    node *child;

    if (loc->left != NULL)

        child = loc->left;

    else

        child = loc->right;

    if (par == NULL)

    {

        root = child;

    }

    else

    {

        if (loc == par->left)

            par->left = child;

        else

            par->right = child;

    }

}
*

 * Case C

 */

void BST::case_c(node *par, node *loc)

{

    node *ptr, *ptrsave, *suc, *parsuc;

    ptrsave = loc;

    ptr = loc->right;

    while (ptr->left != NULL)

    {

        ptrsave = ptr;

        ptr = ptr->left;

    }

    suc = ptr;

    parsuc = ptrsave;

    if (suc->left == NULL && suc->right == NULL)

        case_a(parsuc, suc);

    else

        case_b(parsuc, suc);

    if (par == NULL)

    {

        root = suc;

    }

    else

    {

        if (loc == par->left)

            par->left = suc;

        else

            par->right = suc;

    }

    suc->left = loc->left;

    suc->right = loc->right;

}
// Display Tree Structure


void BST::display(node *ptr, int level)

{

    int i;

    if (ptr != NULL)

    {

        display(ptr->right, level+1);

        cout<<endl;

        if (ptr == root)

            cout<<"Root->:  ";

        else

        {

            for (i = 0; i < level;i++)

                cout<<"       ";

        }

        cout<<ptr->info;

        display(ptr->left, level+1);

    }

}
void BST::inOrderPrint(node * current)
{
    if(current == NULL)
    {
        cout<<"Tree is empty"<< endl;
        return;
    }
    //recursive call to the left and right
    if(current != NULL)
    {
        inOrderPrint(current->left);
        cout<<current->info<<"  ";
        inOrderPrint(current->right);

    }
    else
        if(current == NULL)
            return;
    //check when we reach the bottom of the tree (left and right are NULL)
}

void BST::load_from_file(char * fn)
{
    ifstream ifs;
    ifs.open(fn);
    if (ifs.is_open())
    {
        int num;
        while (!ifs.eof())
        {
            ifs >> num;
            if (ifs.good())
            {
                BST bst;
                node *temp;
                temp = new node;
                temp->info = num;
                bst.insert(root,num);
            }
        }

        ifs.close();
    }
}
bool BST::insert(node *tree, int info)
{
   if(root == NULL){
      root = new node;
      root->info = info;
      root->left = NULL;
      root->right = NULL;
      return true;
   }
   if(info > tree->info){
       if(tree->right == NULL){
           node * newnode;
           newnode = new node;
           newnode -> info = info;
           newnode -> left = NULL;
           newnode -> right = NULL;
           return true;
       }
       return insert(tree->right, info);
   }
   if(info < tree->info){
        if(tree->left == NULL){
               node * newnode;
               newnode = new node;
               newnode->info = info;
               newnode->right = NULL;
               newnode->left = NULL;
               return true;
           }
        return insert(tree->left, info);
   }
   return false;

}









Last edited on
Ok,
On line 15, you do not have legal C++ syntax.
Hang on a second while I look at it.
Topic archived. No new replies allowed.