While Loop not working as expected.

[Muddobber]

When I put while (valid = true) the loop prompts me to input Pass but then the program does nothing. When I put while (valid = false) the program doesn't prompt for the input and immediately ends. How do I get this loop to execute properly? It is a bit confusing when a loop contains this many if statements.

  #include <iostream>
#include <string>
using namespace std;

void testLength(int Pass[], int valid);
void testCaps(int Pass[], int valid);
void testNum(int Pass[], int valid);

int main()
{
	int Pass, valid;

	
	while (valid = true)
	{
		cout << "Please enter a password:";
		cin >> Pass;

		int Pass[sizeof(Pass)];
		
		testLength(Pass, valid);
		if (valid = true)
		{
			testCaps(Pass, valid);
			if (valid = true)
			{
				testNum(Pass, valid);
				if (valid = true)
				{
				}
				else
				{
					cout << "Passwords must include at least one number" << endl;
				}
			}
			else
			{
				cout << "Passwords must include at least one uppercase letter" << endl;
			}
		}
		else
		{
			cout << "Passwords must be at least 7 characters long" << endl;
		}
		if (valid = true) break;
	}
	cout << "Thank you, that is a valid password" << endl;
	return 0;
}

void testLength(int Pass[], int valid)
{
	
	if (sizeof(Pass) >= 7)
	{
		valid = true;
	}
	else valid = false;

	return void(valid);

}

void testCaps(int Pass[], int valid)
{
	valid = 0;
	int i = 0;

	while (i < sizeof(Pass))
	{
		if (Pass[i] >= 'A' && Pass[i] <= 'Z')
		{
			valid = true;
		}
	}
	i = i + 1;

	return void(valid);
}

void testNum(int Pass[], int valid)
{
	valid = 0;
	int i = 0;

	while (i < sizeof(Pass) - 1)
	{
		if (Pass[i] >= '0' && Pass[i] <= '9')
		{
			valid = true;
		}
		
	}
	i = i + 1;
	
	return void(valid);
}

[TheIdeasMan]

Hi,

= is assignment, == is for equality.

However, more concisely written: while (vaild) and the opposite of that is while (!valid)

valid should be of type bool, int still works, but bool conveys better meaning IMO

[Thomas1965]

int Pass, valid;

while (valid = true)

Also valid has a random value. It's always a good idea to initialize your vars when you declare them.