Issue with passing info

[Dasbooby]

So this all works except the display_board() function. It sends back an error that "board" is not initialized in the display_board() function, so it's not getting the randomized board. I'm not sure how to pass the board from the generate_board() function to the display_board() function. I've been playing around with pointers on it but can't seem to get that to work either. I did manage to get the generate_board() function to send back a broken version of the board, but I'm not sure why it did that. If someone could give me some advice on what to do, I'd appreciate it.

#include <iostream>
#include <ctime>
#include <cstdlib>

using namespace std;

void generate_board();
void display_board();
void get_move_from_user();
void make_move();

int main()
{
	generate_board();

	display_board();
	
	get_move_from_user();

	return 0;
}

void generate_board()
{
	const int SIZE = 25;
	const int MIN_VALUE = 0;
	const int MAX_VALUE = 24;
	int r;
	char tmp;

	char board[SIZE] = { ' ', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X'};
	
	unsigned seed = time(0);
	srand(seed);

	for (int i = 0; i < SIZE; i++)
	{
		r = (rand() % (MAX_VALUE - MIN_VALUE + 1)) + MIN_VALUE;
		tmp = board[i];
		board[i] = board[r];
		board[r] = tmp;
	}
}

void display_board()
{
	for (int i = 0; i < 25; i++)
	{
		cout << board[i] << " ";
		if (i % 5 == 4)
			cout << endl;
	}
}

void get_move_from_user()
{
	char move;

	cout << "enter a character to make a move: ";

	cin >> move;

	while (move != 'w' && move != 'a' && move != 's' && move != 'd')
	{
		cout << "That is not a valid input, please try again: ";
		cin >> move;
	}
}

void make_move()
{

}

[Mr Impact]

Hello Das, I see you have a problem with passing your array by reference to display the board. Here's how you would do that.

You can define the size of the board globally and it will be a constant to be safe

#define BOARD_SIZE 25 

Here's the function definition you could use to pass an array by reference, you must use an array with the size of BOARD_SIZE

void display_board(int (&board)[BOARD_SIZE]);

This is what it would look like to use the function:

display_board(board);

You would get the following output:

  A B C D
E F G H I
J K L M N
O P Q R S
T U V W X
Press any key to continue . . .

[Dasbooby]

Unfortunately, I'm not supposed to use global variables.

Also, plugging all that in still gave me an error. Says that " board is not initialized" when trying to call display_board(board) .

I tried something like below to return the board to main, but the board comes back with garbage information when I check it with the cout statement.

char * generate_board();
//void display_board(char *);
void get_move_from_user();
void make_move();

int main()
{
	char * z;
	z = generate_board();

	for (int i = 0; i < 25; i++)
	{
		cout << z[i] << " ";
		if (i % 5 == 4)
			cout << endl;
	}

	//display_board(*z);
	
	get_move_from_user();

	return 0;
}

char * generate_board()
{
	const int SIZE = 25;
	const int MIN_VALUE = 0;
	const int MAX_VALUE = 24;
	int r;
	char tmp;

	char board[SIZE] = { ' ', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X'};
	
	unsigned seed = time(0);
	srand(seed);

	for (int i = 0; i < SIZE; i++)
	{
		r = (rand() % (MAX_VALUE - MIN_VALUE + 1)) + MIN_VALUE;
		tmp = board[i];
		board[i] = board[r];
		board[r] = tmp;
	}
	return board;
}

[Mr Impact]

Well then instead of creating a global variable fill the prototype like this then.

void display_board(int (&board)[25]);

The reason your board is not initialized is because you are creating your board locally inside of your generate_board() function. It should be easy for you to understand that.