Big integer calculator for Quotient function with vector

[herbertcheng]

I would like to ask a question. I were coding Big integer calculator for Quotient function with vector in C++. First, in compquient Function.

for (k = quotientSize - 1; k >= 0; k--)
{
    while (lessEqual(buffer, remainder))
    {
        remainder = subtraction(remainder, buffer);
        quotient[k]++;
    }
    divideBy10(buffer);
}

I can't debug and how to fix here! I don't know what is the problem is? The Error message "C++ Libraries out of range!" when i type 4 and calculate 10 divide by 2.

quotient[k]++;

Do i miss something?? Here is the full code:

// Perform huge integer operations.
#include <iostream>
#include <vector>
#include <string>
using namespace std;

enum sign{ plus, minus };
int enterChoice(); // enable user to input menu choice
void inputTwoHugeInts(vector< int > &hugeInt1, vector< int > &hugeInt2);
bool isZero(vector< int > hugeInt);
bool less(vector< int > leftOperand, vector< int > rightOperand);
bool lessEqual(vector< int > leftOperand, vector< int > rightOperand);
vector< int > addition(vector< int > addend, vector< int > adder);
vector< int > subtraction(vector< int > minuend, vector< int > subtrahend);
vector< int > multiplication(vector< int > multiplicand, vector< int > multiplier);
vector< int > compQuotient(vector< int > dividend, vector< int > divisor);
vector< int > compRemainder(vector< int > dividend, vector< int > divisor);
void divideBy10(vector< int > &leftOperand);
void printArithmetic(vector< int > operand1, vector< int > operand2,
	vector< int > result, char op, sign resultSign);

int main()
{
	vector< int > leftOperand;
	vector< int > rightOperand;
	vector< int > result;

	int choice = enterChoice();

	switch (choice)
	{
	case 4:
		inputTwoHugeInts(leftOperand, rightOperand);
		if (isZero(rightOperand))
		{
			cout << "divide by zero!!\n\n";
			break;
		}
		result = compQuotient(leftOperand, rightOperand);
		printArithmetic(leftOperand, rightOperand, result, '/', sign::plus);
		break;
	default: // invalid value
		cout << "Program should never get here!";
	} // end switch

	system("pause");
}

// enable user to input menu choice
int enterChoice()
{
	// display available options
	cout << "Enter your choice\n"
		<< " 1 - test addition\n"
		<< " 2 - test subtracttion\n"
		<< " 3 - test multiplication\n"
		<< " 4 - test dividsion\n";

	int menuChoice;
	do {
		cout << "? ";
		cin >> menuChoice; // input menu selection from user
	} while ((menuChoice < 1) || (menuChoice > 4));
	cout << endl;

	return menuChoice;
} // end function enterChoice

// enable user to input two positive huge integers from user
void inputTwoHugeInts(vector< int > &hugeInt1, vector< int > &hugeInt2)
{
	string s1;
	string s2;
	cout << "Enter two positive huge integers:\n";
	cin >> s1 >> s2;
	cout << endl;

	unsigned hugeInt1Size = s1.size();
	for (int i = hugeInt1Size - 1; i >= 0; --i)
		hugeInt1.push_back(s1[i] - '0');

	unsigned hugeInt2Size = s2.size();
	for (int i = hugeInt2Size - 1; i >= 0; --i)
		hugeInt2.push_back(s2[i] - '0');
}

bool isZero(vector< int > hugeInt)
{
	unsigned size = hugeInt.size();
	if (size == 0)
		return true;
	else
	{
		for (int i = 0; i < size; ++i)
		if (hugeInt[i] != 0)
			return false;
		return true;
	}
}

vector< int > addition(vector< int > addend, vector< int > adder)
{
	int addendSize = addend.size();
	int adderSize = adder.size();
	int sumSize = (addendSize >= adderSize) ? addendSize + 1 : adderSize + 1;

	vector< int > sum(sumSize);

	for (int i = 0; i < addendSize; ++i)
		sum[i] = addend[i];

	for (int i = 0; i < adderSize; ++i)
		sum[i] += adder[i];

	for (int i = 0; i < sumSize - 1; ++i)
	if (sum[i] > 9)
	{
		sum[i] -= 10;
		++sum[i + 1];
	}

	if (sum[sumSize - 1] == 0)
		sum.resize(sumSize - 1);

	return sum;
}

void divideBy10(vector< int > &leftOperand)
{
	int size = leftOperand.size();
	for (int i = 1; i < size; ++i)
		leftOperand[i - 1] = leftOperand[i];

	leftOperand.resize(size - 1);
}

void printArithmetic(vector< int > leftOperand, vector< int > rightOperand,
	vector< int > result, char op, sign resultSign)
{
	for (int i = leftOperand.size() - 1; i >= 0; --i)
		cout << leftOperand[i];

	cout << " " << op << " ";

	for (int i = rightOperand.size() - 1; i >= 0; --i)
		cout << rightOperand[i];

	cout << " == ";

	if (resultSign == sign::minus)
		cout << '-';

	for (int i = result.size() - 1; i >= 0; --i)
		cout << result[i];
	cout << endl << endl;
}

bool less(vector< int > leftOperand, vector< int > rightOperand)
{
	bool i = 0;
	int j;
	int leftOperandSize = leftOperand.size();
	int rightOperandSize = rightOperand.size();
	if (leftOperandSize < rightOperandSize)
	{
		i = 1;
	}
	if (leftOperandSize == rightOperandSize)
	{
		for (j = leftOperandSize - 1; j >= 0; j--)
		{
			if (leftOperand[j] != rightOperand[j])
			{
				if (leftOperand[j] < rightOperand[j])
				{
					i = 1;
				}
				break;
			}
		}
	}
	return i;
}

bool lessEqual(vector< int > leftOperand, vector< int > rightOperand)
{
	bool i = 1;
	int j;
	int leftOperandSize = leftOperand.size();
	int rightOperandSize = rightOperand.size();
	if (leftOperandSize > rightOperandSize)
	{
		i = 0;
	}
	if (leftOperandSize == rightOperandSize)
	{
		for (j = leftOperandSize - 1; j >= 0; j--)
		{
			if (leftOperand[j] != rightOperand[j])
			{
				if (leftOperand[j] > rightOperand[j])
				{
					i = 0;
				}
				break;
			}
		}
	}
	return i;
}

vector< int > subtraction(vector< int > minuend, vector< int > subtrahend)/////////////////////////////////
{
	int minuendSize = minuend.size();
	int subtrahendSize = subtrahend.size();
	int differenceSize = (minuendSize >= subtrahendSize) ? minuendSize + 1 : subtrahendSize + 1;

	vector< int > difference(differenceSize);

	for (int i = 0; i < minuendSize; ++i)
		difference[i] = minuend[i];

	for (int i = 0; i < subtrahendSize; ++i)
		difference[i] -= subtrahend[i];

	for (int i = 0; i < differenceSize - 1; ++i)
	if (difference[i] < 0)
	{
		difference[i] += 10;
		difference[i + 1]--;
	}

	while (differenceSize > 1)
	{
		if (difference[differenceSize - 1] == 0)
		{
			difference.resize(differenceSize - 1);
			differenceSize--;
		}
		else
		{
			break;
		}
	}

	return difference;
}

vector< int > compQuotient(vector< int > dividend, vector< int > divisor)
{

	int	k;

	int dividendSize = dividend.size();
	int divisorSize = divisor.size();

	int bufferSize = dividendSize;
	vector< int > buffer(bufferSize);

	int quotientSize = dividendSize - divisorSize + 1;
	vector< int > quotient(quotientSize);

	int remainderSize = dividendSize;
	vector< int > remainder(remainderSize);

	for (int i = 0; i < dividendSize - 1; i++)
	{
		remainder[i] = dividend[i];
	}

	for (int i = divisorSize - 1; i >= 0; i--)
	{
		buffer[dividendSize - divisorSize + i] = divisor[i];
	}

	if (::less(dividend, buffer))
	{
		divideBy10(buffer);
		quotient.resize(quotientSize - 1);
	}

	for (k = quotientSize - 1; k >= 0; k--)
	{
		while (lessEqual(buffer, remainder))
		{
			remainder = subtraction(remainder, buffer);
			quotient[k]++;
		}
		divideBy10(buffer);
	}
	return quotient;
}





vector< int > compRemainder(vector< int > dividend, vector< int > divisor)
{

	int	k;

	int dividendSize = dividend.size();
	int divisorSize = divisor.size();

	int bufferSize = dividendSize;
	vector< int > buffer(bufferSize);

	int quotientSize = dividendSize - divisorSize + 1;
	vector< int > quotient(quotientSize);

	int remainderSize = dividendSize;
	vector< int > remainder(remainderSize);

	for (int i = 0; i < dividendSize - 1; i++)
	{
		remainder[i] = dividend[i];
	}

	for (int i = divisorSize - 1; i >= 0; i--)
	{
		buffer[dividendSize - divisorSize + i] = divisor[i];
	}

	if (::less(dividend, buffer))
	{
		divideBy10(buffer);
		quotient.resize(quotientSize - 1);
	}

	for (k = quotientSize - 1; k >= 0; k--)
	{
		while (lessEqual(buffer, remainder))
		{
			remainder = subtraction(remainder, buffer);
			quotient[k]++;
		}
		divideBy10(buffer);
	}
	return remainder;
}

[48T7M4Gy]

What I suggest you do is adopt a form of unit testing. Instead of wading through 341 lines of stuff and menus, extract the relevant bits and produce a new small main with test data.

Running convoluted and irrelevant code is a recipe for a long day and night of fault finding. This way will take 5 mins to set up.

Oh, and include line numbers with the error messages you get please. :)

Enter your choice
 1 - test addition
 2 - test subtracttion
 3 - test multiplication
 4 - test dividsion
? 2

Program should never get here! 
Exit code: 0 (normal program termination)

Enter your choice
 1 - test addition
 2 - test subtracttion
 3 - test multiplication
 4 - test dividsion
? 4

Enter two positive huge integers:
234
56

 
Exit code: 0 (normal program termination)

[TheIdeasMan]

I can't debug and how to fix here!

Hi,

Why can't you debug? One should always be able to do this - the world will come to an end when we can't debug :+)

Are you using an IDE? What specifically is wrong with the debugger? Or what problem are you having with it? Is the Watch List window showing?

Sorry for the rapid fire questions, Just trying to sort out what is wrong :+)

As kemort says, always show the entire error verbatim.