Call by reference

[CPlusPlusAnnoyed]

This program is supposed to be scoring goals. The first two, eichel and kane are different from the last one, hodgson. A function was added to main called score_goals, it can't be apart of the member functions. Anyways, score_goals (hodgson, 7) gets hodgson to score 7 goals and when I put in hodgson.print() the 7 goals are supposed to be referenced there as well but when I make void score_goals (Hockey player, int &goals) call by reference like it should be, it doesn't work. It says that there's an error.

main

#include <cstdlib>
#include <iostream>
#include "Hockey.h"
using namespace std;


void tripping ();
void fighting ();
void score_goal ();
void assist_goal ();
void print ();
void score_goals (Hockey player, int &goals);
      
int main(int argc, char *argv[])
{
	Hockey eichel, kane, hodgson;
	
	
    cout << "Eichel stats: ";
    eichel.score_goal ();
    eichel.score_goal ();
    eichel.assist_goal ();
    eichel.tripping ();
    eichel.print ();

    cout << "\n\nKane stats: ";
	kane.assist_goal ();
	kane.assist_goal ();
	kane.assist_goal ();
	kane.fighting ();
	kane.fighting ();
	kane.print ();
	
	score_goals (hodgson, 7);
	cout << "\n\nHodgson stats: ";
	hodgson.print();
	
    cout << "\n\n";
    system("PAUSE");
    return EXIT_SUCCESS;
}

void score_goals (Hockey player, int &goals)
	{
		int count;
		for (count = 0; count < goals; count++)
			player.score_goal();
		cout << "\n\nPlayer in function: ";
		player.print ();
		cout <<"\n\n";
	}

header

#include <iostream>
using namespace std;

// Hockey class keeping track of a player's goals, assists,
// penalties and penalty minutes
class Hockey
{
      private:
        int goals,            // number of goals
            assists,          // number of assists
            penalties,        // number of penalties
            penalty_minutes;  // total of penalty minutes
      public:
         Hockey (); 
         void tripping ();
         void fighting ();
         void score_goal ();
         void assist_goal ();
         void print ();
};

// Records the fact that the player has scored another goal
void Hockey::score_goal ()
{
     goals++;
}

Hockey::Hockey ()
{
     goals=0;
     assists=0;
     penalties=0;
     penalty_minutes=0;
}

void Hockey::tripping ()
{
     penalties++;
     penalty_minutes += 2;
     
}

void Hockey::fighting ()
{
     penalties++;
     penalty_minutes++;
     penalty_minutes++;
     penalty_minutes++;
     penalty_minutes++;
     penalty_minutes++;
}

void Hockey::assist_goal ()
{
     assists++;
}

// Prints the player's current statistics
void Hockey::print ()
{
     cout << "\n\nGoals:   " << goals;
     cout << "\nAssists: " << assists;
     if (penalties == 1)
       cout << "\n" << penalties << " penalty for " 
            << penalty_minutes << " minutes.";
     else
        cout << "\n" << penalties << " penalties for " 
          << penalty_minutes << " minutes.";
}

[Zhuge]

Why do you have to pass goals by reference? Do you understand what that is supposed to mean?

[CPlusPlusAnnoyed]

Yes I understand what it means but my professor told me that it has to be passed by reference. I didn't understand it myself. If score_goals was made apart of the member functions then things would be accomplished much more easily but he requested it to be by reference.

[MikeyBoy]

I'm not sure you do understand what it means. If you did, you'd understand why:

score_goals (hodgson, 7);

can't possibly make any sense. How would a reference to an integer literal possibly work? What is it that you think you're doing here?