vector subscript out of range...

[c00012]

I wrote a code to get two numbers which add up to the target.

here's the code:

#include <iostream>
#include <vector>

using namespace std;

class Solution
{
public:
	vector<int> twoSum(vector<int> &numbers, int target) 
	{
		int len = numbers.size();
		vector<int> r;
		for (int i = 0; i < len - 1; i++) 
		{
			int k = target - numbers[i];
			for (int j = i + 1; j < len; j++) 
			{
				if (numbers[j] == k) 
				{
					r.push_back(i + 1);
					r.push_back(j + 1);
				}
			}
		}
		return r;
	}
};

int main(void)
{
	vector<int> numbers = { 2,7,11,15 };
	vector<int> s;
	int targ;

	cout << "input the target:";
	cin >> targ;

	Solution s1;
	s = s1.twoSum(numbers, targ);

	for (int i = 0; i < s.size(); i++)
		cout << "index1 = " << s[i] << ","<< " index2 = " << s[i + 1] << endl;
	
	system("pause");
	return 0;
}

I got the error message "vector subscript out of range" at cout<<"index1 = "...

I coundn't figure what's error. pls help...

[mutexe]

line 42.
s[i + 1]

That's probably your culprit.
If you are at the ith element in your vector when 'i' is equal s.size() (i.e. the last element in your vector), then i+1 is royally going to screw you up.

In other words, if you have a vector with 10 elements for example, you're asking for the 11th element. Which is bad.

[c00012]

thanks for the tip. It works. thanks you very much!