template class help

[cppnoob25]

How do I make this work? It works for integers correctly but I don't know what to do when passing a string. I don't want the complete implementation of the list so don't give me that thanks. I just want to get this current code working and then I will go off from there.

#include <iostream>

using namespace std;

template <class T>
class List{

private:

    struct Node{
        T data;
        Node * next;
    };

    Node * head;
    Node * current;

public:

    List();
    //~List();
    T insert(T val);
    void print();

};

template <class T>
List<T>::List()
{
    head = nullptr;
}

template <class T>
T List<T>::insert(T val)
{
    Node * n = new Node;
    n->data = val;
    n->next = nullptr;

    if(head == nullptr)
    {
        head = n;
    }
}

template <class T>
void List<T>::print()
{
    cout << head->data;
}

int main()
{
    List<string> one;
    one.insert("red");

}

[Gamer2015]

What's your problem, it works just fine here

[cppnoob25]

really? On my end it just seems to crash for an unknown reason. I'm using codeblocks as my IDE if it matters.

||=== Build: Debug in Review (compiler: GNU GCC Compiler) ===|
In instantiation of 'T List<T>::insert(T) [with T = std::basic_string<char>]':|
|55|required from here|
|44|warning: no return statement in function returning non-void [-Wreturn-type]|
||=== Build finished: 0 error(s), 3 warning(s) (0 minute(s), 0 second(s)) ===|
||=== Run: Debug in Review (compiler: GNU GCC Compiler) ===|

I got those warnings after exiting the console window.

[cppnoob25]

anyone else know what I'm doing wrong here?

[coder777]

Lin 34: T is the result type, but you return nothing. Change to void List<T>::insert(T val) // Note: void
It's not a crash it's just a warning.

In you insert(...) function you're not insert anything. All you're doing is setting the head once. After that the data is lost.

[cppnoob25]

Hey coder thanks for that. Changing T to void fixed my whole program and it ran perfectly.