Battleship Final Help

[Wboyce17]

So my final is due today, it's to create a 2-player game of battleship, and everything was working perfectly except that it doesn't display the hits or misses on the board. I've tried everything and can't seem to get it to work, if someone could take a look at this I'd really appreciate it.

[shadowmouse]

Could you post your code please (using code tags, [ code ] and [ /code ] without the spaces).

[Wboyce17]

Trying to do that now, but my code is too long. What should I do

[shadowmouse]

Can you post the bit of it that should be displaying the hits and misses? Is it a syntax error, or a logic error?

[Wboyce17]

I believe that it's a logic error. It lets you play through the game and will let you know if you got a hit, but it doesn't display it on the board. working on uploading it.

[Wboyce17]

This is a part of it, probably not much use but it's tough to find exactly what I'm looking for in a 1000 line code

   cout << "Enter Horizontal Coordinate (0-9)" << endl;
        cin >> ShotH;
        if (grid[ShotV][ShotH] == ship)
        {
            gridshots2[ShotV][ShotH] == hit;
            cout << "Hit at (" << ShotV << "," << ShotH << ")" << endl;
            print_gridshots2(gridshots2);
            hits1++;
        }
        if (grid[ShotV][ShotH] != ship)
        {
            gridshots2[ShotV][ShotH] == missed;
            cout << "Miss at (" << ShotV << "," << ShotH << ")" << endl;
            print_gridshots2(gridshots2);
        }
        
} while(hits1 < 17 || hits2 < 17);
if (hits1 = 17)
{
   cout << Player2 << "Wins!" << endl;
}

[shadowmouse]

What type is grid and what is ship? Can you post print_gridshots2()?

[Wboyce17]

void print_gridshots2(int gridshots2[10][10])
{
    cout << "  ";
    for(char a = 'A'; a <= 'J'; a++)
    {
        cout << "   " << setw(1) << a;
    }
    cout << endl;
 
    for(int i = 0; i <= 9; i++)
    {
        if(i == 10)
        cout << i;
    else
        cout << " " << i ;
 
        for(int j = 0; j < 10 ; j++)
        {
             if(gridshots2[i][j] == occupied || gridshots2[i][j] == empty){
                cout << setw(4) << " -" ;
        }
        if(gridshots2[i][j] == missed )
        {
                cout << setw(4) << " o";
        }
            if(gridshots2[i][j] == hit )
        {
            cout << setw(4) << " x";
        }
            else if(gridshots2[i][j] == ship)
        {
            cout << setw(4) << " *";
        }
    }
        cout << "\n";
    }
}

[shadowmouse]

Only two things I can see wrong with that is you have if(i==10) when i can never equal 10. And you are using postfix increments rather than prefix. Also just noticed on the first bit of code you put, line 5 and 12 should use = not ==.