Array of abstract class and inheritance

[csstudent123]

Hi

I have this problem

Animal should be abstract. It should hold two data members, name and size to keep the weight of the animal.
Reptile should have habitat as data member to keep information of the habitat such as land, salt water, fresh
water, etc Lastly, Snake should be a class with poisonous as data member to indicate whether it is poisonous or
not.
There should be a showInfo() function which is overridden through the hierarchy. It should provide appropriate
information about the objects. Classes Reptile and Snake should have a non-default constructor to initialize the
data members, while Animal needs a function to set its data member.
The main() function should construct 2 instances each of Reptiles and Snake. These should be stored in an array
of type Animal. A loop should be used to output information on all the objects

My solution:

#include <iostream>
#include <string>

using namespace std;

class Animal{

    protected:
        string name;
        float weight;

    public:
        virtual void setAnimal(string, float);
        void showInfo();
};

void Animal::setAnimal(string nname, float weightt){

    name=nname;
    weight=weightt;

}
void Animal::showInfo(){

    cout<<"Name of animal : "<<endl;
    cout<<"Weight : "<<endl;
}

class Reptile: public Animal{

    private:
        string habitat;
    public:
        Reptile(string);
        ~Reptile();
        void setAnimal(string, float);
        void showInfo();

};

Reptile::Reptile(string habitate):habitat(habitate){



}
Reptile::~Reptile(){}

void Reptile::showInfo(){

    this->Animal::showInfo();
    cout<<"Habitat type: "<<habitat<<endl;
}

class Snake: public Reptile{

    private:
        bool poisonous;
    public:
        Snake(string,bool);
        ~Snake();
        void showInfo();
};

Snake::Snake(string habitatt, bool poison_ous):Reptile(habitatt),poisonous(poison_ous){}
Snake:: ~Snake(){}

void Snake::showInfo(){

    this->Animal::showInfo();
    this->Snake::showInfo();
    cout<<"Poisonous: ";
    if (poisonous==1)
        cout<<"Yes"<<endl;
    else
        cout<<"No"<<endl;
}

int main(){

    Animal** animals= new Animal* [4];

    //animals[0]->setAnimal("Crocs", 225);
    animals[0]=new Reptile("Saltwater");
    /*animals[1]->setAnimal("Lizards", 0.005);
    animals[1]=new Reptile("Lands");
    animals[2]->setAnimal("Cobra", 1.5);
    animals[2]=new Snake("Land", true);
    animals[3]->setAnimal("Anaconda", 5);
    animals[3]=new Snake("Swamps", false );
*/

    animals[0]->showInfo();

    return 0;
}

[csstudent123]

Not getting to do as question asks..what is my syntax error ?

[cire]

If you had a syntax error you should have supplied the error the compiler spit out at you. I see a few problems. Snake::showInfo() calls itself unconditionally which means that it will never return (it is essentially an infinite recursive loop.)

Animal::ShowInfo should be virtual. Animal::setAnimal should not be. It also should not be hidden by derived class implementations.

[ne555]

¿not caring enough to say what you are getting?


> There should be a showInfo() function which is overridden through the hierarchy.

class Animal{

    protected:
        string name;
        float weight;

    public:
        /*virtual */void setAnimal(string, float);
        virtual void showInfo();
        virtual ~Animal() = default; //also need this, as you have at least one virtual member function
};

Also

void Animal::showInfo(){

    cout<<"Name of animal : "<<endl; //may want to output your member variables here
    cout<<"Weight : "<<endl;
}

[csstudent123]

Thanks, Is working afyer I changed to virtual showinfo();

:)

[MikeyBoy]

Animal should be abstract.

I guess you should do that, since it was the very first thing you were told to do.