C++

Forum

 
Why isn't my code working? PLEASE HELP

diabeticDemon18 (2)
I am currently working on improving a simple project I did for school. This program reads data out of a file called "Order.txt" and outputs information to a file called "Sales.txt". Fairly simple, in fact I got it working exactly how I wanted it to work but I want it to work with header files. So hear is what I have so far:

Source.cpp:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
 
#include <iostream>
#include <iomanip>
#include <fstream>
#include <string>
#include "DataManip.h"
#include "Constants.h"
#include "Calculations.h"

using namespace std;

//Input Globals
double numBooks, numMovies, poundsPeanuts;
string firstName, middleName, lastName;
ifstream order;

//Output Globals
double subtotalBooks, subtotalMovies, subtotalPeanuts; //Pre-shipping costs
double shippingBooks, shippingMovies, shippingPeanuts; //Shipping costs
double totalBooks, totalMovies, totalPeanuts, totalSale; //Total prices
ofstream sales;

//Working Variables
streampos inputPos = 0;

int main()
{
	sales.open("Sales.txt");
	order.open("Order.txt");
	
	do 
	{
		getData(order);
		printData(sales);
	}
	while (!order.eof());

	order.close();
	sales.close();

	return 0;
}


DataManip.cpp:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
 
#include <fstream>
#include <iomanip>
#include <iostream>
#include <string>

void getData(ifstream &input) 
{
	if (input.is_open())
	{
		input.close();
		input.open("order.txt");
		input.seekg(inputPos, input.beg);

		input >> firstName >> middleName;
		input.get();
		getline(input, lastName);
		input >> numBooks >> numMovies >> poundsPeanuts;

		inputPos = input.tellg();
		input.close();
	}
	else
	{
		input.open("order.txt");
		input.seekg(inputPos, input.beg);

		input >> firstName >> middleName;
		input.get();
		getline(input, lastName);
		input >> numBooks >> numMovies >> poundsPeanuts;

		inputPos = input.tellg();
		input.close();
	}
}

void printHeader(ofstream &output)
{
	if (output.is_open())
	{
		output.close();
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << "Customer: " << lastName << ", " << firstName << " " << middleName << endl;
		output << setw(50) << setfill('-') << "" << endl;
		output << setw(9) << left << setfill(' ') << "PRODUCT";
		output << setw(7) << right << "COST";
		output << setw(7) << "UNITS";
		output << setw(10) << "SUBTOTAL";
		output << setw(10) << "SHIPPING";
		output << setw(7) << "TOTAL" << endl;

		output.close();
	}
	else
	{
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << "Customer: " << lastName << ", " << firstName << " " << middleName << endl;
		output << setw(50) << setfill('-') << "" << endl;
		output << setw(9) << left << setfill(' ') << "PRODUCT";
		output << setw(7) << right << "COST";
		output << setw(7) << "UNITS";
		output << setw(10) << "SUBTOTAL";
		output << setw(10) << "SHIPPING";
		output << setw(7) << "TOTAL" << endl;

		output.close();
	}
}

void printBooks(ofstream &output)
{
	if (output.is_open())
	{
		output.close();
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Books";
		output << setw(7) << right << PER_BOOK_COST;
		output << setw(7) << numBooks;
		subtotalBooks = calcSubtotalBooks(numBooks);
		output << setw(10) << subtotalBooks;
		shippingBooks = calcShippingBooks(numBooks);
		output << setw(10) << shippingBooks;
		totalBooks = subtotalBooks + shippingBooks;
		output << setw(7) << totalBooks << endl;

		output.close();
	}
	else
	{
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Books";
		output << setw(7) << right << PER_BOOK_COST;
		output << setw(7) << numBooks;
		subtotalBooks = calcSubtotalBooks(numBooks);
		output << setw(10) << subtotalBooks;
		shippingBooks = calcShippingBooks(numBooks);
		output << setw(10) << shippingBooks;
		totalBooks = subtotalBooks + shippingBooks;
		output << setw(7) << totalBooks << endl;

		output.close();
	}
}

void printMovies(ofstream &output)
{
	if (output.is_open())
	{
		output.close();
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Movies";
		output << setw(7) << right << PER_MOVIE_COST;
		output << setw(7) << numMovies;
		subtotalMovies = calcSubtotalMovies(numMovies);
		output << setw(10) << subtotalMovies;
		shippingMovies = calcShippingMovies(subtotalMovies);
		output << setw(10) << shippingMovies;
		totalMovies = subtotalMovies + shippingMovies;
		output << setw(7) << totalMovies << endl;

		output.close();
	}
	else
	{
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Movies";
		output << setw(7) << right << PER_MOVIE_COST;
		output << setw(7) << numMovies;
		subtotalMovies = calcSubtotalMovies(numMovies);
		output << setw(10) << subtotalMovies;
		shippingMovies = calcShippingMovies(subtotalMovies);
		output << setw(10) << shippingMovies;
		totalMovies = subtotalMovies + shippingMovies;
		output << setw(7) << totalMovies << endl;

		output.close();
	}
}

void printPeanuts(ofstream &output)
{
	if (output.is_open())
	{
		output.close();
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Peanuts";
		output << setw(7) << right << PER_POUND_COST;
		output << setw(7) << poundsPeanuts;
		subtotalPeanuts = calcSubtotalPeanuts(poundsPeanuts);
		output << setw(10) << subtotalPeanuts;
		shippingPeanuts = calcShippingPeanuts(poundsPeanuts);
		output << setw(10) << shippingPeanuts;
		totalPeanuts = subtotalPeanuts + shippingPeanuts;
		output << setw(7) << totalPeanuts << endl;

		output.close();
	}
	else
	{
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		output << setw(9) << left << "Peanuts";
		output << setw(7) << right << PER_POUND_COST;
		output << setw(7) << poundsPeanuts;
		subtotalPeanuts = calcSubtotalPeanuts(poundsPeanuts);
		output << setw(10) << subtotalPeanuts;
		shippingPeanuts = calcShippingPeanuts(poundsPeanuts);
		output << setw(10) << shippingPeanuts;
		totalPeanuts = subtotalPeanuts + shippingPeanuts;
		output << setw(7) << totalPeanuts << endl;

		output.close();
	}
}

void printFooter(ofstream &output)
{
	if (output.is_open())
	{
		output.close();
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		totalSale = totalMovies + totalPeanuts + totalBooks;
		output << setw(50) << right << totalSale << endl;
		output << setw(50) << setfill('-') << "" << endl << endl;
		output << setfill(' ');

		output.close();
	}
	else
	{
		output.open("Sales.txt", ios::app);

		output << setprecision(2) << fixed << showpoint;
		totalSale = totalMovies + totalPeanuts + totalBooks;
		output << setw(50) << right << totalSale << endl;
		output << setw(50) << setfill('-') << "" << endl << endl;
		output << setfill(' ');

		output.close();
	}
}

void printData(ofstream &output)
{
	printHeader(output);
	printBooks(output);
	printMovies(output);
	printPeanuts(output);
	printFooter(output);
}


Calculations.cpp:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
 
#include "Constants.h"

double calcSubtotalBooks(double numBooks)
{
	double subtotal = numBooks * PER_BOOK_COST;
	return subtotal;
}

double calcSubtotalMovies(double numMovies)
{
	double subtotal = numMovies * PER_MOVIE_COST;
	return subtotal;
}

double calcSubtotalPeanuts(double poundsPeanuts)
{
	double subtotal = poundsPeanuts * PER_POUND_COST;
	return subtotal;
}

double calcShippingBooks(double numBooks)
{
	double shipping = numBooks * BOOK_SHIPPING;
	return shipping;
}

double calcShippingMovies(double subtotalMovies)
{
	double shipping = subtotalMovies * MOVIE_SHIPPING;
	return shipping;
}

double calcShippingPeanuts(double poundsPeanuts)
{
	double shipping = poundsPeanuts * PEANUT_SHIPPING;
	return shipping;
}


Calculations.h:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
 
#ifndef CALCULATIONS_H
#define CALCULATIONS_H

//Subtotal Calculation Functions
double calcSubtotalBooks(double numBooks);
double calcSubtotalMovies(double numMovies);
double calcSubtotalPeanuts(double poundsPeanuts);

//Shipping Calculation Functions
double calcShippingBooks(double numBooks);
double calcShippingMovies(double subtotalMovies);
double calcShippingPeanuts(double poundsPeanuts);

#endif


DataManip.h: 

1
2
3
4
5
6
7
8
9
10
11
12
13
14
 
#ifndef DATAMANIP_H
#define DATAMANIP_H

#include <fstream>

void getData(ifstream &input);
void printData(ofstream &output);
void printHeader(ofstream &output);
void printBooks(ofstream &output);
void printMovies(ofstream &output);
void printPeanuts(ofstream &output);
void printFooter(ofstream &output);

#endif
diabeticDemon18 (2)
P.S. :
So, I have all this code and whenever I try to compile it I get a long list of errors about "ifstream" being an undeclared identifier. Is there somewhere I've missed a needed inclusion? I also get another error saying that getData's declaration is incompatible with "void getData" declared at the same line as the declaration in question. In other words, it is acting as if it is incompatible with itself... Can anyone help me understand what's going on? Did I miss something? Is there limitations to something that I don't know yet? PLEASE HELP!!!
LB (13399)
using namespace std; is bad practice for multiple reasons. One of those reasons is forgetting to prefix identifiers with std::
diabeticDemon18 wrote:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
 
#ifndef DATAMANIP_H
#define DATAMANIP_H

#include <fstream>

void getData(ifstream &input);
void printData(ofstream &output);
void printHeader(ofstream &output);
void printBooks(ofstream &output);
void printMovies(ofstream &output);
void printPeanuts(ofstream &output);
void printFooter(ofstream &output);

#endif
Lines 6-12 should be:
6
7
8
9
10
11
12
 
void getData(std::ifstream &input);
void printData(std::ofstream &output);
void printHeader(std::ofstream &output);
void printBooks(std::ofstream &output);
void printMovies(std::ofstream &output);
void printPeanuts(std::ofstream &output);
void printFooter(std::ofstream &output);
Hopefully, you can see how to fix the rest of your code.
Last edited on
Topic archived. No new replies allowed.