problem in search

[dpdeepanshupatil]

#include<fstream.h>
#include<conio.h>
#include<stdio.h>
#include<string.h>
#include<process.h>

	class car
	{
		public:
		int carno;
		char model[20],mf[20],chno[10],col[15],des[100];
		int mil,price;
	void accept()
		{
		clrscr();
		cout<<"\tEnter The Special Car Number";cin>>carno;
		cout<<"\tEnter The Manufacturer\n";cout<<"\t";gets(mf);
		cout<<"\tEnter The  Model Of Car";cout<<"\t";gets(model);
		cout<<"\tEnter The Color";cout<<"\t";gets(col);
		cout<<"\tEnter The Price";cout<<"\t";cin>>price;
		cout<<"\tEnter The Mileage";cout<<"\t";cin>>mil;
		cout<<"\tEnter The Chasis Number";cout<<"\t";gets(chno);
		cout<<"\tEnter Description";cout<<"\t";gets(des);
		getch();
		}
	void print()
		{
		clrscr();
		cout<<"Special Car Number";
		cout<<carno;
		cout<<"\nManufacturer\n";
		puts(mf);
		cout<<"\nModel";
		puts(model);
		cout<<"\nColor";
		puts(col);
		cout<<"\nPrice";
		cout<<price;
		cout<<"\nMileage";
		cout<<mil;
		cout<<"\nChasis Number";
		puts(chno);
		cout<<"\nDescription";
		puts(des);
		getch();
		}
		friend void intro();
		friend void write();
		friend void read();
		friend void search_carno();
		friend void search_model();
		friend void search_manu();
		friend void search_chno();
		friend void delete_inf();
		friend void modify();
		friend void search_main();
	};
		void intro()
			{
			clrscr();
			gotoxy(11,11);
			cout<<"\tTHIS PROJECT IS MADE BY NARENDRA SINGH";
			gotoxy(13,15);
			cout<<"\t\tTHIS PROJECT IS MADE FOR CAR SHOWROOM";
			getch();
			}
		void write()
			{
				car c;
				clrscr();
				ofstream file("car.rms",ios::binary|ios::app);
				c.accept();
				file.write((char*)&c,sizeof(c));
				file.close();
			}
		void read()
			{
				car c;
				ifstream file("car.rms",ios::binary);
				while(file.read((char*)&c,sizeof(c)))
				c.print();
				file.close();
			}
		void search_carno()
			{
				car c;
				ifstream file("car.rms",ios::binary);
				int x,found=-1;
				cout<<" Enter Car Number To Be Searched\n ";
				cin>>x;
				while(file.read((char*)&c,sizeof(c)))
					{
					if(c.carno==x)
						{
						found=1;
						c.print();
						}
					}
					file.close();
					if(found==-1)
					{
					cout<<"No Result Found";
					       getch();
					}
				}

		void search_model()
			{
				car c;
				ifstream file("car.rms",ios::binary);
				char y[20];
				clrscr();
				cout<<"Enter Model To Be Searched\n";
				gets(y);
				int l=(strlen(y));
				int found=-1;
				while (file.read((char*)&c,sizeof(c)))
					{
					if(strncmp(c.model,y,l==0))
						{
						c.print();
						found=1;
						}
					}
				if(found==-1)
				       {
					cout<<"No Result Found";
			}               getch();
			}
		void search_chno()
			{
				car c;
				ifstream file("car.rms",ios::binary);
				char y[10];
				clrscr();
				cout<<"Enter Chasis Number To Be Searched\n";
				gets(y);
				int l=(strlen(y));
				int found=-1;
				while (file.read((char*)&c,sizeof(c)))
					{
					if(strncmp(c.chno,y,l==0))
						{
						c.print();
						found=1;
						}
					}
				if(found==-1)
				      {
					cout<<"No Result Found";
					getch();
				      }
			   }

		void search_manu()
			{
				car c;
				ifstream file("car.rms",ios::binary);
				char m[20];
				clrscr();
				cout<<"\t\tEnter Manufacturer To Be Searched\n";
				gets(m);
				int l=(strlen(m));
				int found=0;
				while (file.read((char*)&c,sizeof(c)))
					{
					if(strncmp(c.mf,m,l==0))
						{
						c.print();
						found=1;
						}
					}
				if(found==0)
					cout<<"No Result Found";
			}
		void delete_record()
			{
				car c;
				clrscr();
				ifstream file1("car.rms",ios::binary);
				ofstream file2("temp.rms",ios::binary);
				int d;
				cout<<"\t\tEnter The Car Number\n";
				cin>>d;
				while(file1.read((char*)&c,sizeof(c)));
				{
				if(c.carno!=d)
					{
					file2.write((char*)&c,sizeof(c));
					}
				}
			file1.close();
			file2.close();
			remove("car.rms");
			rename("temp.rms","car.rms");
			}
		void modify()
			{
				car c1,c2;
				clrscr();
				ifstream file1("car.rms",ios::binary);
				ofstream file2("temp.rms",ios::binary);
				int o;
				cout<<"\t\tEnter Car Number To Be Modified ";
				cin>>o;
				while(file1.read((char*)&c1,sizeof(c1)));
					{
					if(c1.carno==o)
						{
						c2.accept();
						file2.write((char*)&c2,sizeof(c2));
						}
					else
					file2.write((char*)&c1,sizeof(c1));
					}
					file1.close();
					file2.close();
					remove("car.rms");
					rename("temp.rms","car.rms");
			}
		void search_main()
			{
					int ch;

				do{
					clrscr();
					gotoxy(9,0);
					cout<<"\t\t\tTHE CAR SHOWROOM PROGRAM\n ";
					cout<<"\t\tSearch Menu\n";
					cout<<"\n\n\t\t1.By Carno\n \t\t2.By Model\n \t\t3.By Manufacturer\n \t\t4.By Chasis No.\n \t\t5.Return To Main Menu\n";
					cout<<"\t\t";cin>>ch;
					switch(ch)
					{
						case 1:search_carno();break;
						case 2:search_model();break;
						case 3:search_manu();break;
						case 4:search_chno();break;
						default:exit(0);break;
					}
				}while(ch!=5);

			}
		void main()
			{
				clrscr();
				intro();
				int ch;
			do{     clrscr();
				gotoxy(9,0);
				cout<<"\t\t\tTHE CAR SHOWROOM PROGRAM\n";
				cout<<"\t\t\tMAIN MENU\n\n \t\t\t1.ADD\n \t\t\t2.READ\n \t\t\t3.Search\n \t\t\t4.Delete\n \t\t\t5.Modify\n \t\t\t6.Close Program\n";
				cout<<"\tENTER YOUR CHOICE";cin>>ch;
				switch(ch)
				{
				case 1:write();break;
				case 2:read();break;
				case 3:search_main();break;
				case 4:delete_record();break;
				case 5:modify();break;
				default:exit(0);
				}
			}while(ch!=6);
			getch();
			}

[MiiNiPaa]

Are your program:
1) Not compiles
    * Is other code compiles correctly, i. e. is your compiler configured properly
    * If so, give us error message and corresponding code part.
2) Not running
    * Are you sure that it is not a problem with automatically closing console?
    * How do you run it?
    * Is there any error messages?
3) Gives an error when run
    * Is it system error message or error reported in console?
    * Give us error message and input which leads to error.
4) Not giving correct results
    * Tell what you entered, what you expected, and what you got.
    * Are you sure that results you expected are correct?

[dpdeepanshupatil]

not giving correct result in search menu.

[MiiNiPaa]

What did you enter, what did you got, what did you expect?

Also explait what does tid do:
strncmp( c.model, y, l==0 )

[dpdeepanshupatil]

when i search by car no.
it does no show not found if there is no match found.

[MiiNiPaa]

Your problem is in strncmp function. What do you want to do with it?

[dpdeepanshupatil]

i us this for search by modal function

[MiiNiPaa]

Explain how exactly are you using it, what is the meaning and value of each parameter. You have a serious problem with it and you need to find what is wrong.

[dpdeepanshupatil]

Actually i have to prepare a project on car show room.i have to submit it in my school so please check it if any other error is their..according to u..plze.help me in this..

[MiiNiPaa]

As I said, your comparison does not make sense. Right now it does following:
if(/*First letter of search string and car are not same*/)
Hint: you misplaced = sign (or closigng brace).

[dpdeepanshupatil]

void search_carno()
{
car c;
ifstream file("car.rms",ios::binary);
int x,found=-1;
cout<<" Enter Car Number To Be Searched\n ";
cin>>x;
while(file.read((char*)&c,sizeof(c)))
{
if(c.carno==x)
{
found=1;
c.print();
}
}
file.close();
if(found==-1)
{
cout<<"No Result Found";
getch();
}
}
i have prob only in this function

[MiiNiPaa]

Give example of "car.rms". You function should work (it is only one which should work correctly).

[dpdeepanshupatil]

i cant under stand. what you are telling?
pleas solve the error in the cpp code i had given you if u can..

[MiiNiPaa]

there is no error in void search_carno(), provided your file car.rms is correct and there is no bugs in whichever ancient nonstandard compiler you are using. So I want to see file you are opening to reproduce your problem.

[dpdeepanshupatil]

i have delete that file.
but same prob is their.
i am using C++ compiler...

[MiiNiPaa]

i have delete that file.

So how do you test your code? Why do you think it is not correct if you did not even run it?

i am using C++ compiler...

..which one? There are many.

[dpdeepanshupatil]

Turbo C++ IDE
by re entering all data which the program stored in the file "car.rms".

[MiiNiPaa]

by re entering all data which the program stored in the file "car.rms".

So after reebtering the data, program shoul generate new car.rms file. post it.

[dpdeepanshupatil]

 21 Search
11 4.Delete
5ddas fy
6.C s –j ’ÿ qFddd ”ŠF2¤ÿ\* –q jjj¸ÿ6j––
T’ 1 Âÿò:j T
Üÿ;?T1 ôÿT
ìÿ]<Tèÿ
ú

&

[MiiNiPaa]

Err, you should post it as a file. You cannot post binary data as text