The resistor program problem

[grndnatllvr]

I have a lab that is do tonight and I am down to the last error and I am stuck, so any help would be awesome! I am using Visual Basic 2010 and the error is: 1>Lab 2.6.cpp(39): error C2059: syntax error : ';' and it exists in the Lab 2.cpp file. I will make it bold and underline the line where the error is occurring.

// file Resistor.h

#include "stdafx.h"
#include <iostream>
#include <iomanip>
#include <string>
using namespace std;

class Resistor
	{
		private:
			string name;
			double value;
			double tolerance;
			double minValue;
			double maxValue;
		public:
			void DisplayResistor();
			void GetResistance();
	};

// file Resistor.cpp

#include "stdafx.h"
#include "Resistor.h"
#include<iostream>
#include<iomanip>
#include<string>
using namespace std;

void Resistor::DisplayResistor()
	{
	};

void Resistor::GetResistance()
	{
	};

// Lab 2.6.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"


int _tmain(int argc, _TCHAR* argv[])
{
	return 0;
}

#include "Resistor.h"
#include<iostream>
#include<iomanip>
#include<string>
using namespace std;

class ResistorClass
	{
		private:
			double m_dResValue;
			double m_dTolerance;
			double m_dMinResistance;
			double m_dMaxResistance;
		public:
			string m_cResistorName;
			void DisplayResistor( void );
			void EnterResistance (void );
			void AddSeries ( ResistorClass Resistor1, ResistorClass Resistor2 );
			ResistorClass( );
			ResistorClass( string Name, double nominalResistance, double Tolerance );
			ResistorClass( const ResistorClass &ResistorObject );
			~ResistorClass( );
	};

int main( void )
	{
		ResistorClass oResOne;
                Resistor tolerance = 20%; //error occurs here!
		ResistorClass oResTwo("Resistor 2",4700,20);
		ResistorClass oResThree(oResTwo);
		oResOne.DisplayResistor();
		oResTwo.DisplayResistor();
		oResThree.DisplayResistor();
		system("pause");
		return 0;
	}

void ResistorClass:: DisplayResistor ( void )
	{
		cout << fixed << setprecision (2);
		cout<<"Values for "<<m_cResistorName<<" are: "<<endl;
		cout<<"Resistor Nominal Value = "<<m_dResValue<<endl;
		cout<<"ohmsResistorTolerance = "<<m_dTolerance*100<<" %"<<endl;
		cout<<"Mininimum Resistance = "<<m_dMinResistance<<" ohms"<<endl;
		cout<<"Maximum Resistance = "<<m_dMaxResistance<<" ohms"<<endl;
		cout<<endl;
	}

void ResistorClass::EnterResistance (void)
	{
		m_dResValue = -1;
		while (m_dResValue < 1)
			{
				cout << "Enter Resistor Value: " <<endl;
				cin >> m_dResValue;
				if (m_dResValue < 1 || m_dResValue > 10000000)
					{
						cout << "Input Error Resistor Value must be > 1" << endl;
						cout << "Please Enter a value that is > 1: " << endl;
						cin >> m_dResValue;
					}
				else break;
			}
		m_dTolerance = -1;
		while (m_dTolerance < 1)
			{
				cout << "Enter Resistor Tolerance: " << endl;
				cin >> m_dTolerance;
				if (m_dTolerance < 1 || m_dTolerance > 10000000)
					{
						cout << "Input Error Resistor Tolerance Value must be > 1: " << endl;
						cout << "Please Enter a value that is > 1: " << endl;
						cin >> m_dTolerance;
					}
				else break;
			}
		m_dTolerance = m_dTolerance/100;
		m_dMinResistance = m_dResValue - (m_dResValue * m_dTolerance);
		m_dMaxResistance = m_dResValue + (m_dResValue * m_dTolerance);
		cout<<endl;
	}

void ResistorClass:: AddSeries ( ResistorClass Resistor1, ResistorClass Resistor2)
	{
		if( Resistor1.m_dTolerance > Resistor2.m_dTolerance )
			m_dTolerance = Resistor1.m_dTolerance;
		else
			m_dTolerance = Resistor2.m_dTolerance;
			m_dResValue = Resistor1.m_dResValue + Resistor2.m_dResValue;
			m_dMinResistance = m_dResValue - (m_dResValue * m_dTolerance);
			m_dMaxResistance = m_dResValue + (m_dResValue * m_dTolerance);
			cout<<endl;
	}

ResistorClass::ResistorClass( )
	{
		cout << "Enter Resistor Name <default>: " ;
		getline(cin, m_cResistorName, '\n');
		m_dResValue = 1000.0;
		m_dTolerance = 0.10;
		m_dMinResistance = m_dResValue - (m_dResValue * m_dTolerance);
		m_dMaxResistance = m_dResValue + (m_dResValue * m_dTolerance);
		cout <<endl<< "Default Constructor Called:" <<endl;
	}

ResistorClass::ResistorClass( string Name, double nominalResistance, double Tolerance )
	{
		cout <<endl<<"Parameterized Constructor Called:" <<endl;
		m_dResValue = nominalResistance;
		m_dTolerance = double(Tolerance/100);
		m_cResistorName = Name;
		m_dMinResistance = m_dResValue - (m_dResValue * m_dTolerance);
		m_dMaxResistance = m_dResValue + (m_dResValue * m_dTolerance);
	}

ResistorClass::ResistorClass(const ResistorClass &ResistorObject)
	{
		cout<<endl <<"Enter Resister Name <copy>: ";
		getline(cin, m_cResistorName, '\n');
		m_dResValue=ResistorObject.m_dResValue;
		m_dTolerance=ResistorObject.m_dTolerance;
		m_dMaxResistance=ResistorObject.m_dMaxResistance;
		m_dMinResistance=ResistorObject.m_dMinResistance;
		cout <<endl<<"Copy Constructor Called:"<<endl;
	}

ResistorClass:: ~ResistorClass( )
	{
		cout << "Destructor Called "<<endl;
	}

[ats15]

That line just does not make sense. Just delete it and the program will work. what is 20%. Did you mean just 20? and is tolerance an instance of Resistor?

[grndnatllvr]

Yes the tolerance should be an instance of the resistor class. From what I understand that line is supposed to set the resistor tolerance to 20%. I know that % does not mean percent in C++, but the main program (listed as Lab 2.6.cpp) was given to us by the professor.

However I deleted the line and can now run the program but I do not think it is running correctly. The program is supposed to allow the user to change the resistance and tolerance. I can list all the parameters of the program - if you would like.

I think it is something I am missing in the resistor.h or resistor.cpp file.

[dhayden]

Reading the ResistorClass code, it seems that tolerance is the tolerance expressed as a decimal. So 20% should be given as 0.20.

I don't understand the relation betweeen class Resistor and class ResistorClass. They seem to be nearly identical but your main program has no instances of class Resistor. So why set Resistor.tolerance at all?