how to pass character array into and return it from function

[nsw1216]

I am having a problem where cant pass all my keyboard input into a function using character array and returning it as a character array.
HEre is my code.I am using visual C++

#include <iostream.h>
#include <iomanip.h>
#include <string>
class CAT
     {
       public:
           CAT() {} 
           ~CAT() {}        
		  void Setname(char name) { Name=name;}
		  char Getname(){ return Name;}
          
       private:
         char Name;
    };

    int main()
    {
       CAT Litter[3];
       int i;
	   char name,*iname=&name;
       for (i = 0; i < 3; i++)
	   {
          cin>>name;
		  cin.ignore (1000,'\n');
		  Litter[i].Setname(*iname);
	   }
       for (i = 0; i < 3; i++)
       {
          cout<<"Cat #"<<i+1<<": ";
          cout<<Litter[i].Getname()<<endl;
       }
     return 0;
 }

liao
hung
fei
Cat #1: l
Cat #2: h
Cat #3: f

Help provided will be appreciated. Thank you.

[bluezor]

char name = 1 character.
Change it to a string, char* or char array and it should work.

[nsw1216]

If i change all char name to char* name. The program ended in the middle process.
Then, i try with char array as the code below.

#include <iostream.h>
#include <iomanip.h>
#include <string>
class CAT
     {
       public:
           CAT() {} 
           ~CAT() {}        
		  void Setname(char name[50]) { Name[50]=name[50];}
		  char Getname(){ return Name[50];}
          
       private:
         char Name[50];
    };

    int main()
    {
       CAT Litter[3];
       int i;
	   char name[50];
       for (i = 0; i < 3; i++)
	   {
          cin>>name;
		  cin.ignore (1000,'\n');
		  Litter[i].Setname(name);
	   }
       for (i = 0; i < 3; i++)
       {
          cout<<"Cat #"<<i+1<<": ";
          cout<<Litter[i].Getname()<<endl;
       }
     return 0;
 }

ng
shi
wei
Cat #1: ?
Cat #2: ?
Cat #3: ?

Why become like this one ? Any other solution ?

[bluezor]

Name[50] = name[50]; return Name[50];

Your array will have 50 []. Indexing starts at 0 and ends at 49. You're trying to access 50. Also.. that is still one letter only. Why not just use a string? It's much easier to use in your instance.

[nsw1216]

Oic. BUt if i use char* , the program will stopped working in the middle way. Any problem with my source code as below

#include <iostream.h>
#include <iomanip.h>
#include <string>
class CAT
     {
       public:
           CAT() {} 
           ~CAT() {}        
		  void Setname(char* name) { Name=name;}
		  char* Getname(){ return Name;}
          
       private:
         char* Name;
    };

    int main()
    {
       CAT Litter[3];
       int i;
	   char* name;
       for (i = 0; i < 3; i++)
	   {
          cin>>name;
		  cin.ignore (1000,'\n');
		  Litter[i].Setname(name);
	   }
       for (i = 0; i < 3; i++)
       {
          cout<<"Cat #"<<i+1<<": ";
          cout<<Litter[i].Getname()<<endl;
       }
     return 0;
 }

[bluezor]

In your first for() loop, pop a name = new char; in.

       for (i = 0; i < 3; i++)
	   {
                  name = new char;
                  cin>>name;
		  cin.ignore (1000,'\n');
		  Litter[i].Setname(name);
	   }

Remember to
delete name; afterwards.

[nsw1216]

Where should i put the delete name; ?
At the end of the program or after the loop ?
I tried to put it before return 0;. Then, debug error occurred whenever the delete name; is called. the Debug Error says "DAMAGE:After Normal block (#50) at 0x007C1890 ". Why like this one ?

[nsw1216]

If i din put the delete name;, the program runs smoothly. How come one ? Should be needed to put it in right ?

[jsmith]

Ugh, you've got big problems.

Use std::string if you want to hold strings. Otherwise your C-style char* string technique is totally wrong.

[nsw1216]

Means where should i make the correction ?
Please guide me...