logically correct or wrong ?

[gaurav97]

Is this program logically correct or just dumb luck ? Please see the lines 9 to 12. That is where I made some random changes and this code worked !

#include<iostream>
using namespace std;

int main()
{
    int number(int row, int col, int**arr), x, y;
    cout<<"Enter no. of rows: "; cin>>x; cout<<"\n";
    cout<<"Enter no. of columns: "; cin>>y; cout<<"\n";
    int**A=new int*[x];
    for(int g=0; g<x; g++)
    {
        A[g]=new int[x];
    }
    cout<<"Enter the elements of the array.\n";
    for(int u=0; u<x; u++)
    {
        cout<<"Row "<<u+1<<":\n";
        for(int v=0; v<y; v++)
        {
            cout<<"Column "<<v+1<<": ";
            cin>>A[u][v]; cout<<"\n";
        }
        cout<<endl;
    }
    cout<<"The elements of the array are:\n";
    for(int o=0; o<x; o++)
    {
        for(int p=0; p<y; p++)
        {
            cout<<A[o][p]<<"  ";
        }
        cout<<endl;
    }
    number(x, y, A); return 0;
}

int number(int row, int col, int**arr)
{
    int first_high=0, second_high=0;
    for(int a=0; a<row; a++)
    {
        for(int b=0; b<col; b++)
        {
            if(arr[a][b]>first_high)
            {
                first_high=arr[a][b];
            }
        }
    }
    for(int c=0; c<row; c++)
    {
        for(int d=0; d<col; d++)
        {
            if((first_high>arr[c][d])&&(second_high<=arr[c][d]))
            {
                second_high=arr[c][d];
            }
        }
    }
    cout<<"Here, the largest number is "<<first_high<<" and the second largest number is "<<second_high<<".\n";
}

[Computergeek01]

Is this program logically correct or just dumb luck ? ... That is where I made some random changes and this code worked !

If you just made "random changes" to your code, then there was no logic applied on your part. So I would have to call it dumb luck. Do you understand why this works now where as, ostensibly, it did not before?

[gaurav97]

actually that is the part i want to understand :/
Is there a link or something related to this topic ?
Or maybe you can explain it ?

[Computergeek01]

Is there a link or something related to this topic ?

Yes, it's one of his older submissions which is why it doesn't show up in the 'Articles' section, but Disch does an excellent job of explaining why you're probably having trouble wrapping your head around this, here: http://www.cplusplus.com/forum/articles/17108/

EDIT: I should note that the opinion he conveys in this article isn't what you should pay attention to. In fact I don't really agree with it. But the technical content behind it is laid out well and that is what you should gain an insight on by reading this.

[dhayden]

Line 12 should be A[g]=new int[y];. Currently the code creates an X*X matrix instead of an X*Y matrix.

[gaurav97]

i dont think there is any need to change.
its running perfect