Array Problem

[tony2481]

Ok so my program is working properly except for some nasty large, negative number it outputs and I don't know why.
I have narrowed down the problem to these lines of code:

void highlowavgFunc(int e[], int o[], double& Ae, double& Ao)
{

	int maxeElement = -10;
	int maxoElement = -10;
	int mineElement = -10;
	int minoElement = -10;
	int eventotal = 0;
	int oddtotal = 0;
	int me, mo, Me, Mo;

	for (int element = 0; element < 50; element++)
	{
		if (e[maxeElement] < e[element])
			maxeElement = element;
		if (o[maxoElement] < o[element])
			maxoElement = element;
		if (e[mineElement] > e[element])
			mineElement = element;
		if (o[minoElement] > o[element])
			minoElement = element;
	}
	me = e[maxeElement];
	outfile << "Max Even: " << me << endl;
	mo = o[maxoElement];
	outfile << "Max Odd: " << mo << endl;

	Me = e[mineElement];
	outfile << "Min Even: " << Me << endl; //The number outputs here
	Mo = o[minoElement];
	outfile << "Min Odd: " << Mo << endl; //The number outputs here 

The number it outputs is -858993460 and that's not even remotely close to the number I was looking for.

[LB]

The first time the code gets to line 14, the value of maxeElement is still -10, which means you are accessing the memory that just so happens to be before the array. In other words, you are accessing out of bounds.

[tony2481]

ok so how would I fix this then? or would there be another way to initialize maxeElement, maxoElement, mineElement, minoElement

[cire]

Either check within the loop to see if the values you're using are invalid indexes, or just initialize them to some valid index that makes sense: 0, perhaps.

[tony2481]

ok so that fixed one of the numbers, here is the updated code:

void highlowavgFunc(int even[], int odd[], double&, double&);
void maxthanavgFunc(double&, double&, int even[], int odd[]);

int main()
{
	int even[50], odd[50];
	double avgeven, avgodd;
	infile.open("c:\\Users\\Tony\\Documents\\data2.txt");
	if (!infile)
	{
		cout << "Error file not found." << endl;
		system("pause");
		exit(1);
	}
	else
		cout << "Success!" << endl;

	outfile.open("c:\\Users\\Tony\\Documents\\array.txt");

	while (infile)
	{
		for (int i = 0; i < 50; i++)
			infile >> even[i];
		for (int i = 0; i < 50; i++)
		{
			if (even[i] % 2 != 0)
			{
				odd[i] = even[i];
			}
		}

	}

	highlowavgFunc(even, odd, avgeven, avgodd);
	maxthanavgFunc(avgeven, avgodd, even, odd);

	infile.close();
	outfile.close();

	system("pause");
	return 0;
}

//Find the min, max, total, and average
void highlowavgFunc(int e[], int o[], double& Ae, double& Ao)
{

	int maxeElement = 0; //Updated values
	int maxoElement = 0; //Updated values
	int mineElement = 0; //Updated values
	int minoElement = 0; //Updated values
	int eventotal = 0;
	int oddtotal = 0;
	int me, mo, Me, Mo;

	for (int element = 0; element < 50; element++)
	{
		if (e[maxeElement] < e[element])
			maxeElement = element;
		if (o[maxoElement] < o[element])
			maxoElement = element;
		if (e[mineElement] > e[element])
			mineElement = element;
		if (o[minoElement] > o[element]) //The weird number is here
			minoElement = element; //The weird number is here
	}
	me = e[maxeElement];
	outfile << "Max Even: " << me << endl;
	mo = o[maxoElement];
	outfile << "Max Odd: " << mo << endl;

	Me = e[mineElement];
	outfile << "Min Even: " << Me << endl;
	Mo = o[minoElement];
	outfile << "Min Odd: " << Mo << endl;

	for (int element = 0; element < 50; element++)
	{
		eventotal = eventotal + e[element];
		oddtotal = oddtotal + o[element];
	}

	Ae = eventotal / 29;
	outfile << "This is the average for the even array: " << Ae << endl;
	Ao = oddtotal / 21;
	outfile << "This is the average for the odd array: " << Ao << endl;
}

//Find a number higher than the average
void maxthanavgFunc(double& Ae, double& Ao, int e[], int o[])
{
	int element;

	outfile << "These numbers are higher than their respective averages: ";
	for (element = 0; element < 50; element++)
	{
		if (e[element] > Ae)
			outfile << e[element] << "\t";
		if (o[element] > Ao)
			outfile << o[element] << "\t";
	}
	outfile << endl;
}