Divide string into chars

[Oromis]

Hello,

The following programs should divide a string into seperated characters. It works, but is it valid? Is there a better/more standard way to do this?

#include <iostream>

using namespace std;

int main()
{
    string input;
    getline(cin,input);
    
    for (int i=0; i<input.length(); i++)
    {
        const char* ch = input.c_str();
        ch += sizeof(char)*i;
        cout<<*ch<<" ";
    }
    
    cin.ignore();
}

[helios]

input[i]

Oh, and your pointer arithmetic works only as long as sizeof(char)==1.

[jsmith]

#include <iostream>
#include <algorithm>
#include <iterator>
#include <string>

int main() {
    std::string foo = "Hello world";

    std::copy( foo.begin(), foo.end(),
        std::ostream_iterator<char>( std::cout, " " ) );
}

is a better/more standard way.

also:

#include <iostream>
#include <algorithm>
#include <boost/lambda/lambda.hpp>
#include <string>

int main() {
    std::string foo = "Hello world";

    std::for_each( foo.begin(), foo.end(),
       std::cout << boost::lambda::_1 << ' ' );
}

is a better way.

[Duthomhas]

sizeof(char) is guaranteed to equal one.

However, helios's assessment is correct -- you are assuming something about the size of the elements in your array. And using the operator [] is better anyway...

[Oromis]

Oke, thank you. The operator [] seems a lot easier to use ;)